{"id":12305,"url":"https://patchwork.libcamera.org/api/1.1/patches/12305/?format=json","web_url":"https://patchwork.libcamera.org/patch/12305/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210515183826.21003-3-laurent.pinchart@ideasonboard.com>","date":"2021-05-15T18:38:24","name":"[libcamera-devel,2/4] android: camera_metadata: Constify argument to addEntry() and updateEntry()","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"cd37df4dea564dd5d685848100ca1c84d2e47728","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":{"id":14,"url":"https://patchwork.libcamera.org/api/1.1/users/14/?format=json","username":"pinchartl","first_name":"Laurent","last_name":"Pinchart","email":"laurent.pinchart@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/patch/12305/mbox/","series":[{"id":2033,"url":"https://patchwork.libcamera.org/api/1.1/series/2033/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2033","date":"2021-05-15T18:38:22","name":"android: camera_metadata: Miscellaneous improvements","version":1,"mbox":"https://patchwork.libcamera.org/series/2033/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/12305/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/12305/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9079BC31FB\n\tfor ;\n\tSat, 15 May 2021 18:38:44 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 564796891F;\n\tSat, 15 May 2021 20:38:44 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8F7576891B\n\tfor ;\n\tSat, 15 May 2021 20:38:40 +0200 (CEST)","from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EA8D9436;\n\tSat, 15 May 2021 20:38:39 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"EH2seeLy\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1621103920;\n\tbh=r1xv+9WpF9UfQq7xQQxmyGDXXSzvFhn68xI6CqXPaYI=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=EH2seeLyQZscXJ+DwwN5eLdWhNfg27NAUMfbfeKUEAQuObITQojTx6RHkEGQ781Y/\n\tuNNmvTo+awfrQrHSo0vBXgv2erLRRLmk5HL51SatN/kRErTkNc1apEJLTeWqOZN/eC\n\tzCEVxPfoxKIuKqOskUE2+kh1XTOScUliVv90OUac=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Sat, 15 May 2021 21:38:24 +0300","Message-Id":"<20210515183826.21003-3-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.28.1","In-Reply-To":"<20210515183826.21003-1-laurent.pinchart@ideasonboard.com>","References":"<20210515183826.21003-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 2/4] android: camera_metadata: Constify\n\targument to addEntry() and updateEntry()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The addEntry() and updateEntry() overrides that take a reference to a\ncontainer don't need to modify the container. Make it const.\n\nSigned-off-by: Laurent Pinchart \n---\n src/android/camera_metadata.h | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/src/android/camera_metadata.h b/src/android/camera_metadata.h\nindex 56df6f1c9008..f95c34581fe4 100644\n--- a/src/android/camera_metadata.h\n+++ b/src/android/camera_metadata.h\n@@ -42,7 +42,7 @@ public:\n \n \ttemplate\n-\tbool addEntry(uint32_t tag, S &data)\n+\tbool addEntry(uint32_t tag, const S &data)\n \t{\n \t\treturn addEntry(tag, data.data(), data.size(), sizeof(T));\n \t}\n@@ -67,7 +67,7 @@ public:\n \n \ttemplate\n-\tbool updateEntry(uint32_t tag, S &data)\n+\tbool updateEntry(uint32_t tag, const S &data)\n \t{\n \t\treturn updateEntry(tag, data.data(), data.size());\n \t}\n","prefixes":["libcamera-devel","2/4"]}