{"id":12276,"url":"https://patchwork.libcamera.org/api/1.1/patches/12276/?format=json","web_url":"https://patchwork.libcamera.org/patch/12276/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210513152116.17666-6-jacopo@jmondi.org>","date":"2021-05-13T15:21:13","name":"[libcamera-devel,v3,5/8] libcamera: ipu3: imgu: Fix IF height selection","commit_ref":"8f888a8e84858286da9c60757df8609c1474197f","pull_url":null,"state":"accepted","archived":false,"hash":"807f0024a2811fc3a816125b0acf5e4901fa1a7c","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/1.1/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":{"id":15,"url":"https://patchwork.libcamera.org/api/1.1/users/15/?format=json","username":"jmondi","first_name":"Jacopo","last_name":"Mondi","email":"jacopo@jmondi.org"},"mbox":"https://patchwork.libcamera.org/patch/12276/mbox/","series":[{"id":2026,"url":"https://patchwork.libcamera.org/api/1.1/series/2026/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2026","date":"2021-05-13T15:21:08","name":"ipu3: imgu: Improve ImgU calculation procedure","version":3,"mbox":"https://patchwork.libcamera.org/series/2026/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/12276/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/12276/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B77DFC31F1\n\tfor ;\n\tThu, 13 May 2021 15:20:48 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 862636892F;\n\tThu, 13 May 2021 17:20:48 +0200 (CEST)","from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net\n\t[217.70.183.198])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 005B4688E4\n\tfor ;\n\tThu, 13 May 2021 17:20:43 +0200 (CEST)","from uno.homenet.telecomitalia.it\n\t(host-79-53-131-195.retail.telecomitalia.it [79.53.131.195])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 926E4C0004;\n\tThu, 13 May 2021 15:20:42 +0000 (UTC)"],"X-Originating-IP":"79.53.131.195","From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 13 May 2021 17:21:13 +0200","Message-Id":"<20210513152116.17666-6-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.31.1","In-Reply-To":"<20210513152116.17666-1-jacopo@jmondi.org>","References":"<20210513152116.17666-1-jacopo@jmondi.org>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v3 5/8] libcamera: ipu3: imgu: Fix IF\n\theight selection","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Apply to calculateBDSHeight() function the first hunk of commit 243d134\n(\"Fix some bug for some resolutions\") from\nhttps://github.com/intel/intel-ipu3-pipecfg.git.\n\nThe condition for the computed IF rectangle height to be matched\nagainst the desired alignment now makes sure that it is included\nin the minimum and maximum acceptable values.\n\nSigned-off-by: Jacopo Mondi \nTested-by: Jean-Michel Hautbois \nReviewed-by: Jean-Michel Hautbois \nAcked-by: Niklas Söderlund \nReviewed-by: Hirokazu Honda \n---\n src/libcamera/pipeline/ipu3/imgu.cpp | 6 ++++--\n 1 file changed, 4 insertions(+), 2 deletions(-)","diff":"diff --git a/src/libcamera/pipeline/ipu3/imgu.cpp b/src/libcamera/pipeline/ipu3/imgu.cpp\nindex a325b787d916..5912ae4dfc87 100644\n--- a/src/libcamera/pipeline/ipu3/imgu.cpp\n+++ b/src/libcamera/pipeline/ipu3/imgu.cpp\n@@ -135,7 +135,8 @@ void calculateBDSHeight(ImgUDevice::Pipe *pipe, const Size &iif, const Size &gdc\n \t\testIFHeight = std::clamp(estIFHeight, minIFHeight, iif.height);\n \n \t\tifHeight = utils::alignUp(estIFHeight, IF_ALIGN_H);\n-\t\twhile (ifHeight >= minIFHeight && ifHeight / bdsSF >= minBDSHeight) {\n+\t\twhile (ifHeight >= minIFHeight && ifHeight <= iif.height &&\n+\t\t ifHeight / bdsSF >= minBDSHeight) {\n \n \t\t\tbdsHeight = ifHeight / bdsSF;\n \t\t\tif (std::fmod(bdsHeight, 1.0) == 0) {\n@@ -151,7 +152,8 @@ void calculateBDSHeight(ImgUDevice::Pipe *pipe, const Size &iif, const Size &gdc\n \t\t}\n \n \t\tifHeight = utils::alignUp(estIFHeight, IF_ALIGN_H);\n-\t\twhile (ifHeight <= iif.height && ifHeight / bdsSF >= minBDSHeight) {\n+\t\twhile (ifHeight >= minIFHeight && ifHeight <= iif.height &&\n+\t\t ifHeight / bdsSF >= minBDSHeight) {\n \n \t\t\tbdsHeight = ifHeight / bdsSF;\n \t\t\tif (std::fmod(bdsHeight, 1.0) == 0) {\n","prefixes":["libcamera-devel","v3","5/8"]}