{"id":12218,"url":"https://patchwork.libcamera.org/api/1.1/patches/12218/?format=json","web_url":"https://patchwork.libcamera.org/patch/12218/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210507021727.1848611-2-hiroh@chromium.org>","date":"2021-05-07T02:17:26","name":"[libcamera-devel,1/2] libcamera: pipeline: Remove unnecessary v4l2_controls.h includes","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"c7f95888c6b35682d3ac1655cdc0743d4979b618","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/1.1/people/63/?format=json","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/12218/mbox/","series":[{"id":2007,"url":"https://patchwork.libcamera.org/api/1.1/series/2007/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2007","date":"2021-05-07T02:17:25","name":"Remove V4L2Control classes","version":1,"mbox":"https://patchwork.libcamera.org/series/2007/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/12218/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/12218/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B6987BF831\n\tfor ;\n\tFri, 7 May 2021 02:17:38 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 750226891A;\n\tFri, 7 May 2021 04:17:38 +0200 (CEST)","from mail-pl1-x635.google.com (mail-pl1-x635.google.com\n\t[IPv6:2607:f8b0:4864:20::635])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 22B6968909\n\tfor ;\n\tFri, 7 May 2021 04:17:37 +0200 (CEST)","by mail-pl1-x635.google.com with SMTP id b21so4413683plz.0\n\tfor ;\n\tThu, 06 May 2021 19:17:37 -0700 (PDT)","from hiroh2.tok.corp.google.com\n\t([2401:fa00:8f:2:2f2e:9aad:9133:6283])\n\tby smtp.gmail.com with ESMTPSA id\n\ta190sm3299542pfb.185.2021.05.06.19.17.33\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 06 May 2021 19:17:34 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"lFIc6C7a\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=GjwcuHreWEVj+JwWpK43mvf0wXjbSvA4zjcvd9RvIdA=;\n\tb=lFIc6C7a47M7e3UfZ7lyvXdtc5hvEg6BVCvuox2752LHjbnvS8l8UUbe4Zkfq+EDGk\n\tkwlKDXfFBwO3qqV2Vzs1B+a1INcpahnXjoZsMwLX6O3wlvtX7QSgrNROpS7pL3KVzZZh\n\tRkh96I8xmyixAxrb4fkyl3f97jfUqsDLs5Svs=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=GjwcuHreWEVj+JwWpK43mvf0wXjbSvA4zjcvd9RvIdA=;\n\tb=MqnjceJG1LyxJt7jb5O6Vl8PHjARTqRJEK3ZypzafZuXUbQ1xszEEAMahbdHOOWfp9\n\tz1Orxf3TqJQ549Ger/Y0fVm79w2+tBiXwIe0EoWJruS1VFFog6hGal+XaE5Lkj2hd7Kj\n\tM4mVEHNL0qTf5gu8XPJPu6kvHcylbEMCC82GloCOXpWlCTAyH4RwCaDeIS0JNeWk3P7R\n\tC8YsaIK470mIww0586p8eZ36w3LjNkg9KZ+XNDfwU4TR7KuTlCUCdbCgZy+nLYVRmocP\n\tNt46WiSmS1cFgdiIW1mIBkOYYOrrMydRn00SwO4E5+VbH3x3uXp6HOOLdsEhk8mif8rw\n\trcZg==","X-Gm-Message-State":"AOAM530xhh3/UHjx3m+Iy411L4m/lt6SprbX9RUB7ICTkOuFof/8k6g5\n\t9FVIsiJhZObxcsVBHvBXXaof5GmE9rb9QQ==","X-Google-Smtp-Source":"ABdhPJw5VY0s7ZDY1QPSert6gwbBqR9/ZDIDQbgL3EtGIshueOk83cWwqPao1oimDoungTWBXMTPwg==","X-Received":"by 2002:a17:90a:684b:: with SMTP id\n\te11mr8045881pjm.87.1620353854822; \n\tThu, 06 May 2021 19:17:34 -0700 (PDT)","From":"Hirokazu Honda ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 7 May 2021 11:17:26 +0900","Message-Id":"<20210507021727.1848611-2-hiroh@chromium.org>","X-Mailer":"git-send-email 2.31.1.607.g51e8a6a459-goog","In-Reply-To":"<20210507021727.1848611-1-hiroh@chromium.org>","References":"<20210507021727.1848611-1-hiroh@chromium.org>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH 1/2] libcamera: pipeline: Remove\n\tunnecessary v4l2_controls.h includes","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"v4l2_controls.h is includes in some places in pipeline codes.\nBut V4l2Control classes are not used there. This removes the\nredundant v4l2_controls.h includes.\n\nSigned-off-by: Hirokazu Honda \n---\n src/libcamera/pipeline/ipu3/ipu3.cpp | 1 -\n src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 1 -\n src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 1 -\n src/libcamera/pipeline/vimc/vimc.cpp | 1 -\n 4 files changed, 4 deletions(-)","diff":"diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\nindex 73306cea..e9fc41f4 100644\n--- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n@@ -28,7 +28,6 @@\n #include \"libcamera/internal/media_device.h\"\n #include \"libcamera/internal/pipeline_handler.h\"\n #include \"libcamera/internal/utils.h\"\n-#include \"libcamera/internal/v4l2_controls.h\"\n \n #include \"cio2.h\"\n #include \"frames.h\"\ndiff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\nindex 2a917455..34d6044f 100644\n--- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n+++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n@@ -36,7 +36,6 @@\n #include \"libcamera/internal/media_device.h\"\n #include \"libcamera/internal/pipeline_handler.h\"\n #include \"libcamera/internal/utils.h\"\n-#include \"libcamera/internal/v4l2_controls.h\"\n #include \"libcamera/internal/v4l2_videodevice.h\"\n \n #include \"dma_heaps.h\"\ndiff --git a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\nindex b6c6ade5..de1c36bf 100644\n--- a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n+++ b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n@@ -25,7 +25,6 @@\n #include \"libcamera/internal/pipeline_handler.h\"\n #include \"libcamera/internal/sysfs.h\"\n #include \"libcamera/internal/utils.h\"\n-#include \"libcamera/internal/v4l2_controls.h\"\n #include \"libcamera/internal/v4l2_videodevice.h\"\n \n namespace libcamera {\ndiff --git a/src/libcamera/pipeline/vimc/vimc.cpp b/src/libcamera/pipeline/vimc/vimc.cpp\nindex 8f5f4ba3..c242efa3 100644\n--- a/src/libcamera/pipeline/vimc/vimc.cpp\n+++ b/src/libcamera/pipeline/vimc/vimc.cpp\n@@ -30,7 +30,6 @@\n #include \"libcamera/internal/media_device.h\"\n #include \"libcamera/internal/pipeline_handler.h\"\n #include \"libcamera/internal/utils.h\"\n-#include \"libcamera/internal/v4l2_controls.h\"\n #include \"libcamera/internal/v4l2_subdevice.h\"\n #include \"libcamera/internal/v4l2_videodevice.h\"\n \n","prefixes":["libcamera-devel","1/2"]}