{"id":12195,"url":"https://patchwork.libcamera.org/api/1.1/patches/12195/?format=json","web_url":"https://patchwork.libcamera.org/patch/12195/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210505135308.1404-3-david.plowman@raspberrypi.com>","date":"2021-05-05T13:53:08","name":"[libcamera-devel,v3,2/2] libcamera: pipeline: raspberrypi: Update ControlInfos after sensor format change","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"b0fed7e7bbaa2918761da7a7fdba3a6e201f67b9","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/1.1/people/42/?format=json","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/12195/mbox/","series":[{"id":1998,"url":"https://patchwork.libcamera.org/api/1.1/series/1998/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1998","date":"2021-05-05T13:53:06","name":"Fix CameraSensor::sensorInfo by updating VBLANK ControlInfo","version":3,"mbox":"https://patchwork.libcamera.org/series/1998/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/12195/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/12195/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 36C15BDE7C\n\tfor ;\n\tWed, 5 May 2021 13:53:17 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id ABE1B68919;\n\tWed, 5 May 2021 15:53:16 +0200 (CEST)","from mail-wr1-x429.google.com (mail-wr1-x429.google.com\n\t[IPv6:2a00:1450:4864:20::429])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C8C0468901\n\tfor ;\n\tWed, 5 May 2021 15:53:14 +0200 (CEST)","by mail-wr1-x429.google.com with SMTP id t18so1951194wry.1\n\tfor ;\n\tWed, 05 May 2021 06:53:14 -0700 (PDT)","from pi4-davidp.lan (plowpeople3.plus.com. [80.229.223.72])\n\tby smtp.gmail.com with ESMTPSA id\n\tq10sm5901645wmc.31.2021.05.05.06.53.13\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 05 May 2021 06:53:13 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"ZjBmndS/\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=Nnuaul9JxLvXBFAxzfREl6f2jmdSNj5M51MWow4y9o0=;\n\tb=ZjBmndS/+WJx/D2LuItCM8XWKCe/ELtX8ilaAT206Ucxq0rcL4hVEmQ0Z3eXVQ0pm7\n\t6pdOL57hR5JJoXWvXErt+rQrQ5LBxTOGXQ0CVX+daxW+9HejIS+/n0d4koH7c08rWuU7\n\tzKv6kpyQ7gc5cEDPNJUdUds4Ehm4txLJOyACY2ulaqzh/Bsg4ENEeyA7yCAzVmrH416D\n\tyJ6BvkJBkcknOZZye/ptryDhhRLJJ4OjZIXNVXf9IODfxINpG+ol+k4tU6s9LUwyY5Od\n\t9Aa63kHz+eaK+lsMxufNfPWYPnLzHppGtl1DRUAUWhUc+vQaJyK9jHM4LIcyTKzY1frK\n\tnjfw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=Nnuaul9JxLvXBFAxzfREl6f2jmdSNj5M51MWow4y9o0=;\n\tb=GSvE/T5LHQx5ySXxFlvtecJ0gj/Ni7Mu7oKbigyRo6I5vDaKHqhMfmZdO4bBHmKpF2\n\tmlSdYXanwxtCX6zJWFT7xUreWs1OnseVknc5jQxRdmfGZIr6NOlWwZYILatwkeb1PsO/\n\tiLNAW2DnB9cNAEjPw9hm4t+HX+Ilb2kICnyVLTpWWuhBrHaloBhID2pWZLs/2Bxg/KlC\n\tfzKJWzDQSlu+duIQ43y5xyb31qynMB+QVPPCuKj/CI6gekXss6HZMYTmJF8+Mha8QCAS\n\txIULMl4HD40defL/ifjv/4bTkgUNaue5lOHzzz2OYbHW55McKv4AsALlXhh0L0Ovq2LB\n\tEesw==","X-Gm-Message-State":"AOAM533jH8AMZG5oISo+GrQEL1OUkXMWat4yaAuSPSULBZPUw/bgXkSO\n\toIdo3rB0+9ZGUv961Am2NAeWKZXnhXEJGA==","X-Google-Smtp-Source":"ABdhPJw9D7jjwFWkAVsU36vahtT61oBOHHH2hRUTfKsriGq/MK3WFaY7guU2lb/riQ4fm3xQZnkGCg==","X-Received":"by 2002:a05:6000:1789:: with SMTP id\n\te9mr39414015wrg.110.1620222794386; \n\tWed, 05 May 2021 06:53:14 -0700 (PDT)","From":"David Plowman ","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 5 May 2021 14:53:08 +0100","Message-Id":"<20210505135308.1404-3-david.plowman@raspberrypi.com>","X-Mailer":"git-send-email 2.20.1","In-Reply-To":"<20210505135308.1404-1-david.plowman@raspberrypi.com>","References":"<20210505135308.1404-1-david.plowman@raspberrypi.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v3 2/2] libcamera: pipeline: raspberrypi:\n\tUpdate ControlInfos after sensor format change","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The Raspberry Pi pipeline handler does not update the sensor format\nusing CameraSensor::setFormat, so it must manually force the update of\nthe associated ControlInfos.\n\nSigned-off-by: David Plowman \nReviewed-by: Naushir Patuck \nReviewed-by: Kieran Bingham \nReviewed-by: Laurent Pinchart \n---\n src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 7 +++++++\n 1 file changed, 7 insertions(+)","diff":"diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\nindex 2a917455..6288108d 100644\n--- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n+++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n@@ -608,6 +608,13 @@ int PipelineHandlerRPi::configure(Camera *camera, CameraConfiguration *config)\n \tif (ret)\n \t\treturn ret;\n \n+\t/*\n+\t * The control ranges associated with the sensor may need updating\n+\t * after a format change.\n+\t * \\todo Use the CameraSensor::setFormat API instead.\n+\t */\n+\tdata->sensor_->updateControlInfo();\n+\n \tLOG(RPI, Info) << \"Sensor: \" << camera->id()\n \t\t << \" - Selected mode: \" << sensorFormat.toString();\n \n","prefixes":["libcamera-devel","v3","2/2"]}