{"id":12175,"url":"https://patchwork.libcamera.org/api/1.1/patches/12175/?format=json","web_url":"https://patchwork.libcamera.org/patch/12175/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210503104152.34048-7-jacopo@jmondi.org>","date":"2021-05-03T10:41:41","name":"[libcamera-devel,v5,06/17] libcamera: ipu3: Merge IPA metadata controls","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"300aee841085a48b2f7173bd1c43917dce856d1e","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/1.1/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/12175/mbox/","series":[{"id":1994,"url":"https://patchwork.libcamera.org/api/1.1/series/1994/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1994","date":"2021-05-03T10:41:35","name":"Support SensorTimestamp metadata","version":5,"mbox":"https://patchwork.libcamera.org/series/1994/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/12175/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/12175/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A9C4ABDE78\n\tfor ;\n\tMon, 3 May 2021 10:41:19 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 365506892A;\n\tMon, 3 May 2021 12:41:18 +0200 (CEST)","from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net\n\t[217.70.183.199])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2DC486891C\n\tfor ;\n\tMon, 3 May 2021 12:41:14 +0200 (CEST)","from uno.lan (93-34-118-233.ip49.fastwebnet.it [93.34.118.233])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay9-d.mail.gandi.net (Postfix) with ESMTPSA id EC114FF802\n\tfor ;\n\tMon, 3 May 2021 10:41:13 +0000 (UTC)"],"X-Originating-IP":"93.34.118.233","From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 3 May 2021 12:41:41 +0200","Message-Id":"<20210503104152.34048-7-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.31.1","In-Reply-To":"<20210503104152.34048-1-jacopo@jmondi.org>","References":"<20210503104152.34048-1-jacopo@jmondi.org>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v5 06/17] libcamera: ipu3: Merge IPA\n\tmetadata controls","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"When a Request is completed upon receiving the IPA produced metadata,\nthey should be merged with the metadata set by the pipeline handler\nbefore reporting them to applications.\n\nUse ControlList::merge() to collect the IPA produced controls to the\nrequest's metadata.\n\nSigned-off-by: Jacopo Mondi \n---\n src/libcamera/pipeline/ipu3/ipu3.cpp | 5 +----\n 1 file changed, 1 insertion(+), 4 deletions(-)","diff":"diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\nindex 88b7bd1e52c3..ade8ffbddb0e 100644\n--- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n@@ -1190,11 +1190,8 @@ void IPU3CameraData::queueFrameAction(unsigned int id,\n \t\tif (!info)\n \t\t\tbreak;\n \n-\t\t/*\n-\t\t * \\todo Parse the value of the controls returned by the IPA\n-\t\t * in action.controls to register additional metadata.\n-\t\t */\n \t\tRequest *request = info->request;\n+\t\trequest->metadata().merge(action.controls);\n \n \t\tinfo->metadataProcessed = true;\n \t\tif (frameInfos_.tryComplete(info))\n","prefixes":["libcamera-devel","v5","06/17"]}