{"id":12155,"url":"https://patchwork.libcamera.org/api/1.1/patches/12155/?format=json","web_url":"https://patchwork.libcamera.org/patch/12155/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210430160026.190724-17-jacopo@jmondi.org>","date":"2021-04-30T16:00:26","name":"[libcamera-devel,v4,16/16] android: camera_device: Use controls::SensorTimestamp","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"2fac0bf046383dc80426c34d60a98ffcd1dbed47","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/1.1/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/12155/mbox/","series":[{"id":1990,"url":"https://patchwork.libcamera.org/api/1.1/series/1990/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1990","date":"2021-04-30T16:00:10","name":"Support SensorTimestamp metadata","version":4,"mbox":"https://patchwork.libcamera.org/series/1990/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/12155/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/12155/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D0617BDE4C\n\tfor ;\n\tFri, 30 Apr 2021 16:00:13 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7043A68913;\n\tFri, 30 Apr 2021 18:00:13 +0200 (CEST)","from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net\n\t[217.70.183.199])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 43B5C688E4\n\tfor ;\n\tFri, 30 Apr 2021 18:00:06 +0200 (CEST)","from uno.LocalDomain (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay9-d.mail.gandi.net (Postfix) with ESMTPSA id ABE8EFF816;\n\tFri, 30 Apr 2021 16:00:04 +0000 (UTC)"],"X-Originating-IP":"93.61.96.190","From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 30 Apr 2021 18:00:26 +0200","Message-Id":"<20210430160026.190724-17-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.31.1","In-Reply-To":"<20210430160026.190724-1-jacopo@jmondi.org>","References":"<20210430160026.190724-1-jacopo@jmondi.org>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v4 16/16] android: camera_device: Use\n\tcontrols::SensorTimestamp","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Use the controls::SensorTimestamp value to populate\nANDROID_SENSOR_TIMESTAMP result metadata.\n\nThe Camera is assumed to provide the control in the Request metadata.\n\nReviewed-by: Hirokazu Honda \nReviewed-by: Niklas Söderlund \nReviewed-by: Laurent Pinchart \nSigned-off-by: Jacopo Mondi \n---\n src/android/camera_device.cpp | 21 ++++++++-------------\n src/android/camera_device.h | 3 +--\n 2 files changed, 9 insertions(+), 15 deletions(-)","diff":"diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex a71aee2fc734..f1f26c775611 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -2025,7 +2025,6 @@ int CameraDevice::processCaptureRequest(camera3_capture_request_t *camera3Reques\n \n void CameraDevice::requestComplete(Request *request)\n {\n-\tconst Request::BufferMap &buffers = request->buffers();\n \tcamera3_buffer_status status = CAMERA3_BUFFER_STATUS_OK;\n \tstd::unique_ptr resultMetadata;\n \n@@ -2053,14 +2052,7 @@ void CameraDevice::requestComplete(Request *request)\n \tLOG(HAL, Debug) << \"Request \" << request->cookie() << \" completed with \"\n \t\t\t<< descriptor.buffers_.size() << \" streams\";\n \n-\t/*\n-\t * \\todo The timestamp used for the metadata is currently always taken\n-\t * from the first buffer (which may be the first stream) in the Request.\n-\t * It might be appropriate to return a 'correct' (as determined by\n-\t * pipeline handlers) timestamp in the Request itself.\n-\t */\n-\tuint64_t timestamp = buffers.begin()->second->metadata().timestamp;\n-\tresultMetadata = getResultMetadata(descriptor, timestamp);\n+\tresultMetadata = getResultMetadata(descriptor);\n \n \t/* Handle any JPEG compression. */\n \tfor (camera3_stream_buffer_t &buffer : descriptor.buffers_) {\n@@ -2105,6 +2097,9 @@ void CameraDevice::requestComplete(Request *request)\n \tcaptureResult.output_buffers = descriptor.buffers_.data();\n \n \tif (status == CAMERA3_BUFFER_STATUS_OK) {\n+\t\tuint64_t timestamp =\n+\t\t\tstatic_cast(request->metadata()\n+\t\t\t\t\t .get(controls::SensorTimestamp));\n \t\tnotifyShutter(descriptor.frameNumber_, timestamp);\n \n \t\tcaptureResult.partial_result = 1;\n@@ -2164,8 +2159,7 @@ void CameraDevice::notifyError(uint32_t frameNumber, camera3_stream_t *stream)\n * Produce a set of fixed result metadata.\n */\n std::unique_ptr\n-CameraDevice::getResultMetadata(const Camera3RequestDescriptor &descriptor,\n-\t\t\t\tint64_t timestamp) const\n+CameraDevice::getResultMetadata(const Camera3RequestDescriptor &descriptor) const\n {\n \tconst ControlList &metadata = descriptor.request_->metadata();\n \tconst CameraMetadata &settings = descriptor.settings_;\n@@ -2291,8 +2285,6 @@ CameraDevice::getResultMetadata(const Camera3RequestDescriptor &descriptor,\n \tresultMetadata->addEntry(ANDROID_SENSOR_TEST_PATTERN_MODE,\n \t\t\t\t &value32, 1);\n \n-\tresultMetadata->addEntry(ANDROID_SENSOR_TIMESTAMP, ×tamp, 1);\n-\n \tvalue = ANDROID_STATISTICS_FACE_DETECT_MODE_OFF;\n \tresultMetadata->addEntry(ANDROID_STATISTICS_FACE_DETECT_MODE,\n \t\t\t\t &value, 1);\n@@ -2318,6 +2310,9 @@ CameraDevice::getResultMetadata(const Camera3RequestDescriptor &descriptor,\n \t\t\t\t &rolling_shutter_skew, 1);\n \n \t/* Add metadata tags reported by libcamera. */\n+\tconst int64_t timestamp = metadata.get(controls::SensorTimestamp);\n+\tresultMetadata->addEntry(ANDROID_SENSOR_TIMESTAMP, ×tamp, 1);\n+\n \tif (metadata.contains(controls::draft::PipelineDepth)) {\n \t\tuint8_t pipeline_depth =\n \t\t\tmetadata.get(controls::draft::PipelineDepth);\ndiff --git a/src/android/camera_device.h b/src/android/camera_device.h\nindex c63e8e21726e..23457e47767a 100644\n--- a/src/android/camera_device.h\n+++ b/src/android/camera_device.h\n@@ -107,8 +107,7 @@ private:\n \tlibcamera::PixelFormat toPixelFormat(int format) const;\n \tint processControls(Camera3RequestDescriptor *descriptor);\n \tstd::unique_ptr getResultMetadata(\n-\t\tconst Camera3RequestDescriptor &descriptor,\n-\t\tint64_t timestamp) const;\n+\t\tconst Camera3RequestDescriptor &descriptor) const;\n \n \tunsigned int id_;\n \tcamera3_device_t camera3Device_;\n","prefixes":["libcamera-devel","v4","16/16"]}