{"id":12135,"url":"https://patchwork.libcamera.org/api/1.1/patches/12135/?format=json","web_url":"https://patchwork.libcamera.org/patch/12135/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210430043957.111667-2-umang.jain@ideasonboard.com>","date":"2021-04-30T04:39:56","name":"[libcamera-devel,v3,1/2] src: android: Rectify internal header's #include path","commit_ref":"08f74696173c1047f9d8e414021e8cd96a1ab646","pull_url":null,"state":"accepted","archived":false,"hash":"b5227f96cf1547aa4c53fef5f68dab5030f6889d","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/1.1/people/86/?format=json","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/12135/mbox/","series":[{"id":1987,"url":"https://patchwork.libcamera.org/api/1.1/series/1987/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1987","date":"2021-04-30T04:39:55","name":"Rectify inclusion of internal headers","version":3,"mbox":"https://patchwork.libcamera.org/series/1987/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/12135/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/12135/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id ACFB6BDE47\n\tfor ;\n\tFri, 30 Apr 2021 04:40:12 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6A5CF68915;\n\tFri, 30 Apr 2021 06:40:12 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B2418602C0\n\tfor ;\n\tFri, 30 Apr 2021 06:40:10 +0200 (CEST)","from perceval.ideasonboard.com (unknown [103.251.226.128])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id F1D46B1A;\n\tFri, 30 Apr 2021 06:40:08 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"mU+nsxKO\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1619757610;\n\tbh=54Bs8C2zJQmGKlBX3miczy4M2B2cwi+4nqpzhsCwWzw=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=mU+nsxKOJiEzwzqqR6e47LbAh0fnWVRnHIo1uymMZxN0juji2yNvXD/D+nx7YyC6o\n\tW6cpH3orUHsMIMlDfNR/BMwlucKGm10M1nLYRyp59KOACbhRhw6PL0QAIWkNe1czRC\n\tlzLZkyJBofe64Nw/1CLuf4f5tpVZwe6f90jCjSGA=","From":"Umang Jain ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 30 Apr 2021 10:09:56 +0530","Message-Id":"<20210430043957.111667-2-umang.jain@ideasonboard.com>","X-Mailer":"git-send-email 2.26.2","In-Reply-To":"<20210430043957.111667-1-umang.jain@ideasonboard.com>","References":"<20210430043957.111667-1-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v3 1/2] src: android: Rectify internal\n\theader's #include path","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"libcamera internal headers are not installed system-wide. Hence, any\ninclusion of internal headers should be follow the #include directive\nform:\n\t#include \"libcamera/internal/header.h\"\n\nThis was not the case for a few of the class in android HAL. Fix them.\n\nSigned-off-by: Umang Jain \nReviewed-by: Kieran Bingham \nReviewed-by: Hirokazu Honda \n---\n src/android/camera_stream.h | 2 +-\n src/android/mm/generic_camera_buffer.cpp | 2 +-\n src/android/post_processor.h | 2 +-\n 3 files changed, 3 insertions(+), 3 deletions(-)","diff":"diff --git a/src/android/camera_stream.h b/src/android/camera_stream.h\nindex f68fdd3a..34016722 100644\n--- a/src/android/camera_stream.h\n+++ b/src/android/camera_stream.h\n@@ -19,7 +19,7 @@\n #include \n #include \n \n-#include \n+#include \"libcamera/internal/buffer.h\"\n \n class CameraDevice;\n class CameraMetadata;\ndiff --git a/src/android/mm/generic_camera_buffer.cpp b/src/android/mm/generic_camera_buffer.cpp\nindex 929e078a..334498c1 100644\n--- a/src/android/mm/generic_camera_buffer.cpp\n+++ b/src/android/mm/generic_camera_buffer.cpp\n@@ -7,7 +7,7 @@\n \n #include \"../camera_buffer.h\"\n \n-#include \n+#include \"libcamera/internal/buffer.h\"\n #include \"libcamera/internal/log.h\"\n \n using namespace libcamera;\ndiff --git a/src/android/post_processor.h b/src/android/post_processor.h\nindex 4944078b..547fda37 100644\n--- a/src/android/post_processor.h\n+++ b/src/android/post_processor.h\n@@ -10,7 +10,7 @@\n #include \n #include \n \n-#include \n+#include \"libcamera/internal/buffer.h\"\n \n #include \"camera_buffer.h\"\n \n","prefixes":["libcamera-devel","v3","1/2"]}