{"id":12132,"url":"https://patchwork.libcamera.org/api/1.1/patches/12132/?format=json","web_url":"https://patchwork.libcamera.org/patch/12132/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210429105741.59236-1-umang.jain@ideasonboard.com>","date":"2021-04-29T10:57:41","name":"[libcamera-devel] android: camera_stream: Rectify internal header's #include path","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"2fed14539dc2b2ee038986920c5f4463f0a35e5b","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/1.1/people/86/?format=json","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/12132/mbox/","series":[{"id":1985,"url":"https://patchwork.libcamera.org/api/1.1/series/1985/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1985","date":"2021-04-29T10:57:41","name":"[libcamera-devel] android: camera_stream: Rectify internal header's #include path","version":1,"mbox":"https://patchwork.libcamera.org/series/1985/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/12132/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/12132/checks/","tags":{},"headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0801CBDE44\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 29 Apr 2021 10:57:51 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4F8F468909;\n\tThu, 29 Apr 2021 12:57:50 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1651B60511\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 29 Apr 2021 12:57:49 +0200 (CEST)","from perceval.ideasonboard.com (unknown [103.238.109.25])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6CD56BC0;\n\tThu, 29 Apr 2021 12:57:47 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"QBAxcPsr\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1619693868;\n\tbh=6wW3i+2hubNubNAvNSJL2smZ5+qXrISquXegWdjeXfs=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=QBAxcPsrdZRU3/gyzKZ72d1uN6vwN6fRPI3U9QHjdLl6s/pjRnpEWXrinm/kYPC2g\n\tXi1FMIc3ZspypNecOZ2pF9rWFOXFZqU+5a4h1nHfXoPFBTTLMUvPwO+K0j0l4h9/6B\n\tAZDb9Ot+fj5kZ0W1ZmBvVF3FEBFDt1zXD2GTY5+s=","From":"Umang Jain <umang.jain@ideasonboard.com>","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 29 Apr 2021 16:27:41 +0530","Message-Id":"<20210429105741.59236-1-umang.jain@ideasonboard.com>","X-Mailer":"git-send-email 2.26.2","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH] android: camera_stream: Rectify internal\n\theader's #include path","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"libcamera internal headers are not installed system-wide. Hence, any\ninclusion of internal headers should be follow the #include directive\nform:\n\t#include \"libcamera/internal/header.h\"\n\nThis was not the case with buffer.h internal header. Fix it.\n\nSigned-off-by: Umang Jain <umang.jain@ideasonboard.com>\n---\n src/android/camera_stream.h | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/android/camera_stream.h b/src/android/camera_stream.h\nindex f68fdd3a..34016722 100644\n--- a/src/android/camera_stream.h\n+++ b/src/android/camera_stream.h\n@@ -19,7 +19,7 @@\n #include <libcamera/geometry.h>\n #include <libcamera/pixel_format.h>\n \n-#include <libcamera/internal/buffer.h>\n+#include \"libcamera/internal/buffer.h\"\n \n class CameraDevice;\n class CameraMetadata;\n","prefixes":["libcamera-devel"]}