{"id":12130,"url":"https://patchwork.libcamera.org/api/1.1/patches/12130/?format=json","web_url":"https://patchwork.libcamera.org/patch/12130/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210428073617.373422-8-hiroh@chromium.org>","date":"2021-04-28T07:36:17","name":"[libcamera-devel,v3,7/7] android: CameraDevice: Report queried test pattern modes","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"4745e9547f5557c4b647c8f7512bf8f8ffb60361","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/1.1/people/63/?format=json","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/12130/mbox/","series":[{"id":1983,"url":"https://patchwork.libcamera.org/api/1.1/series/1983/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1983","date":"2021-04-28T07:36:10","name":"Report Android HAL client test pattern modes","version":3,"mbox":"https://patchwork.libcamera.org/series/1983/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/12130/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/12130/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 86AEDBDE44\n\tfor ;\n\tWed, 28 Apr 2021 07:36:39 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 37232688BC;\n\tWed, 28 Apr 2021 09:36:39 +0200 (CEST)","from mail-pj1-x102e.google.com (mail-pj1-x102e.google.com\n\t[IPv6:2607:f8b0:4864:20::102e])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4A6A6688C2\n\tfor ;\n\tWed, 28 Apr 2021 09:36:35 +0200 (CEST)","by mail-pj1-x102e.google.com with SMTP id\n\tm6-20020a17090a8586b02901507e1acf0fso8645328pjn.3\n\tfor ;\n\tWed, 28 Apr 2021 00:36:35 -0700 (PDT)","from hiroh2.tok.corp.google.com\n\t([2401:fa00:8f:2:489:a5f4:117:7d51])\n\tby smtp.gmail.com with ESMTPSA id\n\tm11sm1661265pgs.4.2021.04.28.00.36.32\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 28 Apr 2021 00:36:33 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"GXREcBDy\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=dgY0VyAh1UvCaMt1h0/NXnw6PtEa0f4TRDwpJyByJrU=;\n\tb=GXREcBDyNXfAwBylv0uHJJJPCzV/zTFUAEfgsfsE2mCdokBqw1WjEbrqBd5XYJACsJ\n\t2953nR4s71o1feIiVcykgsSmlxGVY4SRWkPNmXHzoiQRAdh5LzjpL60Ruo70fTexsbto\n\tFYf4Mp36lR7B4rxuL1XS9b5pP6KnMZCXodqP8=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=dgY0VyAh1UvCaMt1h0/NXnw6PtEa0f4TRDwpJyByJrU=;\n\tb=hMoFvhG1pGGuXomtxEKA1fX1vW3tO2x9reO3Iu3YHJPjVt1j30RIUBT8e1WZElqvdv\n\tQS9ghlKG8HmAbh6iYABYLMkM30/0TYQs4ARZU1YszfvLW7DE0D55S3yYB+ouZpY3mFpm\n\t0SJ0DZf668Tn6A3+a0vP07TY0xCGvtTK/f5wJjCXhqxKhhreZbH9m7MhidbyYHbdAexG\n\t71zl3Or2k7mT+hC25RbDM8Ujg+hetsznKKT5Jb+aSLj4gUUjkMMl84+uaIfpqqQ8f67l\n\tYhi50A8uZ/0NPG47ctxdRhtysYF0YreUdSYxfV6jmpClq1hsuPEa4EkXhE0SHpbCpfAf\n\tmDAg==","X-Gm-Message-State":"AOAM530zn330bvQWKtoFzbf3QeCkw0BWGBNKSvnj1ZvNYQ8W3Xzx1puw\n\tKWWH7RSR3zCuffJDdHnJq9OUhmxXXzSl7w==","X-Google-Smtp-Source":"ABdhPJw6r/Men/h/it0SG8CIbqCTCMQjFA+zgCnXjBGGMSMxOxqoAukK1MDCL5V53RbvOFCqNMU6Hw==","X-Received":"by 2002:a17:902:b582:b029:ed:562a:6f52 with SMTP id\n\ta2-20020a170902b582b02900ed562a6f52mr8680320pls.73.1619595393633; \n\tWed, 28 Apr 2021 00:36:33 -0700 (PDT)","From":"Hirokazu Honda ","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 28 Apr 2021 16:36:17 +0900","Message-Id":"<20210428073617.373422-8-hiroh@chromium.org>","X-Mailer":"git-send-email 2.31.1.498.g6c1eba8ee3d-goog","In-Reply-To":"<20210428073617.373422-1-hiroh@chromium.org>","References":"<20210428073617.373422-1-hiroh@chromium.org>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v3 7/7] android: CameraDevice: Report\n\tqueried test pattern modes","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Report test pattern modes obtained by Camera::controls().\n\nSigned-off-by: Hirokazu Honda \n---\n src/android/camera_device.cpp | 46 ++++++++++++++++++++++++++++++++---\n 1 file changed, 42 insertions(+), 4 deletions(-)","diff":"diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex 3d5b5f24..a96bc09b 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -1090,12 +1090,50 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n \n \tstaticMetadata_->addEntry(ANDROID_SENSOR_ORIENTATION, &orientation_, 1);\n \n-\tstd::vector testPatterModes = {\n-\t\tANDROID_SENSOR_TEST_PATTERN_MODE_OFF,\n+\tconst auto &testPatternsInfo =\n+\t\tcontrolsInfo.find(&controls::draft::TestPatternMode);\n+\tstd::vector testPatternModes = {\n+\t\tANDROID_SENSOR_TEST_PATTERN_MODE_OFF\n \t};\n+\tif (testPatternsInfo != controlsInfo.end()) {\n+\t\tconst auto &values = testPatternsInfo->second.values();\n+\t\tif (!values.empty()) {\n+\t\t\ttestPatternModes.clear();\n+\t\t\tfor (const auto &value : values) {\n+\t\t\t\tint aValue = -1;\n+\t\t\t\tswitch (value.get()) {\n+\t\t\t\tcase controls::draft::TestPatternModeOff:\n+\t\t\t\t\taValue = ANDROID_SENSOR_TEST_PATTERN_MODE_OFF;\n+\t\t\t\t\tbreak;\n+\t\t\t\tcase controls::draft::TestPatternModeSolidColor:\n+\t\t\t\t\taValue = ANDROID_SENSOR_TEST_PATTERN_MODE_SOLID_COLOR;\n+\t\t\t\t\tbreak;\n+\t\t\t\tcase controls::draft::TestPatternModeColorBars:\n+\t\t\t\t\taValue = ANDROID_SENSOR_TEST_PATTERN_MODE_COLOR_BARS;\n+\t\t\t\t\tbreak;\n+\t\t\t\tcase controls::draft::TestPatternModeColorBarsFadeToGray:\n+\t\t\t\t\taValue = ANDROID_SENSOR_TEST_PATTERN_MODE_COLOR_BARS_FADE_TO_GRAY;\n+\t\t\t\t\tbreak;\n+\t\t\t\tcase controls::draft::TestPatternModePn9:\n+\t\t\t\t\taValue = ANDROID_SENSOR_TEST_PATTERN_MODE_PN9;\n+\t\t\t\t\tbreak;\n+\t\t\t\tcase controls::draft::TestPatternModeCustom1:\n+\t\t\t\t\taValue = ANDROID_SENSOR_TEST_PATTERN_MODE_CUSTOM1;\n+\t\t\t\t\tbreak;\n+\t\t\t\tdefault:\n+\t\t\t\t\tLOG(HAL, Error)\n+\t\t\t\t\t\t<< \"Unknown test pattern mode: \"\n+\t\t\t\t\t\t<< value.get();\n+\t\t\t\t\tcontinue;\n+\t\t\t\t}\n+\n+\t\t\t\ttestPatternModes.push_back(aValue);\n+\t\t\t}\n+\t\t}\n+\t}\n \tstaticMetadata_->addEntry(ANDROID_SENSOR_AVAILABLE_TEST_PATTERN_MODES,\n-\t\t\t\t testPatterModes.data(),\n-\t\t\t\t testPatterModes.size());\n+\t\t\t\t testPatternModes.data(),\n+\t\t\t\t testPatternModes.size());\n \n \tuint8_t timestampSource = ANDROID_SENSOR_INFO_TIMESTAMP_SOURCE_UNKNOWN;\n \tstaticMetadata_->addEntry(ANDROID_SENSOR_INFO_TIMESTAMP_SOURCE,\n","prefixes":["libcamera-devel","v3","7/7"]}