{"id":12058,"url":"https://patchwork.libcamera.org/api/1.1/patches/12058/?format=json","web_url":"https://patchwork.libcamera.org/patch/12058/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210422021809.520675-5-hiroh@chromium.org>","date":"2021-04-22T02:18:09","name":"[libcamera-devel,v4,4/4] libcamera: V4L2Device: Use Span in updateControls()","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"de00e6df610b089ec83fd06b75a28d3621b72e11","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/1.1/people/63/?format=json","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/12058/mbox/","series":[{"id":1959,"url":"https://patchwork.libcamera.org/api/1.1/series/1959/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1959","date":"2021-04-22T02:18:05","name":"Clean up V4L2Device code","version":4,"mbox":"https://patchwork.libcamera.org/series/1959/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/12058/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/12058/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 15480BDB15\n\tfor ;\n\tThu, 22 Apr 2021 02:18:25 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CAB7F68853;\n\tThu, 22 Apr 2021 04:18:24 +0200 (CEST)","from mail-pj1-x1035.google.com (mail-pj1-x1035.google.com\n\t[IPv6:2607:f8b0:4864:20::1035])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 393606885A\n\tfor ;\n\tThu, 22 Apr 2021 04:18:22 +0200 (CEST)","by mail-pj1-x1035.google.com with SMTP id lt13so11630440pjb.1\n\tfor ;\n\tWed, 21 Apr 2021 19:18:22 -0700 (PDT)","from hiroh2.tok.corp.google.com\n\t([2401:fa00:8f:2:f88:d5a0:ebc4:5b76])\n\tby smtp.gmail.com with ESMTPSA id\n\tlt11sm3352480pjb.23.2021.04.21.19.18.19\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 21 Apr 2021 19:18:20 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"GZ8r/yxS\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=AvjxFuGHWuGy6en7PavGeDRuj1BiQI7LI6KxMvnz+GE=;\n\tb=GZ8r/yxStbs3y39HPFR+osHgaOoomiMGjphMPcwX3lchapG8cgI5OsXcILB8SrKTAc\n\tRg+DrmdtHFCILTUyzHMg+0BqnIqwQKEIx/EaZsi3UcvM98kAJLPI2jZgtArJge/m3AOv\n\tkb5EvVCCg4KCp+ozWAgEj4u/JrGJnaatW1L1E=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=AvjxFuGHWuGy6en7PavGeDRuj1BiQI7LI6KxMvnz+GE=;\n\tb=bLnZqHzHFBvS1Se99a4SJOKlHI+5dduCJSGJP7Liuon+eUrHvZUDVUwnAQDtQPpeOd\n\ta2iNcDv3nry3uvCs7woPT/jdl5Xsx4wPlNEQ4N/Ou6DG4QfffT9VM66cMS25REyTHsXX\n\tANaWgBpuLCPGc6vG5c1f4Q+7ejlbPP3EMLUDUhocMW5VVIXjrJhdPjam+gl4cf0lhmsw\n\tvHkIHP1adN4FOY02PmFsYHhD8k/glP1A2L/+Cc1LiHJCKCYEbydgjVFiKda5CrvjGPGH\n\toKXipZ2b54q0ald5RTNRv7N5pyCOeT1KUXoqlmMQxx4Lk+4P18fbt3GxpW61yLAtibut\n\t/4DQ==","X-Gm-Message-State":"AOAM530D8IrZ3YDsLX7Ocs/jiVsQ9lf+cKKjG1C8r2elefKFbGjpen7k\n\tkizX9Xtu4OnZjrAQ4acWz4WwJG5rM0HxJA==","X-Google-Smtp-Source":"ABdhPJyzbKnfwAU8Yp5ha2MWKsC1dNMYtzTryTsRZVfqaheq45+ZM+77WIeWZRGasNBhJ96kXNz0Sg==","X-Received":"by 2002:a17:90b:4a05:: with SMTP id\n\tkk5mr1324649pjb.202.1619057900672; \n\tWed, 21 Apr 2021 19:18:20 -0700 (PDT)","From":"Hirokazu Honda ","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 22 Apr 2021 11:18:09 +0900","Message-Id":"<20210422021809.520675-5-hiroh@chromium.org>","X-Mailer":"git-send-email 2.31.1.368.gbe11c130af-goog","In-Reply-To":"<20210422021809.520675-1-hiroh@chromium.org>","References":"<20210422021809.520675-1-hiroh@chromium.org>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v4 4/4] libcamera: V4L2Device: Use Span in\n\tupdateControls()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"V4L2Device::updateControls() takes two arguments, raw array and\nits size, for the v4l2_ext_control values. This replaces it with\nlibcamera::Span.\n\nSigned-off-by: Hirokazu Honda \nReviewed-by: Laurent Pinchart \nReviewed-by: Kieran Bingham \n---\n include/libcamera/internal/v4l2_device.h | 4 ++--\n src/libcamera/v4l2_device.cpp | 11 ++++-------\n 2 files changed, 6 insertions(+), 9 deletions(-)","diff":"diff --git a/include/libcamera/internal/v4l2_device.h b/include/libcamera/internal/v4l2_device.h\nindex d006bf68..087f07e7 100644\n--- a/include/libcamera/internal/v4l2_device.h\n+++ b/include/libcamera/internal/v4l2_device.h\n@@ -14,6 +14,7 @@\n #include \n \n #include \n+#include \n \n #include \"libcamera/internal/log.h\"\n #include \"libcamera/internal/v4l2_controls.h\"\n@@ -55,8 +56,7 @@ protected:\n private:\n \tvoid listControls();\n \tvoid updateControls(ControlList *ctrls,\n-\t\t\t const struct v4l2_ext_control *v4l2Ctrls,\n-\t\t\t unsigned int count);\n+\t\t\t Span v4l2Ctrls);\n \n \tvoid eventAvailable(EventNotifier *notifier);\n \ndiff --git a/src/libcamera/v4l2_device.cpp b/src/libcamera/v4l2_device.cpp\nindex 9f71bf0e..58516609 100644\n--- a/src/libcamera/v4l2_device.cpp\n+++ b/src/libcamera/v4l2_device.cpp\n@@ -244,7 +244,7 @@ ControlList V4L2Device::getControls(const std::vector &ids)\n \t\tv4l2Ctrls.resize(errorIdx);\n \t}\n \n-\tupdateControls(&ctrls, v4l2Ctrls.data(), v4l2Ctrls.size());\n+\tupdateControls(&ctrls, v4l2Ctrls);\n \n \treturn ctrls;\n }\n@@ -343,7 +343,7 @@ int V4L2Device::setControls(ControlList *ctrls)\n \t\tret = errorIdx;\n \t}\n \n-\tupdateControls(ctrls, v4l2Ctrls.data(), v4l2Ctrls.size());\n+\tupdateControls(ctrls, v4l2Ctrls);\n \n \treturn ret;\n }\n@@ -507,14 +507,11 @@ void V4L2Device::listControls()\n * values in \\a v4l2Ctrls\n * \\param[inout] ctrls List of V4L2 controls to update\n * \\param[in] v4l2Ctrls List of V4L2 extended controls as returned by the driver\n- * \\param[in] count The number of controls to update\n */\n void V4L2Device::updateControls(ControlList *ctrls,\n-\t\t\t\tconst struct v4l2_ext_control *v4l2Ctrls,\n-\t\t\t\tunsigned int count)\n+\t\t\t\tSpan v4l2Ctrls)\n {\n-\tfor (unsigned int i = 0; i < count; i++) {\n-\t\tconst struct v4l2_ext_control &v4l2Ctrl = v4l2Ctrls[i];\n+\tfor (const v4l2_ext_control &v4l2Ctrl : v4l2Ctrls) {\n \t\tconst unsigned int id = v4l2Ctrl.id;\n \t\tif (!ctrls->contains(id)) {\n \t\t\tLOG(V4L2, Error) << \"ControlList doesn't contain id: \"\n","prefixes":["libcamera-devel","v4","4/4"]}