{"id":1202,"url":"https://patchwork.libcamera.org/api/1.1/patches/1202/?format=json","web_url":"https://patchwork.libcamera.org/patch/1202/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190511111115.16727-6-niklas.soderlund@ragnatech.se>","date":"2019-05-11T11:11:15","name":"[libcamera-devel,v2,5/5] test: v4l2_device: Switch most tests to vimc","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"7b61f577c44d4b9fa12013f808cf04ce8b746dfa","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/1.1/people/5/?format=json","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/1202/mbox/","series":[{"id":304,"url":"https://patchwork.libcamera.org/api/1.1/series/304/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=304","date":"2019-05-11T11:11:10","name":"test: v4l2_device: Cleanups and a small speed increase","version":2,"mbox":"https://patchwork.libcamera.org/series/304/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/1202/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/1202/checks/","tags":{},"headers":{"Return-Path":"","Received":["from bin-mail-out-05.binero.net (bin-mail-out-05.binero.net\n\t[195.74.38.228])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 24EEB60E4F\n\tfor ;\n\tSat, 11 May 2019 13:11:50 +0200 (CEST)","from localhost.localdomain (unknown [185.224.57.161])\n\tby bin-vsp-out-03.atm.binero.net (Halon) with ESMTPA\n\tid 8aabff3c-73dd-11e9-81fd-0050569116f7;\n\tSat, 11 May 2019 13:11:36 +0200 (CEST)"],"X-Halon-ID":"8aabff3c-73dd-11e9-81fd-0050569116f7","Authorized-sender":"niklas@soderlund.pp.se","From":"=?utf-8?q?Niklas_S=C3=B6derlund?= ","To":"libcamera-devel@lists.libcamera.org","Date":"Sat, 11 May 2019 13:11:15 +0200","Message-Id":"<20190511111115.16727-6-niklas.soderlund@ragnatech.se>","X-Mailer":"git-send-email 2.21.0","In-Reply-To":"<20190511111115.16727-1-niklas.soderlund@ragnatech.se>","References":"<20190511111115.16727-1-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 5/5] test: v4l2_device: Switch most\n\ttests to vimc","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sat, 11 May 2019 11:11:50 -0000"},"content":"The vimc driver delivers frames much faster then the vivid driver hence\nmost v4l2 device tests complete much quicker if vimc is used. The only\nv4l2 device test which can't be switched is buffer_sharing as it needs\nto import buffers somewhere, something vimc do not support.\n\nWith this change I manage to shave of almost 7 seconds for each run of\nall v4l2 device tests.\n\nSigned-off-by: Niklas Söderlund \n---\n test/v4l2_device/capture_async.cpp | 2 +-\n test/v4l2_device/double_open.cpp | 2 +-\n test/v4l2_device/formats.cpp | 2 +-\n test/v4l2_device/request_buffers.cpp | 2 +-\n test/v4l2_device/stream_on_off.cpp | 2 +-\n 5 files changed, 5 insertions(+), 5 deletions(-)","diff":"diff --git a/test/v4l2_device/capture_async.cpp b/test/v4l2_device/capture_async.cpp\nindex fd428ff909f32999..69b1d5a13ed8675a 100644\n--- a/test/v4l2_device/capture_async.cpp\n+++ b/test/v4l2_device/capture_async.cpp\n@@ -18,7 +18,7 @@ class CaptureAsyncTest : public V4L2DeviceTest\n {\n public:\n \tCaptureAsyncTest()\n-\t\t: V4L2DeviceTest(\"vivid\", \"vivid-000-vid-cap\"), frames(0) {}\n+\t\t: V4L2DeviceTest(\"vimc\", \"Raw Capture 0\"), frames(0) {}\n \n \tvoid receiveBuffer(Buffer *buffer)\n \t{\ndiff --git a/test/v4l2_device/double_open.cpp b/test/v4l2_device/double_open.cpp\nindex b402de04fca5ddbb..53850620889b0972 100644\n--- a/test/v4l2_device/double_open.cpp\n+++ b/test/v4l2_device/double_open.cpp\n@@ -15,7 +15,7 @@ class DoubleOpen : public V4L2DeviceTest\n {\n public:\n \tDoubleOpen()\n-\t\t: V4L2DeviceTest(\"vivid\", \"vivid-000-vid-cap\") {}\n+\t\t: V4L2DeviceTest(\"vimc\", \"Raw Capture 0\") {}\n protected:\n \tint run()\n \t{\ndiff --git a/test/v4l2_device/formats.cpp b/test/v4l2_device/formats.cpp\nindex 3ac47f5cc665b62b..6be045ff754c4258 100644\n--- a/test/v4l2_device/formats.cpp\n+++ b/test/v4l2_device/formats.cpp\n@@ -19,7 +19,7 @@ class Format : public V4L2DeviceTest\n {\n public:\n \tFormat()\n-\t\t: V4L2DeviceTest(\"vivid\", \"vivid-000-vid-cap\") {}\n+\t\t: V4L2DeviceTest(\"vimc\", \"Raw Capture 0\") {}\n protected:\n \tint run()\n \t{\ndiff --git a/test/v4l2_device/request_buffers.cpp b/test/v4l2_device/request_buffers.cpp\nindex 794b083eb84d8d2e..7b7b06b2b409bd23 100644\n--- a/test/v4l2_device/request_buffers.cpp\n+++ b/test/v4l2_device/request_buffers.cpp\n@@ -11,7 +11,7 @@ class RequestBuffersTest : public V4L2DeviceTest\n {\n public:\n \tRequestBuffersTest()\n-\t\t: V4L2DeviceTest(\"vivid\", \"vivid-000-vid-cap\") {}\n+\t\t: V4L2DeviceTest(\"vimc\", \"Raw Capture 0\") {}\n \n protected:\n \tint run()\ndiff --git a/test/v4l2_device/stream_on_off.cpp b/test/v4l2_device/stream_on_off.cpp\nindex 4902d5fd6d58a73d..b158b8e402c83156 100644\n--- a/test/v4l2_device/stream_on_off.cpp\n+++ b/test/v4l2_device/stream_on_off.cpp\n@@ -11,7 +11,7 @@ class StreamOnStreamOffTest : public V4L2DeviceTest\n {\n public:\n \tStreamOnStreamOffTest()\n-\t\t: V4L2DeviceTest(\"vivid\", \"vivid-000-vid-cap\") {}\n+\t\t: V4L2DeviceTest(\"vimc\", \"Raw Capture 0\") {}\n protected:\n \tint run()\n \t{\n","prefixes":["libcamera-devel","v2","5/5"]}