{"id":11998,"url":"https://patchwork.libcamera.org/api/1.1/patches/11998/?format=json","web_url":"https://patchwork.libcamera.org/patch/11998/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210419131715.256802-3-naush@raspberrypi.com>","date":"2021-04-19T13:17:13","name":"[libcamera-devel,v4,2/4] ipa: raspberrypi: Add move/copy ctors and operators to Metadata class","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"a809860e1cca3a702145f281e8db1271eede49a5","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/1.1/people/34/?format=json","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/11998/mbox/","series":[{"id":1949,"url":"https://patchwork.libcamera.org/api/1.1/series/1949/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1949","date":"2021-04-19T13:17:11","name":"ipa: raspberrypi: Rate-limit the controller algorithms","version":4,"mbox":"https://patchwork.libcamera.org/series/1949/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/11998/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/11998/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 28442BD812\n\tfor ;\n\tMon, 19 Apr 2021 13:17:31 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D8FDA6883A;\n\tMon, 19 Apr 2021 15:17:30 +0200 (CEST)","from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com\n\t[IPv6:2a00:1450:4864:20::32f])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 64E7A68832\n\tfor ;\n\tMon, 19 Apr 2021 15:17:28 +0200 (CEST)","by mail-wm1-x32f.google.com with SMTP id\n\tu5-20020a7bcb050000b029010e9316b9d5so18036300wmj.2\n\tfor ;\n\tMon, 19 Apr 2021 06:17:28 -0700 (PDT)","from naush-laptop.pitowers.org\n\t([2a00:1098:3142:15:5363:8f56:4f84:754])\n\tby smtp.gmail.com with ESMTPSA id\n\tt6sm22335428wrx.38.2021.04.19.06.17.27\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 19 Apr 2021 06:17:27 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"pXhytwhM\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=uule6aP/GbUVKt6rRXc2oaEhZT9hc7570Iq0GDDxCU0=;\n\tb=pXhytwhMwyQIX3nWdamPkvoIqD0AbWoGpvXKKLSV/DxJwpA1dRlxMw5MrTIBibxC00\n\t/s+IFEvSnKJLrAaL8epKrRr17kA7DovWiiUWj+6YpCKFUcT2B9fuiBX0u3H5ctX9C7vI\n\tGzLQjjD5IDeeFSWmzNYgh8tYpL7wOnTFznuXw50TKN5KZveAXFJyJ3AlvKYFvxYiqWFQ\n\trNuZcWpZjjx2Zp32DfPehfrhQ39xjaV+19wVx/8AzcUqCuvgT2n9hKMRdotJYLp3PbwJ\n\teh59dxyjm5qh+uWQoBrAfXfp0NjYJAEj/L0ikdJqiIWLpERVsKbQ7EZkQ+MLjEgpK8OB\n\tnG1g==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=uule6aP/GbUVKt6rRXc2oaEhZT9hc7570Iq0GDDxCU0=;\n\tb=IEF+bo5ogvTlRw9YV+07H3ky1Btp4+swsNV+kLCI5KJdm4b8nUuxRgBdILD5gkK9Cq\n\tMNMJ/+xDQ3OI6/AMcEndX/l0cErhFkFGAlnX9TWj2A9Z7IMuqJFJDKswMUnOrqG2E1J0\n\tcKrbxmLc0/8B/tepSlwYyIxIzFaKKDKS1OcaMOZAMBtQrYDiZm2Zknuu7OS10EIloYGW\n\tjBiNIFk/9/tRNYiWKCeQTtny0GxRf4YGtta90GGC66edYRpd5LDw/7fvDgOoEN1ML5tK\n\tnsmH2FSMuxI5QNaYJAwqDKh1uw8C/FFnofvLWeK2dP4sAZ3E1OJfA0W7VnoErGmTSrg5\n\t5TEg==","X-Gm-Message-State":"AOAM531NQn0lm7OIyQWPpn1PqCiFU0hQ4gyAjtu/IN6lHpxO8HH0/bhv\n\toFSKlmiz2a4iK6C10kENS7rVaqsTV5OK0g==","X-Google-Smtp-Source":"ABdhPJw4Htvh4BmJIiVVLDFnHD1FqJY+0W3OTKM4HQ6JfyjoT7eSFMavDxokI8x0LXa+FCrRsulAcg==","X-Received":"by 2002:a1c:770a:: with SMTP id\n\tt10mr21872473wmi.49.1618838247855; \n\tMon, 19 Apr 2021 06:17:27 -0700 (PDT)","From":"Naushir Patuck ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 19 Apr 2021 14:17:13 +0100","Message-Id":"<20210419131715.256802-3-naush@raspberrypi.com>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20210419131715.256802-1-naush@raspberrypi.com>","References":"<20210419131715.256802-1-naush@raspberrypi.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v4 2/4] ipa: raspberrypi: Add move/copy\n\tctors and operators to Metadata class","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Add a default, move and copy constructor as well as a move operator\nimplementation RPiController::Metadata class.\n\nSigned-off-by: Naushir Patuck \nReviewed-by: David Plowman \n---\n src/ipa/raspberrypi/controller/metadata.hpp | 24 +++++++++++++++++++++\n 1 file changed, 24 insertions(+)","diff":"diff --git a/src/ipa/raspberrypi/controller/metadata.hpp b/src/ipa/raspberrypi/controller/metadata.hpp\nindex 07dd28ed9e0a..319f2320fc70 100644\n--- a/src/ipa/raspberrypi/controller/metadata.hpp\n+++ b/src/ipa/raspberrypi/controller/metadata.hpp\n@@ -19,6 +19,21 @@ namespace RPiController {\n class Metadata\n {\n public:\n+\tMetadata() = default;\n+\n+\tMetadata(Metadata const &other)\n+\t{\n+\t\tstd::lock_guard other_lock(other.mutex_);\n+\t\tdata_ = other.data_;\n+\t}\n+\n+\tMetadata(Metadata &&other)\n+\t{\n+\t\tstd::lock_guard other_lock(other.mutex_);\n+\t\tdata_ = std::move(other.data_);\n+\t\tother.data_.clear();\n+\t}\n+\n \ttemplate\n \tvoid Set(std::string const &tag, T const &value)\n \t{\n@@ -51,6 +66,15 @@ public:\n \t\treturn *this;\n \t}\n \n+\tMetadata &operator=(Metadata &&other)\n+\t{\n+\t\tstd::lock_guard lock(mutex_);\n+\t\tstd::lock_guard other_lock(other.mutex_);\n+\t\tdata_ = std::move(other.data_);\n+\t\tother.data_.clear();\n+\t\treturn *this;\n+\t}\n+\n \ttemplate\n \tT *GetLocked(std::string const &tag)\n \t{\n","prefixes":["libcamera-devel","v4","2/4"]}