{"id":1198,"url":"https://patchwork.libcamera.org/api/1.1/patches/1198/?format=json","web_url":"https://patchwork.libcamera.org/patch/1198/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190511111115.16727-2-niklas.soderlund@ragnatech.se>","date":"2019-05-11T11:11:11","name":"[libcamera-devel,v2,1/5] test: v4l2_device: Order class sections","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"df2428cead1431e9510613eb228e9d52afad2629","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/1.1/people/5/?format=json","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/1198/mbox/","series":[{"id":304,"url":"https://patchwork.libcamera.org/api/1.1/series/304/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=304","date":"2019-05-11T11:11:10","name":"test: v4l2_device: Cleanups and a small speed increase","version":2,"mbox":"https://patchwork.libcamera.org/series/304/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/1198/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/1198/checks/","tags":{},"headers":{"Return-Path":"","Received":["from bin-mail-out-06.binero.net (bin-mail-out-06.binero.net\n\t[195.74.38.229])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5DFC260E4F\n\tfor ;\n\tSat, 11 May 2019 13:11:39 +0200 (CEST)","from localhost.localdomain (unknown [185.224.57.161])\n\tby bin-vsp-out-03.atm.binero.net (Halon) with ESMTPA\n\tid 85aa9699-73dd-11e9-81fd-0050569116f7;\n\tSat, 11 May 2019 13:11:28 +0200 (CEST)"],"X-Halon-ID":"85aa9699-73dd-11e9-81fd-0050569116f7","Authorized-sender":"niklas@soderlund.pp.se","From":"=?utf-8?q?Niklas_S=C3=B6derlund?= ","To":"libcamera-devel@lists.libcamera.org","Date":"Sat, 11 May 2019 13:11:11 +0200","Message-Id":"<20190511111115.16727-2-niklas.soderlund@ragnatech.se>","X-Mailer":"git-send-email 2.21.0","In-Reply-To":"<20190511111115.16727-1-niklas.soderlund@ragnatech.se>","References":"<20190511111115.16727-1-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 1/5] test: v4l2_device: Order class\n\tsections","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sat, 11 May 2019 11:11:40 -0000"},"content":"Order the sections of a class public, protected and private. There is no\nfunctional change only restructuring of existing code to align with the\nstyle of other tests.\n\nSigned-off-by: Niklas Söderlund \nReviewed-by: Laurent Pinchart \n---\n test/v4l2_device/buffer_sharing.cpp | 16 ++++++++--------\n 1 file changed, 8 insertions(+), 8 deletions(-)","diff":"diff --git a/test/v4l2_device/buffer_sharing.cpp b/test/v4l2_device/buffer_sharing.cpp\nindex 45b07fc4905b826e..09695239ee4b9e80 100644\n--- a/test/v4l2_device/buffer_sharing.cpp\n+++ b/test/v4l2_device/buffer_sharing.cpp\n@@ -27,14 +27,6 @@ public:\n \t{\n \t}\n \n-private:\n-\tconst unsigned int bufferCount = 4;\n-\n-\tV4L2Device *output_;\n-\n-\tunsigned int framesCaptured_;\n-\tunsigned int framesOutput_;\n-\n protected:\n \tint init()\n \t{\n@@ -182,6 +174,14 @@ protected:\n \n \t\tV4L2DeviceTest::cleanup();\n \t}\n+\n+private:\n+\tconst unsigned int bufferCount = 4;\n+\n+\tV4L2Device *output_;\n+\n+\tunsigned int framesCaptured_;\n+\tunsigned int framesOutput_;\n };\n \n TEST_REGISTER(BufferSharingTest);\n","prefixes":["libcamera-devel","v2","1/5"]}