{"id":11933,"url":"https://patchwork.libcamera.org/api/1.1/patches/11933/?format=json","web_url":"https://patchwork.libcamera.org/patch/11933/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210415030730.3333809-1-hiroh@chromium.org>","date":"2021-04-15T03:07:30","name":"[libcamera-devel] libcamera: V4L2Device: Return the requested Controls in getContrls()","commit_ref":null,"pull_url":null,"state":"rejected","archived":false,"hash":"3278253b6dde6a7a918825cca7719b8f0bbada7d","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/1.1/people/63/?format=json","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/11933/mbox/","series":[{"id":1930,"url":"https://patchwork.libcamera.org/api/1.1/series/1930/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1930","date":"2021-04-15T03:07:30","name":"[libcamera-devel] libcamera: V4L2Device: Return the requested Controls in getContrls()","version":1,"mbox":"https://patchwork.libcamera.org/series/1930/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/11933/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/11933/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E8743BD1F6\n\tfor ;\n\tThu, 15 Apr 2021 03:07:39 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2D39A68814;\n\tThu, 15 Apr 2021 05:07:39 +0200 (CEST)","from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com\n\t[IPv6:2607:f8b0:4864:20::1036])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0C732602C7\n\tfor ;\n\tThu, 15 Apr 2021 05:07:38 +0200 (CEST)","by mail-pj1-x1036.google.com with SMTP id u11so7640617pjr.0\n\tfor ;\n\tWed, 14 Apr 2021 20:07:37 -0700 (PDT)","from hiroh2.tok.corp.google.com\n\t([2401:fa00:8f:2:84f5:7981:dfbe:8f02])\n\tby smtp.gmail.com with ESMTPSA id\n\t33sm779651pgq.21.2021.04.14.20.07.34\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 14 Apr 2021 20:07:35 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"A86ud08a\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; h=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=xxHXmNvqriXhnctuLhKbwN7na7hwdG2MLtzqw0zr1D0=;\n\tb=A86ud08aGJNqqJueDTaQbkYTOv80AGj+wPPIdJqppRJBzo3rGPi0cxDIOeQc5q0nRi\n\tuH6k6H0Z2xDnyz19vLWjfcJ9/AF4oTpbQYbYBfBWAomMq4zPJNj7tYusFZ+oqcxCRYDo\n\tIUOhR3ipbLniQnD4lufg+3CmMwB7GK/nHRfvk=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=xxHXmNvqriXhnctuLhKbwN7na7hwdG2MLtzqw0zr1D0=;\n\tb=ohaefxOb/N4k6BFNEySOQTOJP46AHR3Ac8CAx1puUh0F0BLbjcsMaTeiwcTlkbU04D\n\tv+IH5BQkR/J03GJquT/YSAYnolqSg2oow7wu6E/68Gqn8livx8Zh4qGHP30Bas7nInOe\n\tH+V1UZX2MNRYY0uD6wsfe8JCGddoTPQ1GsGLIEn/wcW1jB2K9KFDsrhBa5Cx3LMbC4XO\n\t/5KQJBzjPR2MQMx7ULKz4DCTQu5VFUZ3vOMk8W2NSgsczNW+vlORC5z1R8qGCSmTfW8Y\n\tbDDYAH9bIbfOf427cYTnYvRT6SUpYMo0+vn0a5IZzWjdvd49d939ddvzD2VhDyCX0hvU\n\tdyKA==","X-Gm-Message-State":"AOAM532QqjiqOI9nlZipCH/MT4V8BdPARdHd1zFqiuuY5XqRatU14z7y\n\tNWoGJRG8bVzfxUBDEUbh+2NneimkHbuBig==","X-Google-Smtp-Source":"ABdhPJxgdIz390tNdM16BAY0zxOPkDSXNb8Rgc4Lp/LzB54ZB6xFsdvysvFn2MctZhQE35aMqVg/5g==","X-Received":"by 2002:a17:902:dacd:b029:e5:cf71:3901 with SMTP id\n\tq13-20020a170902dacdb02900e5cf713901mr1349207plx.23.1618456056402; \n\tWed, 14 Apr 2021 20:07:36 -0700 (PDT)","From":"Hirokazu Honda ","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 15 Apr 2021 12:07:30 +0900","Message-Id":"<20210415030730.3333809-1-hiroh@chromium.org>","X-Mailer":"git-send-email 2.31.1.368.gbe11c130af-goog","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH] libcamera: V4L2Device: Return the\n\trequested Controls in getContrls()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Originally V4L2Device::getControls() returns all the available\ncontrols while requested control values are acquired by\nVIDIOC_G_EXT_CTRLS. V4L2Device::getControls() should rather\nreturn the request controls only. This fixes the bug.\n\nSigned-off-by: Hirokazu Honda \n---\n src/libcamera/v4l2_device.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/v4l2_device.cpp b/src/libcamera/v4l2_device.cpp\nindex decd19ef..d4a9bb75 100644\n--- a/src/libcamera/v4l2_device.cpp\n+++ b/src/libcamera/v4l2_device.cpp\n@@ -177,7 +177,7 @@ ControlList V4L2Device::getControls(const std::vector &ids)\n \tif (count == 0)\n \t\treturn {};\n \n-\tControlList ctrls{ controls_ };\n+\tControlList ctrls;\n \n \t/*\n \t * Start by filling the ControlList. This can't be combined with filling\n","prefixes":["libcamera-devel"]}