{"id":11886,"url":"https://patchwork.libcamera.org/api/1.1/patches/11886/?format=json","web_url":"https://patchwork.libcamera.org/patch/11886/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210411164858.29961-1-sebastian.fricke@posteo.net>","date":"2021-04-11T16:48:58","name":"[libcamera-devel] pipeline: rkisp1: Add check for non-existent frame info","commit_ref":"093b71b24a361900bcb9c8a76ee7ad85943f4f5b","pull_url":null,"state":"accepted","archived":false,"hash":"6be99cf17a88c10d9f882e53d6b53fdef37fca68","submitter":{"id":78,"url":"https://patchwork.libcamera.org/api/1.1/people/78/?format=json","name":"Sebastian Fricke","email":"sebastian.fricke@posteo.net"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/11886/mbox/","series":[{"id":1909,"url":"https://patchwork.libcamera.org/api/1.1/series/1909/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1909","date":"2021-04-11T16:48:58","name":"[libcamera-devel] pipeline: rkisp1: Add check for non-existent frame info","version":1,"mbox":"https://patchwork.libcamera.org/series/1909/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/11886/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/11886/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B23ECBD224\n\tfor ;\n\tSun, 11 Apr 2021 16:49:09 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 12F63687F7;\n\tSun, 11 Apr 2021 18:49:09 +0200 (CEST)","from mout02.posteo.de (mout02.posteo.de [185.67.36.66])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 31B46687F4\n\tfor ;\n\tSun, 11 Apr 2021 18:49:08 +0200 (CEST)","from submission (posteo.de [89.146.220.130]) \n\tby mout02.posteo.de (Postfix) with ESMTPS id 32FC72400FF\n\tfor ;\n\tSun, 11 Apr 2021 18:49:07 +0200 (CEST)","from customer (localhost [127.0.0.1])\n\tby submission (posteo.de) with ESMTPSA id 4FJHrf4XV2z6tmL;\n\tSun, 11 Apr 2021 18:49:06 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=posteo.net header.i=@posteo.net\n\theader.b=\"madRvyP/\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017;\n\tt=1618159747; bh=72QWPr+ffBFMyew+vNXHGOOMesIuoscBIqQWUKcz91s=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=madRvyP/COHxoVIwTqyKY97lR/+Irn+6I8QKCL5SlabAdvxmT4h6/V6hB+2UwWYJG\n\tLanIbXiITS9YWr6NE19zS2+UIHOIjs7W9d5tVb6FmErAc9ANHwmXJapvY2/t7E1gmU\n\tbybMlkNQDBfBAX60hmHV8Uu0Y1Ete7o0OFdCqA+fWipAgMopfFzO3ZPJvykTV20alS\n\ttXZE8Xoez4qgwjDYxNH2gCh/iwEWAHP/UW5pzmkSFiNSkYmOoM6BmB8mlZ6K9bawXE\n\tcy9Os3xTZT/Cu5S8Kh+gMIN8nEBxkSxF0iLUi2+Xpo/NbRuqGH+5oBoSHwazysY+nY\n\teVCFzm8jBEOGw==","From":"Sebastian Fricke ","To":"libcamera-devel@lists.libcamera.org","Date":"Sun, 11 Apr 2021 18:48:58 +0200","Message-Id":"<20210411164858.29961-1-sebastian.fricke@posteo.net>","X-Mailer":"git-send-email 2.25.1","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH] pipeline: rkisp1: Add check for\n\tnon-existent frame info","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Add a check, that makes sure that the given FrameBuffer is associated\nto a RkISP1FrameInfo instance. The current code tries to access the\nframe info without checking if it actually exists.\n\nFixes: 0eb65e14e libcamera: pipeline: rkisp1: Attach to an IPA\n\nSigned-off-by: Sebastian Fricke \n---\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 2 ++\n 1 file changed, 2 insertions(+)","diff":"diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\nindex 03757327..eca7d608 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n@@ -1079,6 +1079,8 @@ void PipelineHandlerRkISP1::paramReady(FrameBuffer *buffer)\n \tRkISP1CameraData *data = cameraData(activeCamera_);\n \n \tRkISP1FrameInfo *info = data->frameInfo_.find(buffer);\n+\tif (!info)\n+\t\treturn;\n \n \tinfo->paramDequeued = true;\n \ttryCompleteRequest(info->request);\n","prefixes":["libcamera-devel"]}