{"id":11827,"url":"https://patchwork.libcamera.org/api/1.1/patches/11827/?format=json","web_url":"https://patchwork.libcamera.org/patch/11827/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210403131015.1590399-3-hiroh@chromium.org>","date":"2021-04-03T13:10:14","name":"[libcamera-devel,v4,3/4] android: CameraDevice: Log rotation variables in camera3_stream","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"3ebdc7b635c6c5921f173444a1d135a322bbf879","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/1.1/people/63/?format=json","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/11827/mbox/","series":[{"id":1885,"url":"https://patchwork.libcamera.org/api/1.1/series/1885/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1885","date":"2021-04-03T13:10:13","name":null,"version":4,"mbox":"https://patchwork.libcamera.org/series/1885/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/11827/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/11827/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4C76FC0DA3\n\tfor ;\n\tSat, 3 Apr 2021 13:10:28 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0B9CA68796;\n\tSat, 3 Apr 2021 15:10:28 +0200 (CEST)","from mail-pg1-x52f.google.com (mail-pg1-x52f.google.com\n\t[IPv6:2607:f8b0:4864:20::52f])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2A5CA602E6\n\tfor ;\n\tSat, 3 Apr 2021 15:10:26 +0200 (CEST)","by mail-pg1-x52f.google.com with SMTP id d10so351864pgf.12\n\tfor ;\n\tSat, 03 Apr 2021 06:10:26 -0700 (PDT)","from hiroh2.tok.corp.google.com\n\t([2401:fa00:8f:2:d1f5:1b96:f027:f646])\n\tby smtp.gmail.com with ESMTPSA id\n\th6sm11303271pfb.157.2021.04.03.06.10.22\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSat, 03 Apr 2021 06:10:23 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"RcPuCn85\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=LU/wNcYg4zQL4s3IItBj4TUxdrY1GMeo1gXZ+FUj6lY=;\n\tb=RcPuCn85wYth2s7Syu5BHSLBJTpmJ6RtIIVZNud09lqDISklJg0fB8IHxOuSjnR/Fc\n\t4aniNadtBqe9nFmtPoe5ck3C6Wz1DV7OLd1KQWfSyyXrXxk8J40O1C34mLmxrFnSfxpg\n\txr6EbL0xihz1KFFIvqhrwr1E99AG868C4G4hM=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=LU/wNcYg4zQL4s3IItBj4TUxdrY1GMeo1gXZ+FUj6lY=;\n\tb=lWt/iPBbIIwVs0ggOClB2lPuEK2K1PJd8OCowjL8K21xCeXVtJxyR62MNxLwm3stba\n\tPTeqNXrVYiH/vzDMxDrxzOEAzziMgrOY+sku9TU6k1cNZyjBHg1emk//br/sHxU95E92\n\tY0Ow1BjtOtCJW2Wdhk4e5T5IIgcXfPLrW3WzlwyBzLwx88G9vPt2XpZjV3hQKT0R51hD\n\tdgktVjr21nr4Ak7jgvw9xIj8+tNPFAxACwuFnA2eSjmOArVdW2z8T6HfoWXJ7I5nwl0O\n\tDSv1fHZxOMZ/bWjmA1UEaEpSL7ShvGGYZGp/EQ5ldBreIrX2KzLY2R12yVFpFK7xNajJ\n\trOCw==","X-Gm-Message-State":"AOAM5321Bj4H21nZtwP2rkIJZd7I/CmqmU0jcH0GDB9Hs7adTEeZ/3XC\n\tQNen2M9+5SMjqkFlODVLuPZwFOtUoZ3lAA==","X-Google-Smtp-Source":"ABdhPJwvXNBGgZ1LNDnWN5y4Wz6L44yYXzVC3OMwOBOqrzNJl1k4oPrsTXeQ+7rUEupQbHNpiLEpCA==","X-Received":"by 2002:aa7:9f08:0:b029:20c:9997:aeea with SMTP id\n\tg8-20020aa79f080000b029020c9997aeeamr16241277pfr.18.1617455424015; \n\tSat, 03 Apr 2021 06:10:24 -0700 (PDT)","From":"Hirokazu Honda ","To":"libcamera-devel@lists.libcamera.org","Date":"Sat, 3 Apr 2021 22:10:14 +0900","Message-Id":"<20210403131015.1590399-3-hiroh@chromium.org>","X-Mailer":"git-send-email 2.31.0.208.g409f899ff0-goog","In-Reply-To":"<20210403131015.1590399-1-hiroh@chromium.org>","References":"<20210403131015.1590399-1-hiroh@chromium.org>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v4 3/4] android: CameraDevice: Log\n\trotation variables in camera3_stream","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"|rotation| and |crop_rotate_scale_degrees| are important info of\na configuration. They should be logged.\n\nSigned-off-by: Hirokazu Honda \nReviewed-by: Jacopo Mondi \nReviewed-by: Laurent Pinchart \n---\n src/android/camera_device.cpp | 20 ++++++++++++++++++++\n 1 file changed, 20 insertions(+)","diff":"diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex 3f7cce8e..ddac56da 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -256,6 +256,21 @@ void sortCamera3StreamConfigs(std::vector &unsortedConfigs,\n \tunsortedConfigs = sortedConfigs;\n }\n \n+const char *rotationToString(int rotation)\n+{\n+\tswitch (rotation) {\n+\tcase CAMERA3_STREAM_ROTATION_0:\n+\t\treturn \"0\";\n+\tcase CAMERA3_STREAM_ROTATION_90:\n+\t\treturn \"90\";\n+\tcase CAMERA3_STREAM_ROTATION_180:\n+\t\treturn \"180\";\n+\tcase CAMERA3_STREAM_ROTATION_270:\n+\t\treturn \"270\";\n+\t}\n+\treturn \"INVALID\";\n+}\n+\n #if defined(OS_CHROMEOS)\n /*\n * Check whether the crop_rotate_scale_degrees values for all streams in\n@@ -1631,6 +1646,11 @@ int CameraDevice::configureStreams(camera3_stream_configuration_t *stream_list)\n \t\t\t << \", width: \" << stream->width\n \t\t\t << \", height: \" << stream->height\n \t\t\t << \", format: \" << utils::hex(stream->format)\n+\t\t\t << \", rotation: \" << rotationToString(stream->rotation)\n+#if defined(OS_CHROMEOS)\n+\t\t\t << \", crop_rotate_scale_degrees: \"\n+\t\t\t << rotationToString(stream->crop_rotate_scale_degrees)\n+#endif\n \t\t\t << \" (\" << format.toString() << \")\";\n \n \t\tif (!format.isValid())\n","prefixes":["libcamera-devel","v4","3/4"]}