{"id":11814,"url":"https://patchwork.libcamera.org/api/1.1/patches/11814/?format=json","web_url":"https://patchwork.libcamera.org/patch/11814/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210401101340.160590-9-paul.elder@ideasonboard.com>","date":"2021-04-01T10:13:40","name":"[libcamera-devel,RFC,8/8] android: camera_device: Fix exposure time range and max analog sensitivity","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"ee2b300448fd0628ca5dfb93d52ce3a2d65e3c7e","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/1.1/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"delegate":{"id":17,"url":"https://patchwork.libcamera.org/api/1.1/users/17/?format=json","username":"epaul","first_name":"Paul","last_name":"Elder","email":"paul.elder@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/patch/11814/mbox/","series":[{"id":1878,"url":"https://patchwork.libcamera.org/api/1.1/series/1878/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1878","date":"2021-04-01T10:13:32","name":"android: First set of FULL fixes","version":1,"mbox":"https://patchwork.libcamera.org/series/1878/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/11814/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/11814/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B3F91C0DA4\n\tfor ;\n\tThu, 1 Apr 2021 10:14:11 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7188C6878B;\n\tThu, 1 Apr 2021 12:14:11 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4B82F6878B\n\tfor ;\n\tThu, 1 Apr 2021 12:14:09 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CBFA1527;\n\tThu, 1 Apr 2021 12:14:07 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"aMgWFTAX\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1617272049;\n\tbh=1+uVv3LJLbdpWJaTH6+9zQtHYgRPsq3BGfz+pTlOaKs=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=aMgWFTAXP+AwHksGfWxlrxwr841wzY50HgnLPEduQA0kkQniEmRxFnwH3EeSOBJYR\n\tZ/aw5Fsx8cS1tcLghRAs6RCwknov9vt4oP/F9eqyQzenUCmZ4Aevpw+E3hnf48V2oP\n\t3KxbZobxKqAhP+URKj8kvt8dp+XZ9uM97xHgi7V4=","From":"Paul Elder ","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 1 Apr 2021 19:13:40 +0900","Message-Id":"<20210401101340.160590-9-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20210401101340.160590-1-paul.elder@ideasonboard.com>","References":"<20210401101340.160590-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [RFC PATCH 8/8] android: camera_device: Fix\n\texposure time range and max analog sensitivity","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The exposure time range minimum must be at most 100us, and the maximum\nat least 100ms. Clamp these values.\n\nThe maximum analog sensitivity is a required static metadata entry for\nhardware level FULL. Add it.\n\nThis allows the following CTS test to pass:\n- android.hardware.camera2.cts.CaptureRequestTest#testFlashControl\n\nSigned-off-by: Paul Elder \n---\n src/android/camera_device.cpp | 17 ++++++++++++++---\n 1 file changed, 14 insertions(+), 3 deletions(-)","diff":"diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex a187beff..9652b0e0 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -675,10 +675,10 @@ std::tuple CameraDevice::calculateStaticMetadataSize()\n {\n \t/*\n \t * \\todo Keep this in sync with the actual number of entries.\n-\t * Currently: 54 entries, 874 bytes of static metadata\n+\t * Currently: 55 entries, 878 bytes of static metadata\n \t */\n-\tuint32_t numEntries = 54;\n-\tuint32_t byteSize = 874;\n+\tuint32_t numEntries = 55;\n+\tuint32_t byteSize = 878;\n \n \t/*\n \t * Calculate space occupation in bytes for dynamically built metadata\n@@ -982,10 +982,20 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n \t\t\texposureInfo->second.min().get() * 1000LL,\n \t\t\texposureInfo->second.max().get() * 1000LL,\n \t\t};\n+\t\t/* min must be at most 100us, max at least 100ms */\n+\t\tif (exposureTimeRange[0] > 100000)\n+\t\t\texposureTimeRange[0] = 100000;\n+\t\tif (exposureTimeRange[1] < 100000000)\n+\t\t\texposureTimeRange[1] = 100000000;\n \t\tstaticMetadata_->addEntry(ANDROID_SENSOR_INFO_EXPOSURE_TIME_RANGE,\n \t\t\t\t\t &exposureTimeRange, 2);\n \t}\n \n+\t/* min at most 100, max at least 800 */\n+\tint32_t maxAnalogSensitivity = 800;\n+\tstaticMetadata_->addEntry(ANDROID_SENSOR_MAX_ANALOG_SENSITIVITY,\n+\t\t\t\t &maxAnalogSensitivity, 1);\n+\n \tstaticMetadata_->addEntry(ANDROID_SENSOR_ORIENTATION, &orientation_, 1);\n \n \tstd::vector testPatterModes = {\n@@ -1270,6 +1280,7 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n \t\tANDROID_SENSOR_INFO_PIXEL_ARRAY_SIZE,\n \t\tANDROID_SENSOR_INFO_SENSITIVITY_RANGE,\n \t\tANDROID_SENSOR_INFO_TIMESTAMP_SOURCE,\n+\t\tANDROID_SENSOR_MAX_ANALOG_SENSITIVITY,\n \t\tANDROID_SENSOR_ORIENTATION,\n \t\tANDROID_STATISTICS_INFO_AVAILABLE_FACE_DETECT_MODES,\n \t\tANDROID_STATISTICS_INFO_MAX_FACE_COUNT,\n","prefixes":["libcamera-devel","RFC","8/8"]}