{"id":11812,"url":"https://patchwork.libcamera.org/api/1.1/patches/11812/?format=json","web_url":"https://patchwork.libcamera.org/patch/11812/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210401101340.160590-7-paul.elder@ideasonboard.com>","date":"2021-04-01T10:13:38","name":"[libcamera-devel,RFC,6/8] android: camera_device: Add AE mode off to AE available modes","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"e5dec6aac67a671e9ccceff2d62ce07c8e9e2340","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/1.1/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"delegate":{"id":17,"url":"https://patchwork.libcamera.org/api/1.1/users/17/?format=json","username":"epaul","first_name":"Paul","last_name":"Elder","email":"paul.elder@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/patch/11812/mbox/","series":[{"id":1878,"url":"https://patchwork.libcamera.org/api/1.1/series/1878/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1878","date":"2021-04-01T10:13:32","name":"android: First set of FULL fixes","version":1,"mbox":"https://patchwork.libcamera.org/series/1878/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/11812/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/11812/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6AEE9C0DA4\n\tfor ;\n\tThu, 1 Apr 2021 10:14:07 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 227F968785;\n\tThu, 1 Apr 2021 12:14:07 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 23D0A68782\n\tfor ;\n\tThu, 1 Apr 2021 12:14:05 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 80A40F7;\n\tThu, 1 Apr 2021 12:14:03 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"bT8TDX7z\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1617272044;\n\tbh=7wpvxqxtt4w4YWjsL962OFpz2UjP/OB5emo3gR+5zCg=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=bT8TDX7zPVkzl7vYFKtloh1jHLOttcAeqcAkOTnhfcZ9WlLFaIXhA3bQpESKOcl7K\n\tZa4T3NfBh4BvoVDo1SISJ+YPEVKCQG5nCurngGrBbs6AnYUBwUFQwwYudww1FfPswq\n\tnhvrENi7Lyx5k03xjagWuhMOyH/dgxiFrW1UKH7w=","From":"Paul Elder ","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 1 Apr 2021 19:13:38 +0900","Message-Id":"<20210401101340.160590-7-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20210401101340.160590-1-paul.elder@ideasonboard.com>","References":"<20210401101340.160590-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [RFC PATCH 6/8] android: camera_device: Add AE\n\tmode off to AE available modes","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Hardware level FULL requires that AE mode off is an available AE mode.\nAdd it.\n\nThis allows the following CTS test to pass:\n- android.hardware.camera2.cts.CaptureRequestTest#testAeModeAndLock\n\nSigned-off-by: Paul Elder \n---\n src/android/camera_device.cpp | 2 ++\n 1 file changed, 2 insertions(+)","diff":"diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex fc432263..584c3c4a 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -760,7 +760,9 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n \t\t\t\t aeAvailableAntiBandingModes.data(),\n \t\t\t\t aeAvailableAntiBandingModes.size());\n \n+\t/* \\todo FULL requires OFF */\n \tstd::vector aeAvailableModes = {\n+\t\tANDROID_CONTROL_AE_MODE_OFF,\n \t\tANDROID_CONTROL_AE_MODE_ON,\n \t};\n \tstaticMetadata_->addEntry(ANDROID_CONTROL_AE_AVAILABLE_MODES,\n","prefixes":["libcamera-devel","RFC","6/8"]}