{"id":11799,"url":"https://patchwork.libcamera.org/api/1.1/patches/11799/?format=json","web_url":"https://patchwork.libcamera.org/patch/11799/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210330211210.194806-2-jeanmichel.hautbois@ideasonboard.com>","date":"2021-03-30T21:12:07","name":"[libcamera-devel,v4,1/4] ipa: Add a common interface for algorithm objects","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"78f84aec74dbeb969fd8d611200c64125c47871e","submitter":{"id":75,"url":"https://patchwork.libcamera.org/api/1.1/people/75/?format=json","name":"Jean-Michel Hautbois","email":"jeanmichel.hautbois@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/11799/mbox/","series":[{"id":1874,"url":"https://patchwork.libcamera.org/api/1.1/series/1874/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1874","date":"2021-03-30T21:12:06","name":"Implement IPA algorithms and demo with IPU3","version":4,"mbox":"https://patchwork.libcamera.org/series/1874/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/11799/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/11799/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1F6E9C0DA3\n\tfor ;\n\tTue, 30 Mar 2021 21:12:19 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D4B5068787;\n\tTue, 30 Mar 2021 23:12:18 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E482C602DB\n\tfor ;\n\tTue, 30 Mar 2021 23:12:16 +0200 (CEST)","from localhost.localdomain (unknown\n\t[IPv6:2a01:e0a:169:7140:40dc:d947:395c:88d2])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 84997102;\n\tTue, 30 Mar 2021 23:12:16 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"jffT9oej\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1617138736;\n\tbh=d5mLdW6q1A6Wc35qMoc+gDihp0/OfWEzWC2vBQzAji8=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=jffT9oeju9Q0jwVW3TuyTTIcbWyXjgQLwdFrrJiVmh7rr5hiEkEzz6NJNqWiBR8kG\n\tdaGQpGKoje8v9wgdza6rbEUiHjmjp4i6YsbfmBhcYjbUHqpS3/hYyLjS7GxNHcgI5Z\n\tHfVkL3fgaYDtMspshD9CXDVlo7lhPGydGZZp5V3U=","From":"Jean-Michel Hautbois ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 30 Mar 2021 23:12:07 +0200","Message-Id":"<20210330211210.194806-2-jeanmichel.hautbois@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20210330211210.194806-1-jeanmichel.hautbois@ideasonboard.com>","References":"<20210330211210.194806-1-jeanmichel.hautbois@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v4 1/4] ipa: Add a common interface for\n\talgorithm objects","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"In order to instanciate and use algorithms (AWB, AGC, etc.)\nthere is a need for a common class to define mandatory methods.\n\nInstead of reinventing the wheel, reuse what Raspberry Pi has done and\nadapt to the minimum requirements expected.\n\nSigned-off-by: Jean-Michel Hautbois \nReviewed-by: Laurent Pinchart \n---\n src/ipa/libipa/algorithm.cpp | 39 ++++++++++++++++++++++++++++++++++++\n src/ipa/libipa/algorithm.h | 24 ++++++++++++++++++++++\n src/ipa/libipa/meson.build | 4 +++-\n 3 files changed, 66 insertions(+), 1 deletion(-)\n create mode 100644 src/ipa/libipa/algorithm.cpp\n create mode 100644 src/ipa/libipa/algorithm.h","diff":"diff --git a/src/ipa/libipa/algorithm.cpp b/src/ipa/libipa/algorithm.cpp\nnew file mode 100644\nindex 00000000..930f9353\n--- /dev/null\n+++ b/src/ipa/libipa/algorithm.cpp\n@@ -0,0 +1,39 @@\n+/* SPDX-License-Identifier: LGPL-2.1-or-later */\n+/*\n+ * Copyright (C) 2021, Ideas On Board\n+ *\n+ * algorithm.cpp - ISP control algorithms\n+ */\n+\n+#include \"algorithm.h\"\n+\n+/**\n+ * \\file algorithm.h\n+ * \\brief Algorithm common interface\n+ */\n+\n+namespace libcamera {\n+\n+/**\n+ * \\brief The IPA namespace\n+ *\n+ * The IPA namespace groups all types specific to IPA modules. It serves as the\n+ * top-level namespace for the IPA library libipa, and also contains\n+ * module-specific namespaces for IPA modules.\n+ */\n+namespace ipa {\n+\n+/**\n+ * \\class Algorithm\n+ * \\brief The base class for all IPA algorithms\n+ *\n+ * The Algorithm class defines a standard interface for IPA algorithms. By\n+ * abstracting algorithms, it makes possible the implementation of generic code\n+ * to manage algorithms regardless of their specific type.\n+ */\n+\n+Algorithm::~Algorithm() = default;\n+\n+} /* namespace ipa */\n+\n+} /* namespace libcamera */\ndiff --git a/src/ipa/libipa/algorithm.h b/src/ipa/libipa/algorithm.h\nnew file mode 100644\nindex 00000000..89cee4c4\n--- /dev/null\n+++ b/src/ipa/libipa/algorithm.h\n@@ -0,0 +1,24 @@\n+/* SPDX-License-Identifier: LGPL-2.1-or-later */\n+/*\n+ * Copyright (C) 2021, Ideas On Board\n+ *\n+ * algorithm.h - ISP control algorithm interface\n+ */\n+#ifndef __LIBCAMERA_IPA_LIBIPA_ALGORITHM_H__\n+#define __LIBCAMERA_IPA_LIBIPA_ALGORITHM_H__\n+\n+namespace libcamera {\n+\n+namespace ipa {\n+\n+class Algorithm\n+{\n+public:\n+\tvirtual ~Algorithm();\n+};\n+\n+} /* namespace ipa */\n+\n+} /* namespace libcamera */\n+\n+#endif /* __LIBCAMERA_IPA_LIBIPA_ALGORITHM_H__ */\ndiff --git a/src/ipa/libipa/meson.build b/src/ipa/libipa/meson.build\nindex b29ef0f4..1819711d 100644\n--- a/src/ipa/libipa/meson.build\n+++ b/src/ipa/libipa/meson.build\n@@ -1,13 +1,15 @@\n # SPDX-License-Identifier: CC0-1.0\n \n libipa_headers = files([\n+ 'algorithm.h',\n ])\n \n libipa_sources = files([\n+ 'algorithm.cpp',\n ])\n \n libipa_includes = include_directories('..')\n \n-libipa = static_library('ipa', libipa_sources,\n+libipa = static_library('ipa', [libipa_sources, libipa_headers],\n include_directories : ipa_includes,\n dependencies : libcamera_dep)\n","prefixes":["libcamera-devel","v4","1/4"]}