{"id":11739,"url":"https://patchwork.libcamera.org/api/1.1/patches/11739/?format=json","web_url":"https://patchwork.libcamera.org/patch/11739/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210328075954.13182-1-sebastian.fricke@posteo.net>","date":"2021-03-28T07:59:54","name":"[libcamera-devel] ipa: raspberrrypi: Remove duplicate comment","commit_ref":"6a84c563469f11ea426e1773f8fd9b3be1172ad2","pull_url":null,"state":"accepted","archived":false,"hash":"b30e304f514e7698bfed4446e7aa832113898c72","submitter":{"id":78,"url":"https://patchwork.libcamera.org/api/1.1/people/78/?format=json","name":"Sebastian Fricke","email":"sebastian.fricke@posteo.net"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/11739/mbox/","series":[{"id":1848,"url":"https://patchwork.libcamera.org/api/1.1/series/1848/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1848","date":"2021-03-28T07:59:54","name":"[libcamera-devel] ipa: raspberrrypi: Remove duplicate comment","version":1,"mbox":"https://patchwork.libcamera.org/series/1848/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/11739/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/11739/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BA3ECC32ED\n\tfor ;\n\tSun, 28 Mar 2021 08:00:00 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E6CAA68784;\n\tSun, 28 Mar 2021 09:59:59 +0200 (CEST)","from mout02.posteo.de (mout02.posteo.de [185.67.36.66])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4757F68781\n\tfor ;\n\tSun, 28 Mar 2021 09:59:58 +0200 (CEST)","from submission (posteo.de [89.146.220.130]) \n\tby mout02.posteo.de (Postfix) with ESMTPS id 82A45240102\n\tfor ;\n\tSun, 28 Mar 2021 09:59:57 +0200 (CEST)","from customer (localhost [127.0.0.1])\n\tby submission (posteo.de) with ESMTPSA id 4F7SmX2kvrz6tmM;\n\tSun, 28 Mar 2021 09:59:56 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=posteo.net header.i=@posteo.net\n\theader.b=\"pnCDB5ig\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017;\n\tt=1616918397; bh=R86wLNQJGc8XuJCptPZeSzJ1v/V01yv2gJGIrgtoX74=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=pnCDB5ighV/jmob5NWaB6LjVyA///ziRAfZ3fHrQUMQyc3+w/wrA0KnfY+qilnitz\n\tDO+1wJa+nO1FaVvYqmfmcTzcQ6udqOzYMzS8LPRhcTR/tnTc+MSq76Np0Apux04x5s\n\tLwwIdC2Z8c9O4vfVHmQk6cxolvS9dPohjRSe3eY5pPf0ZPGOnTbZQ62rxMkdr1tRKT\n\tqQGtxYTXNdWurSlebsyrFFh9z6HzQHP4zy0BJamxRPkl+RNayT2/dbsySStx1aPrBf\n\tqytwrke4oB94IAgJrdjLQtDD07+nrR4k+1n98dbR5Hqp0l29JDy589msW2/EZHMEoB\n\tl3nDK89aok2jQ==","From":"Sebastian Fricke ","To":"libcamera-devel@lists.libcamera.org","Date":"Sun, 28 Mar 2021 09:59:54 +0200","Message-Id":"<20210328075954.13182-1-sebastian.fricke@posteo.net>","X-Mailer":"git-send-email 2.25.1","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH] ipa: raspberrrypi: Remove duplicate\n\tcomment","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The exact same comment is used two times within 5 lines.\nRemove one of them as it is redundant.\n\nSigned-off-by: Sebastian Fricke \n---\n src/ipa/raspberrypi/raspberrypi.cpp | 1 -\n 1 file changed, 1 deletion(-)","diff":"diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp\nindex 1c928b72..ed2d9a54 100644\n--- a/src/ipa/raspberrypi/raspberrypi.cpp\n+++ b/src/ipa/raspberrypi/raspberrypi.cpp\n@@ -208,7 +208,6 @@ void IPARPi::start(const ControlList &controls, ipa::RPi::StartConfig *startConf\n \tagcStatus.shutter_time = 0.0;\n \tagcStatus.analogue_gain = 0.0;\n \n-\t/* SwitchMode may supply updated exposure/gain values to use. */\n \tmetadata.Get(\"agc.status\", agcStatus);\n \tif (agcStatus.shutter_time != 0.0 && agcStatus.analogue_gain != 0.0) {\n \t\tControlList ctrls(sensorCtrls_);\n","prefixes":["libcamera-devel"]}