{"id":11721,"url":"https://patchwork.libcamera.org/api/1.1/patches/11721/?format=json","web_url":"https://patchwork.libcamera.org/patch/11721/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210325134231.1400051-13-kieran.bingham@ideasonboard.com>","date":"2021-03-25T13:42:30","name":"[libcamera-devel,v3,10/11] libcamera: pipeline: ipu3: frames: Fail if the FrameInfo can't be found","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"90b6a2c46bb7f9e321d24c4a5755565521e98c97","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/1.1/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":{"id":11,"url":"https://patchwork.libcamera.org/api/1.1/users/11/?format=json","username":"kbingham","first_name":"Kieran","last_name":"Bingham","email":"kieran.bingham@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/patch/11721/mbox/","series":[{"id":1835,"url":"https://patchwork.libcamera.org/api/1.1/series/1835/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1835","date":"2021-03-25T13:42:30","name":null,"version":3,"mbox":"https://patchwork.libcamera.org/series/1835/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/11721/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/11721/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DFE73C32E9\n\tfor ;\n\tThu, 25 Mar 2021 13:42:50 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9CA9B68D97;\n\tThu, 25 Mar 2021 14:42:50 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 519C968D7B\n\tfor ;\n\tThu, 25 Mar 2021 14:42:39 +0100 (CET)","from Q.local (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net\n\t[86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EE7D5560;\n\tThu, 25 Mar 2021 14:42:38 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"pOIYgdHj\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1616679759;\n\tbh=Zx2LcXfUZnX8WTgOgtW7xBH5lkQR0N1PFz7qAVL3mlk=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=pOIYgdHj9WskXNVoGJJlzCGP2MVKb4DH+NGZmidkx8PY+LPWerMhQQpPI9WLUwPKo\n\tEirg1zq3UTk3eZnnH7vlkq4QKTlaDjVpbgu+WmBusdg1BWnD57HS/3QzB8MCLM9fwH\n\toGVUjG7Du7VIoIgy709UaCYBX/F4MEdIxUHdYFuE=","From":"Kieran Bingham ","To":"libcamera devel ","Date":"Thu, 25 Mar 2021 13:42:30 +0000","Message-Id":"<20210325134231.1400051-13-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20210325134231.1400051-1-kieran.bingham@ideasonboard.com>","References":"<20210325134231.1400051-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v3 10/11] libcamera: pipeline: ipu3:\n\tframes: Fail if the FrameInfo can't be found","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The FrameInfo structure associates the data sent to the IPA\nand is essential for handling events.\n\nIf it can not be found, this is a fatal error which must be fixed.\n\nSigned-off-by: Kieran Bingham \n\n---\nv3:\n - Make all occurrences of failing to find a frame info fatal.\n---\n src/libcamera/pipeline/ipu3/frames.cpp | 6 ++++--\n 1 file changed, 4 insertions(+), 2 deletions(-)","diff":"diff --git a/src/libcamera/pipeline/ipu3/frames.cpp b/src/libcamera/pipeline/ipu3/frames.cpp\nindex e8eb1c5103e8..34ab4be6711b 100644\n--- a/src/libcamera/pipeline/ipu3/frames.cpp\n+++ b/src/libcamera/pipeline/ipu3/frames.cpp\n@@ -115,7 +115,8 @@ IPU3Frames::Info *IPU3Frames::find(unsigned int id)\n \tif (itInfo != frameInfo_.end())\n \t\treturn itInfo->second.get();\n \n-\tLOG(IPU3, Error) << \"Can't find tracking informaton for frame \" << id;\n+\tLOG(IPU3, Fatal) << \"Can't find tracking informaton for frame \" << id;\n+\n \treturn nullptr;\n }\n \n@@ -133,7 +134,8 @@ IPU3Frames::Info *IPU3Frames::find(FrameBuffer *buffer)\n \t\t\treturn info;\n \t}\n \n-\tLOG(IPU3, Error) << \"Can't find tracking informaton from buffer\";\n+\tLOG(IPU3, Fatal) << \"Can't find tracking informaton from buffer\";\n+\n \treturn nullptr;\n }\n \n","prefixes":["libcamera-devel","v3","10/11"]}