{"id":11612,"url":"https://patchwork.libcamera.org/api/1.1/patches/11612/?format=json","web_url":"https://patchwork.libcamera.org/patch/11612/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210317192831.359014-6-nfraprado@collabora.com>","date":"2021-03-17T19:28:31","name":"[libcamera-devel,5/5] Documentation: guides: pipeline-handler: Fix capture flag usage","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"fa72fa6960623cafc00e896f46036ad675ddfda7","submitter":{"id":84,"url":"https://patchwork.libcamera.org/api/1.1/people/84/?format=json","name":"Nícolas F. R. A. Prado","email":"nfraprado@collabora.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/11612/mbox/","series":[{"id":1800,"url":"https://patchwork.libcamera.org/api/1.1/series/1800/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1800","date":"2021-03-17T19:28:26","name":"Minor improvements to the documentation","version":1,"mbox":"https://patchwork.libcamera.org/series/1800/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/11612/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/11612/checks/","tags":{},"headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 40D2CC32E2\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 17 Mar 2021 22:53:50 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 11ACC68D6C;\n\tWed, 17 Mar 2021 23:53:49 +0100 (CET)","from bhuna.collabora.co.uk (bhuna.collabora.co.uk\n\t[IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BFA6C68D62\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 17 Mar 2021 20:29:24 +0100 (CET)","from [127.0.0.1] (localhost [127.0.0.1])\n\t(Authenticated sender: nfraprado) with ESMTPSA id 14A7F1F45371"],"From":"=?utf-8?b?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= <nfraprado@collabora.com>","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 17 Mar 2021 16:28:31 -0300","Message-Id":"<20210317192831.359014-6-nfraprado@collabora.com>","X-Mailer":"git-send-email 2.30.2","In-Reply-To":"<20210317192831.359014-1-nfraprado@collabora.com>","References":"<20210317192831.359014-1-nfraprado@collabora.com>","MIME-Version":"1.0","X-Mailman-Approved-At":"Wed, 17 Mar 2021 23:53:43 +0100","Subject":"[libcamera-devel] [PATCH 5/5] Documentation: guides:\n\tpipeline-handler: Fix capture flag usage","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Cc":"Chris Chinchilla <chris@gregariousmammal.com>,\n\tSebastian Fricke <sebastian.fricke.linux@gmail.com>","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"The number of frames passed to the -C flag of cam should come right\nafter it, without a space, otherwise the value is discarded.\nThe log below already showed the correct usage, but the command in the\ncode-block was wrong, so fix it.\n\nSigned-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>\n---\n Documentation/guides/pipeline-handler.rst | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/Documentation/guides/pipeline-handler.rst b/Documentation/guides/pipeline-handler.rst\nindex bcce86793ccd..8ef83fea9837 100644\n--- a/Documentation/guides/pipeline-handler.rst\n+++ b/Documentation/guides/pipeline-handler.rst\n@@ -1433,7 +1433,7 @@ capture through the pipeline through both of the cam and qcam utilities.\n .. code-block:: shell\n \n    ninja -C build\n-   ./build/src/cam/cam -c vivid -C 5\n+   ./build/src/cam/cam -c vivid -C5\n \n To test that the pipeline handler can detect a device, and capture input.\n \n","prefixes":["libcamera-devel","5/5"]}