{"id":11611,"url":"https://patchwork.libcamera.org/api/1.1/patches/11611/?format=json","web_url":"https://patchwork.libcamera.org/patch/11611/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210317192831.359014-5-nfraprado@collabora.com>","date":"2021-03-17T19:28:30","name":"[libcamera-devel,4/5] Documentation: guides: pipeline-handler: Update code, commands and logs","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"328c97fdbb9089ce5cbc89a8d603976808c480ea","submitter":{"id":84,"url":"https://patchwork.libcamera.org/api/1.1/people/84/?format=json","name":"Nícolas F. R. A. Prado","email":"nfraprado@collabora.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/11611/mbox/","series":[{"id":1800,"url":"https://patchwork.libcamera.org/api/1.1/series/1800/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1800","date":"2021-03-17T19:28:26","name":"Minor improvements to the documentation","version":1,"mbox":"https://patchwork.libcamera.org/series/1800/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/11611/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/11611/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E4A88BD80C\n\tfor ;\n\tWed, 17 Mar 2021 22:53:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5DFB568D51;\n\tWed, 17 Mar 2021 23:53:48 +0100 (CET)","from bhuna.collabora.co.uk (bhuna.collabora.co.uk\n\t[IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8DB7B68D61\n\tfor ;\n\tWed, 17 Mar 2021 20:29:21 +0100 (CET)","from [127.0.0.1] (localhost [127.0.0.1])\n\t(Authenticated sender: nfraprado) with ESMTPSA id D22BC1F453D8"],"From":"=?utf-8?b?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= ","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 17 Mar 2021 16:28:30 -0300","Message-Id":"<20210317192831.359014-5-nfraprado@collabora.com>","X-Mailer":"git-send-email 2.30.2","In-Reply-To":"<20210317192831.359014-1-nfraprado@collabora.com>","References":"<20210317192831.359014-1-nfraprado@collabora.com>","MIME-Version":"1.0","X-Mailman-Approved-At":"Wed, 17 Mar 2021 23:53:43 +0100","Subject":"[libcamera-devel] [PATCH 4/5] Documentation: guides:\n\tpipeline-handler: Update code, commands and logs","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Chris Chinchilla ,\n\tSebastian Fricke ","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The pipeline-handler guide is a bit outdated:\n- ControlList* in start() is now const.\n- Registered pipeline handler log now comes from Camera log and the message is different.\n\nUpdate the pipeline-handler guide to reflect these changes.\n\nSigned-off-by: Nícolas F. R. A. Prado \n---\n Documentation/guides/pipeline-handler.rst | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)","diff":"diff --git a/Documentation/guides/pipeline-handler.rst b/Documentation/guides/pipeline-handler.rst\nindex 43783ec32afa..bcce86793ccd 100644\n--- a/Documentation/guides/pipeline-handler.rst\n+++ b/Documentation/guides/pipeline-handler.rst\n@@ -209,7 +209,7 @@ methods for the overridden class members.\n int exportFrameBuffers(Camera *camera, Stream *stream,\n std::vector> *buffers) override;\n \n- int start(Camera *camera, ControlList *controls) override;\n+ int start(Camera *camera, const ControlList *controls) override;\n void stop(Camera *camera) override;\n \n int queueRequestDevice(Camera *camera, Request *request) override;\n@@ -239,7 +239,7 @@ methods for the overridden class members.\n return -1;\n }\n \n- int PipelineHandlerVivid::start(Camera *camera, ControlList *controls)\n+ int PipelineHandlerVivid::start(Camera *camera, const ControlList *controls)\n {\n return -1;\n }\n@@ -303,13 +303,13 @@ new pipeline handler by running:\n \n .. code-block:: shell\n \n- LIBCAMERA_LOG_LEVELS=Pipeline:0 ./build/src/cam/cam -l\n+ LIBCAMERA_LOG_LEVELS=Camera:0 ./build/src/cam/cam -l\n \n And you should see output like the below:\n \n .. code-block:: shell\n \n- DEBUG Pipeline pipeline_handler.cpp:680 Registered pipeline handler \"PipelineHandlerVivid\"\n+ DEBUG Camera camera_manager.cpp:148 Found registered pipeline handler 'PipelineHandlerVivid'\n \n Matching devices\n ~~~~~~~~~~~~~~~~\n","prefixes":["libcamera-devel","4/5"]}