{"id":11579,"url":"https://patchwork.libcamera.org/api/1.1/patches/11579/?format=json","web_url":"https://patchwork.libcamera.org/patch/11579/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210316062004.59692-1-email@uajain.com>","date":"2021-03-16T06:20:04","name":"[libcamera-devel] libcamera: camera_manager: Remove \\todo on hotplug/unplug of cameras","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"03650117df560329d1edd3d30bcde885a28a2322","submitter":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/people/1/?format=json","name":"Umang Jain","email":"email@uajain.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/11579/mbox/","series":[{"id":1792,"url":"https://patchwork.libcamera.org/api/1.1/series/1792/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1792","date":"2021-03-16T06:20:04","name":"[libcamera-devel] libcamera: camera_manager: Remove \\todo on hotplug/unplug of cameras","version":1,"mbox":"https://patchwork.libcamera.org/series/1792/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/11579/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/11579/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B108ABD80C\n\tfor ;\n\tTue, 16 Mar 2021 06:20:14 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 12CF368D45;\n\tTue, 16 Mar 2021 07:20:14 +0100 (CET)","from mail.uajain.com (static.126.159.217.95.clients.your-server.de\n\t[95.217.159.126])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3CA1B602DB\n\tfor ;\n\tTue, 16 Mar 2021 07:20:12 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=uajain.com header.i=@uajain.com\n\theader.b=\"ZbvYkByK\"; dkim-atps=neutral","From":"Umang Jain ","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=uajain.com; s=mail;\n\tt=1615875611; bh=+YchGEuq3KvJV9ckHHBycwxz4lMQa7ZTYjAruAbJ+zE=;\n\th=From:To:Cc:Subject;\n\tb=ZbvYkByK90SnEwgoMVNDDoBsGwzmMLgzlYkmNOtWqarF+uEZRM+j7LVInBJY8oxAY\n\t+DO8tV3FOgAjmkQImA+YSLdaqSNFG4mJkqolrMz4yHQoQLdzrky5zGVwUR0dj0Vwhs\n\t3nvB4q8s/ghJksFpL6jJio6eUAC+2lk4s906TGECxUasHeYBiECZwE3gI6AM5bKjf3\n\teeULs4t/cPoCNk8Glx6eZR1shVE4LV9P49lSYG3z+S0vgIp7jxDms8QIsBaxsGw9wf\n\tSlkBsmrmDv/hcjktnyLCoVtO/2Sm2hQYnWR5F+BhuGE6Neax8GK6dyzjAIrVU0bBLo\n\t9UKrAYlEcDkEQ==","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 16 Mar 2021 11:50:04 +0530","Message-Id":"<20210316062004.59692-1-email@uajain.com>","Mime-Version":"1.0","Subject":"[libcamera-devel] [PATCH] libcamera: camera_manager: Remove \\todo\n\ton hotplug/unplug of cameras","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Fixes: e9b47217b44c (\"libcamera: camera_manager: Introduce signals when a camera is added or removed\")\nSigned-off-by: Umang Jain \n---\n src/libcamera/camera_manager.cpp | 4 ----\n 1 file changed, 4 deletions(-)","diff":"diff --git a/src/libcamera/camera_manager.cpp b/src/libcamera/camera_manager.cpp\nindex 67641a55..8682cbcd 100644\n--- a/src/libcamera/camera_manager.cpp\n+++ b/src/libcamera/camera_manager.cpp\n@@ -251,10 +251,6 @@ void CameraManager::Private::removeCamera(Camera *camera)\n * action from the application. Once the application has released all the\n * references it held to cameras, the camera manager can be stopped with\n * stop().\n- *\n- * \\todo Add interface to register a notification callback to the user to be\n- * able to inform it new cameras have been hot-plugged or cameras have been\n- * removed due to hot-unplug.\n */\n \n CameraManager *CameraManager::self_ = nullptr;\n","prefixes":["libcamera-devel"]}