{"id":11570,"url":"https://patchwork.libcamera.org/api/1.1/patches/11570/?format=json","web_url":"https://patchwork.libcamera.org/patch/11570/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210312130304.34698-2-jeanmichel.hautbois@ideasonboard.com>","date":"2021-03-12T13:03:03","name":"[libcamera-devel,1/2] libcamera: ipu3: Move Imgu configuration to IPU3CameraData","commit_ref":null,"pull_url":null,"state":"not-applicable","archived":false,"hash":"6c9cbff1cef689346a3f2d129446dc62706520ee","submitter":{"id":75,"url":"https://patchwork.libcamera.org/api/1.1/people/75/?format=json","name":"Jean-Michel Hautbois","email":"jeanmichel.hautbois@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/11570/mbox/","series":[{"id":1787,"url":"https://patchwork.libcamera.org/api/1.1/series/1787/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1787","date":"2021-03-12T13:03:02","name":"Prepare IPU3 pipeline to pass BDS to IPA","version":1,"mbox":"https://patchwork.libcamera.org/series/1787/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/11570/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/11570/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AEEFDBD80E\n\tfor ;\n\tFri, 12 Mar 2021 13:03:11 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 608E768C6C;\n\tFri, 12 Mar 2021 14:03:11 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5852868C66\n\tfor ;\n\tFri, 12 Mar 2021 14:03:09 +0100 (CET)","from localhost.localdomain (unknown\n\t[IPv6:2a01:e0a:169:7140:ddbd:a3a3:e47b:e390])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 054A7ACB;\n\tFri, 12 Mar 2021 14:03:08 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"T8gIkgyV\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1615554189;\n\tbh=S+sw8AnNzixDGFsi29crSAPwFg2agjZAZr/P/Xy5owI=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=T8gIkgyVWf1O0ld/WDIFgcTay/oQFCbxa0SN0oiYWUCBwP8VBUOlvNL1JzQrCXRaj\n\t9sFJ5ouDdcwgydIRixhILcPodppvsjaSkCWQaM2Kzjj2HDXLKSMlX3suEAEdglcpgV\n\tSzp3I/dwwx9FfIyVGXiO+7Zrn7TTjQIdQEuDQ0Gw=","From":"Jean-Michel Hautbois ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 12 Mar 2021 14:03:03 +0100","Message-Id":"<20210312130304.34698-2-jeanmichel.hautbois@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20210312130304.34698-1-jeanmichel.hautbois@ideasonboard.com>","References":"<20210312130304.34698-1-jeanmichel.hautbois@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH 1/2] libcamera: ipu3: Move Imgu\n\tconfiguration to IPU3CameraData","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The IPU3 IPA needs to know the BayerDownScaler (BDS) configuration to\ncalculate the statistics grids.\nThis patch makes it possible for PipelineHandlerIPU3::start() to access\nthe BDS configuration and later pass the rectangle to the IPU3 IPA\nconfigure method.\n\nSigned-off-by: Jean-Michel Hautbois \n---\n src/libcamera/pipeline/ipu3/ipu3.cpp | 13 +++++++------\n 1 file changed, 7 insertions(+), 6 deletions(-)","diff":"diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\nindex 00da2bb2..0d133031 100644\n--- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n@@ -70,6 +70,8 @@ public:\n \tCIO2Device cio2_;\n \tImgUDevice *imgu_;\n \n+\tImgUDevice::PipeConfig pipeConfig_;\n+\n \tStream outStream_;\n \tStream vfStream_;\n \tStream rawStream_;\n@@ -97,7 +99,6 @@ public:\n \tStatus validate() override;\n \n \tconst StreamConfiguration &cio2Format() const { return cio2Configuration_; }\n-\tconst ImgUDevice::PipeConfig imguConfig() const { return pipeConfig_; }\n \n \t/* Cache the combinedTransform_ that will be applied to the sensor */\n \tTransform combinedTransform_;\n@@ -108,10 +109,9 @@ private:\n \t * corresponding Camera instance is valid. In order to borrow a\n \t * reference to the camera data, store a new reference to the camera.\n \t */\n-\tconst IPU3CameraData *data_;\n+\tIPU3CameraData *data_;\n \n \tStreamConfiguration cio2Configuration_;\n-\tImgUDevice::PipeConfig pipeConfig_;\n };\n \n class PipelineHandlerIPU3 : public PipelineHandler\n@@ -375,12 +375,13 @@ CameraConfiguration::Status IPU3CameraConfiguration::validate()\n \n \t/* Only compute the ImgU configuration if a YUV stream has been requested. */\n \tif (yuvCount) {\n-\t\tpipeConfig_ = data_->imgu_->calculatePipeConfig(&pipe);\n-\t\tif (pipeConfig_.isNull()) {\n+\t\tImgUDevice::PipeConfig imguConfig = data_->imgu_->calculatePipeConfig(&pipe);\n+\t\tif (imguConfig.isNull()) {\n \t\t\tLOG(IPU3, Error) << \"Failed to calculate pipe configuration: \"\n \t\t\t\t\t << \"unsupported resolutions.\";\n \t\t\treturn Invalid;\n \t\t}\n+\t\tdata_->pipeConfig_ = imguConfig;\n \t}\n \n \treturn status;\n@@ -576,7 +577,7 @@ int PipelineHandlerIPU3::configure(Camera *camera, CameraConfiguration *c)\n \t * stream has been requested: return here to skip the ImgU configuration\n \t * part.\n \t */\n-\tImgUDevice::PipeConfig imguConfig = config->imguConfig();\n+\tImgUDevice::PipeConfig imguConfig = data->pipeConfig_;\n \tif (imguConfig.isNull())\n \t\treturn 0;\n \n","prefixes":["libcamera-devel","1/2"]}