{"id":11554,"url":"https://patchwork.libcamera.org/api/1.1/patches/11554/?format=json","web_url":"https://patchwork.libcamera.org/patch/11554/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210312054727.852622-4-kieran.bingham@ideasonboard.com>","date":"2021-03-12T05:47:22","name":"[libcamera-devel,v2,3/8] libcamera: buffer: Initialise status","commit_ref":null,"pull_url":null,"state":"changes-requested","archived":false,"hash":"4f971d91285abe3e0629c990a1398adaee99da4c","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/1.1/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":{"id":11,"url":"https://patchwork.libcamera.org/api/1.1/users/11/?format=json","username":"kbingham","first_name":"Kieran","last_name":"Bingham","email":"kieran.bingham@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/patch/11554/mbox/","series":[{"id":1785,"url":"https://patchwork.libcamera.org/api/1.1/series/1785/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1785","date":"2021-03-12T05:47:19","name":"IPU3 Stability","version":2,"mbox":"https://patchwork.libcamera.org/series/1785/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/11554/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/11554/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 16CFBBD80E\n\tfor ;\n\tFri, 12 Mar 2021 05:47:37 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 18F5B68C69;\n\tFri, 12 Mar 2021 06:47:36 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A1D9B605B2\n\tfor ;\n\tFri, 12 Mar 2021 06:47:32 +0100 (CET)","from localhost.localdomain\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3DB2188F;\n\tFri, 12 Mar 2021 06:47:32 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"vs2fOZ7d\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1615528052;\n\tbh=CuVc+O8xrvItzrd5+0lVelYveOBVepDwPWjRQo0NFQs=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=vs2fOZ7dFRdyBgFVo6zxqhrw3GFXUaFkgVmcploW1bLF1Sbw5V/7P2JaxDuzAYsKM\n\tsdTa3mSkNtgQkzDS3az5tpBTaZBoUj0r3z6h5OA+iF/lBri+SDTW9i3Xcqf86YAHNS\n\tSoFiJ912yQwg+N0rpvoIzJVofnDxpp1gmNKXZNYo=","From":"Kieran Bingham ","To":"libcamera devel ","Date":"Fri, 12 Mar 2021 05:47:22 +0000","Message-Id":"<20210312054727.852622-4-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20210312054727.852622-1-kieran.bingham@ideasonboard.com>","References":"<20210312054727.852622-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v2 3/8] libcamera: buffer: Initialise\n\tstatus","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Buffers queued to a pipeline handler may not be yet queued to a device\nwhen the request is cancelled.\n\nThis can lead to the FrameMetadata having never been explicitly set by\nan underlying V4L2 device.\n\nThe status field on this is used to check the state of the buffer to\ndetermine if it was correctly filled, or if it was cancelled.\n\nIn the event that the buffer is not used, it must be marked as Error as\nthe metadata associated with that frame will not be valid.\n\nInitialise the FrameMetadata to FrameError to prevent uninitialised access.\nFurthermore, swap the Enum values of the Status such that the first\nstate represents the initial Error state.\n\nSigned-off-by: Kieran Bingham \n---\n include/libcamera/buffer.h | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/include/libcamera/buffer.h b/include/libcamera/buffer.h\nindex 302fe3d3e86b..3f5d0f1b6363 100644\n--- a/include/libcamera/buffer.h\n+++ b/include/libcamera/buffer.h\n@@ -19,8 +19,8 @@ class Request;\n \n struct FrameMetadata {\n \tenum Status {\n-\t\tFrameSuccess,\n \t\tFrameError,\n+\t\tFrameSuccess,\n \t\tFrameCancelled,\n \t};\n \n@@ -28,7 +28,7 @@ struct FrameMetadata {\n \t\tunsigned int bytesused;\n \t};\n \n-\tStatus status;\n+\tStatus status = FrameError;\n \tunsigned int sequence;\n \tuint64_t timestamp;\n \tstd::vector planes;\n","prefixes":["libcamera-devel","v2","3/8"]}