{"id":11535,"url":"https://patchwork.libcamera.org/api/1.1/patches/11535/?format=json","web_url":"https://patchwork.libcamera.org/patch/11535/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210309085235.106691-5-paul.elder@ideasonboard.com>","date":"2021-03-09T08:52:35","name":"[libcamera-devel,v2,4/4] android: jpeg: exif: change GPS method encoding from ASCII to NoEncoding","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"39c5692d422fd71d41c453a6500daa5ad0affc22","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/1.1/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/11535/mbox/","series":[{"id":1776,"url":"https://patchwork.libcamera.org/api/1.1/series/1776/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1776","date":"2021-03-09T08:52:31","name":"android: jpeg: exif: Fix GPS altitude","version":2,"mbox":"https://patchwork.libcamera.org/series/1776/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/11535/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/11535/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 28A9DBD1F1\n\tfor ;\n\tTue, 9 Mar 2021 08:52:57 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E249568A92;\n\tTue, 9 Mar 2021 09:52:56 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1852E6051F\n\tfor ;\n\tTue, 9 Mar 2021 09:52:55 +0100 (CET)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AC4B9E9;\n\tTue, 9 Mar 2021 09:52:53 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"W43/I5rB\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1615279974;\n\tbh=l1RGlMbdoKHxpVPwWd3MMI2bk7jjinegN9FwaDFYsK0=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=W43/I5rBGB1WMUqUNnt1RKe3atgn9pT9U+VQj/L1ktZ8sFmo11VDB61yZGQCUbtv9\n\tRrKLQDrVlKXHRjJyJCHGwbLN281W6UgUqco1MEdOGVHvB1/PgoZvJpiKr7Tt21f4er\n\tCxyI0ZliwMpYZTm8z2AtR3P0xYpn3c3S9+s5bSAE=","From":"Paul Elder ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 9 Mar 2021 17:52:35 +0900","Message-Id":"<20210309085235.106691-5-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20210309085235.106691-1-paul.elder@ideasonboard.com>","References":"<20210309085235.106691-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v2 4/4] android: jpeg: exif: change GPS\n\tmethod encoding from ASCII to NoEncoding","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"According to the EXIF specification, the GPS method should be UNDEFINED,\nand the first 8 bytes will designate the type. However, CTS expects the\nfirst 8 bytes to be part of the data. Remove the 8-byte encoding\ndesignator by changing the encoding to NoEncoding to appease CTS.\n\nThis is part of the fix that allows the following CTS test to pass:\n- android.hardware.cts.CameraTest#testJpegExif\n\nSigned-off-by: Paul Elder \n\n---\nChanges in v2:\n- keep UNDEFINED instead of changing it to ASCII, and use NoEncoding\n---\n src/android/jpeg/exif.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/android/jpeg/exif.cpp b/src/android/jpeg/exif.cpp\nindex 628382a9..7e47c1ac 100644\n--- a/src/android/jpeg/exif.cpp\n+++ b/src/android/jpeg/exif.cpp\n@@ -407,7 +407,7 @@ void Exif::setGPSLocation(const double *coords)\n void Exif::setGPSMethod(const std::string &method)\n {\n \tsetString(EXIF_IFD_GPS, static_cast(EXIF_TAG_GPS_PROCESSING_METHOD),\n-\t\t EXIF_FORMAT_UNDEFINED, method, Unicode);\n+\t\t EXIF_FORMAT_UNDEFINED, method, NoEncoding);\n }\n \n void Exif::setOrientation(int orientation)\n","prefixes":["libcamera-devel","v2","4/4"]}