{"id":11524,"url":"https://patchwork.libcamera.org/api/1.1/patches/11524/?format=json","web_url":"https://patchwork.libcamera.org/patch/11524/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210308223939.2088-4-david.plowman@raspberrypi.com>","date":"2021-03-08T22:39:39","name":"[libcamera-devel,v2,3/3] ipa: raspberrypi: Rename vblank field in SensorConfig to vblankDelay","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"b708dbf3f04c50a41c2c8c41087856423b5a1e8d","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/1.1/people/42/?format=json","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/11524/mbox/","series":[{"id":1772,"url":"https://patchwork.libcamera.org/api/1.1/series/1772/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1772","date":"2021-03-08T22:39:36","name":"Raspberry Pi support for new sensors","version":2,"mbox":"https://patchwork.libcamera.org/series/1772/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/11524/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/11524/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 977DDBD1F1\n\tfor ;\n\tMon, 8 Mar 2021 22:39:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CBBD668AB0;\n\tMon, 8 Mar 2021 23:39:48 +0100 (CET)","from mail-wr1-x435.google.com (mail-wr1-x435.google.com\n\t[IPv6:2a00:1450:4864:20::435])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7932A68A92\n\tfor ;\n\tMon, 8 Mar 2021 23:39:47 +0100 (CET)","by mail-wr1-x435.google.com with SMTP id b18so13145124wrn.6\n\tfor ;\n\tMon, 08 Mar 2021 14:39:47 -0800 (PST)","from pi4-davidp.lan (plowpeople3.plus.com. [80.229.223.72])\n\tby smtp.gmail.com with ESMTPSA id\n\tf17sm19811322wru.31.2021.03.08.14.39.46\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 08 Mar 2021 14:39:46 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"TM5Mnlek\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=u+gFQSGRNNhD2P9SkZ4c6rCGJV1jyRmT9Rhqq+A1UBI=;\n\tb=TM5Mnlekpb1JpOHdDsNTv05ivgGjgbScnPtZpfofGOnk8FfByEsb4wi0fFcLjjJM6L\n\tjdCgZn0JvRGf1Stc51lypCCSMGAAR11aFgf+JZ6fChGEZd7DVedMOeFRwED2xahsYPzx\n\tAMh0Hm3pXhxMeUOQc5nZlggvC5c5/D+ERk6v3IIaxkpLZU7oG0LnzcSqZnNc3IFO1lea\n\tvDJAhcGLYOyFskpvCTEFu6O8fGXxx8NbGCv4s02J9xwiB0pTA3sbPl5siPVLDtlV84ML\n\tWgFvG1jdkxndqMkKWk3ZNaiiwRMyB2ZpcKqyNxOk5YhXpzCr13mNBkYmJR+NnjVECYs+\n\t7RjQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=u+gFQSGRNNhD2P9SkZ4c6rCGJV1jyRmT9Rhqq+A1UBI=;\n\tb=HIazzwBijjVFPa/XRNtYejmjiSFNgZDz68bXfFxJXhL4TCtBPitliTCo9uodwbSj8z\n\tgE34QtTj5D+9zHdtAPubn+ycYy+E6MbPgdRP9T/SKWnnDE6Kxpx6MJqQCk8KkbUoEsuR\n\ttq4KX97xEDppPbgUx9fu2kMg1kNxBOX7bxSxhVqiMf+jjfcN86WEvMOgngF6ebliv5XB\n\tUyY2s0sAoVXeSx02AuIxmvS9hL411RrI8/04LCKohgkZnC7fH1sMQ3FcuKH198mTv89/\n\t2T8A+ef4HKzh4ArAOtBz9NH9UWKqodDGgsFZdkf7wka3UuhrKLeMocPbn412TsYMHAdK\n\twbvg==","X-Gm-Message-State":"AOAM530XDDLJi94CwNQRY1JXlJgy4g8KWSx1KPFsoEvayZh3GeKjcRnk\n\tB81Yp5Grf1yxwFXlUUkK7xXFKxGPhjYHLA==","X-Google-Smtp-Source":"ABdhPJwZTnm0WL+hNMs2Mr2v7En/sX8BgQdFqqDnzuQfWaXRy4MqGK/EdOZHjMoOrbv7IuZn1+OKjg==","X-Received":"by 2002:a5d:658d:: with SMTP id\n\tq13mr25136520wru.388.1615243187038; \n\tMon, 08 Mar 2021 14:39:47 -0800 (PST)","From":"David Plowman ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 8 Mar 2021 22:39:39 +0000","Message-Id":"<20210308223939.2088-4-david.plowman@raspberrypi.com>","X-Mailer":"git-send-email 2.20.1","In-Reply-To":"<20210308223939.2088-1-david.plowman@raspberrypi.com>","References":"<20210308223939.2088-1-david.plowman@raspberrypi.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v2 3/3] ipa: raspberrypi: Rename vblank\n\tfield in SensorConfig to vblankDelay","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The name vblankDelay is clearer.\n\nSigned-off-by: David Plowman \n---\n include/libcamera/ipa/raspberrypi.mojom | 2 +-\n src/ipa/raspberrypi/raspberrypi.cpp | 2 +-\n src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 2 +-\n 3 files changed, 3 insertions(+), 3 deletions(-)","diff":"diff --git a/include/libcamera/ipa/raspberrypi.mojom b/include/libcamera/ipa/raspberrypi.mojom\nindex f733a2cd..c3d614b8 100644\n--- a/include/libcamera/ipa/raspberrypi.mojom\n+++ b/include/libcamera/ipa/raspberrypi.mojom\n@@ -22,7 +22,7 @@ enum ConfigOutputParameters {\n struct SensorConfig {\n \tuint32 gainDelay;\n \tuint32 exposureDelay;\n-\tuint32 vblank;\n+\tuint32 vblankDelay;\n \tuint32 sensorMetadata;\n };\n \ndiff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp\nindex 741bff4c..85a2b846 100644\n--- a/src/ipa/raspberrypi/raspberrypi.cpp\n+++ b/src/ipa/raspberrypi/raspberrypi.cpp\n@@ -349,7 +349,7 @@ void IPARPi::configure(const CameraSensorInfo &sensorInfo,\n \t\tresult->params |= ipa::RPi::ConfigSensorParams;\n \t\tresult->sensorConfig.gainDelay = gainDelay;\n \t\tresult->sensorConfig.exposureDelay = exposureDelay;\n-\t\tresult->sensorConfig.vblank = vblankDelay;\n+\t\tresult->sensorConfig.vblankDelay = vblankDelay;\n \t\tresult->sensorConfig.sensorMetadata = sensorMetadata;\n \t}\n \ndiff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\nindex db91f1b5..6387fae5 100644\n--- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n+++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n@@ -1266,7 +1266,7 @@ int RPiCameraData::configureIPA(const CameraConfiguration *config)\n \t\tstd::unordered_map delays = {\n \t\t\t{ V4L2_CID_ANALOGUE_GAIN, result.sensorConfig.gainDelay },\n \t\t\t{ V4L2_CID_EXPOSURE, result.sensorConfig.exposureDelay },\n-\t\t\t{ V4L2_CID_VBLANK, result.sensorConfig.vblank }\n+\t\t\t{ V4L2_CID_VBLANK, result.sensorConfig.vblankDelay }\n \t\t};\n \n \t\tdelayedCtrls_ = std::make_unique(unicam_[Unicam::Image].dev(), delays);\n","prefixes":["libcamera-devel","v2","3/3"]}