{"id":11512,"url":"https://patchwork.libcamera.org/api/1.1/patches/11512/?format=json","web_url":"https://patchwork.libcamera.org/patch/11512/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210308101356.59333-4-paul.elder@ideasonboard.com>","date":"2021-03-08T10:13:55","name":"[libcamera-devel,3/4] android: jpeg: exif: Fix setGPSLocation longitude","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"59c32eea074c8c6f58d664d70b4f64574477d427","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/1.1/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/11512/mbox/","series":[{"id":1767,"url":"https://patchwork.libcamera.org/api/1.1/series/1767/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1767","date":"2021-03-08T10:13:52","name":"android: jpeg: exif: Fix GPS altitude","version":1,"mbox":"https://patchwork.libcamera.org/series/1767/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/11512/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/11512/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B8FFEBD1F1\n\tfor ;\n\tMon, 8 Mar 2021 10:14:13 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7257268AA3;\n\tMon, 8 Mar 2021 11:14:13 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DD2A068AA3\n\tfor ;\n\tMon, 8 Mar 2021 11:14:11 +0100 (CET)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6FC458A3;\n\tMon, 8 Mar 2021 11:14:10 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"agZ/ZJfz\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1615198451;\n\tbh=EAYWLFCLd/rHD1ON91T8EI4cyoKo2coOAuIYUO12rVU=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=agZ/ZJfzBj1twuI0MqPb0kQ2bfKweDYS0JYEAP4DWfA5ZlWcDUcICxg+NO8VS8+14\n\tVHhwaS4HQqk/Dg+Ar5Ap4WT4UfypwZPZ3gwPUYtSYbyDaIcP2Dm4HVU6s9mrFqF0Nn\n\tMZH7zU2fLi4lgrPaK6vrr1ejMkB5isaRZ1n6HxCg=","From":"Paul Elder ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 8 Mar 2021 19:13:55 +0900","Message-Id":"<20210308101356.59333-4-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20210308101356.59333-1-paul.elder@ideasonboard.com>","References":"<20210308101356.59333-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH 3/4] android: jpeg: exif: Fix\n\tsetGPSLocation longitude","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"There was a copy-paste error that caused the latitude to be set twice and\nthe longitude never. Fix this.\n\nThis is part of the fix that allows the following CTS test to pass:\n- android.hardware.cts.CameraTest#testJpegExif\n\nSigned-off-by: Paul Elder \n---\n src/android/jpeg/exif.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/android/jpeg/exif.cpp b/src/android/jpeg/exif.cpp\nindex c8b2f072..5225d17f 100644\n--- a/src/android/jpeg/exif.cpp\n+++ b/src/android/jpeg/exif.cpp\n@@ -392,7 +392,7 @@ void Exif::setGPSLocation(const double *coords)\n \tstd::tie(deg, min, sec) = degreesToDMS(coords[1]);\n \tsetString(EXIF_IFD_GPS, static_cast(EXIF_TAG_GPS_LONGITUDE_REF),\n \t\t EXIF_FORMAT_ASCII, deg >= 0 ? \"E\" : \"W\");\n-\tsetGPSDMS(EXIF_IFD_GPS, static_cast(EXIF_TAG_GPS_LATITUDE),\n+\tsetGPSDMS(EXIF_IFD_GPS, static_cast(EXIF_TAG_GPS_LONGITUDE),\n \t\t std::abs(deg), min, sec);\n \n \tsetByte(EXIF_IFD_GPS, static_cast(EXIF_TAG_GPS_ALTITUDE_REF),\n","prefixes":["libcamera-devel","3/4"]}