{"id":11494,"url":"https://patchwork.libcamera.org/api/1.1/patches/11494/?format=json","web_url":"https://patchwork.libcamera.org/patch/11494/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210304084743.11721-1-paul.elder@ideasonboard.com>","date":"2021-03-04T08:47:43","name":"[libcamera-devel,v1,2/2] DEMO: raspberrypi: Use custom parameters to init()","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"caf108ad344c2dbacbafea02a106cf2e9d3cc6c9","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/1.1/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/11494/mbox/","series":[{"id":1758,"url":"https://patchwork.libcamera.org/api/1.1/series/1758/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1758","date":"2021-03-04T08:47:02","name":"[libcamera-devel,v1,1/2] utils: ipc: Support custom parameters to init()","version":1,"mbox":"https://patchwork.libcamera.org/series/1758/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/11494/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/11494/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A519EBD80C\n\tfor ;\n\tThu, 4 Mar 2021 08:48:29 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5CA4368A99;\n\tThu, 4 Mar 2021 09:48:29 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9D3BA602EC\n\tfor ;\n\tThu, 4 Mar 2021 09:48:27 +0100 (CET)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C541A27A;\n\tThu, 4 Mar 2021 09:48:25 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"li5WwH+W\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1614847706;\n\tbh=ui9OZt7pcVmsbEOuWZ1spuAIs2LAG9/LHtcQ+MPchGU=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=li5WwH+Wr+aFw118Y8GZd/8i4whWiEQWV1LOSIUcNOcY9f0zLiUfcRpU4SLVCMtqD\n\tf2a/xvbE0qiKliFqHBL1V7Pjdvhuf2k5JRsVDcTG5/zH7KEPbhaaxCrorT4ySd7MwW\n\tc5RAVB3zQcWyhDAMwdlLcPovG+iNnjEekNqcPYpU=","From":"Paul Elder ","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 4 Mar 2021 17:47:43 +0900","Message-Id":"<20210304084743.11721-1-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v1 2/2] DEMO: raspberrypi: Use custom\n\tparameters to init()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"This is just a demo to show custom parameters to init() with the\nraspberrypi IPA interface.\n\nSigned-off-by: Paul Elder \n---\n include/libcamera/ipa/raspberrypi.mojom | 3 ++-\n src/ipa/raspberrypi/raspberrypi.cpp | 12 +++++++++---\n src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 6 +++++-\n 3 files changed, 16 insertions(+), 5 deletions(-)","diff":"diff --git a/include/libcamera/ipa/raspberrypi.mojom b/include/libcamera/ipa/raspberrypi.mojom\nindex f733a2cd..b8944227 100644\n--- a/include/libcamera/ipa/raspberrypi.mojom\n+++ b/include/libcamera/ipa/raspberrypi.mojom\n@@ -51,7 +51,8 @@ struct StartControls {\n };\n \n interface IPARPiInterface {\n-\tinit(IPASettings settings) => (int32 ret);\n+\tinit(IPASettings settings, string sensorName)\n+\t\t=> (int32 ret, bool metadataSupport);\n \tstart(StartControls controls) => (StartControls result);\n \tstop();\n \ndiff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp\nindex 6348d071..6a9aba6f 100644\n--- a/src/ipa/raspberrypi/raspberrypi.cpp\n+++ b/src/ipa/raspberrypi/raspberrypi.cpp\n@@ -79,7 +79,8 @@ public:\n \t\t\tmunmap(lsTable_, ipa::RPi::MaxLsGridSize);\n \t}\n \n-\tint init(const IPASettings &settings) override;\n+\tvoid init(const IPASettings &settings, const std::string &sensorName,\n+\t\t int *ret, bool *metadataSupport) override;\n \tvoid start(const ipa::RPi::StartControls &data,\n \t\t ipa::RPi::StartControls *result) override;\n \tvoid stop() override {}\n@@ -164,10 +165,15 @@ private:\n \tdouble maxFrameDuration_;\n };\n \n-int IPARPi::init(const IPASettings &settings)\n+void IPARPi::init(const IPASettings &settings, const std::string &sensorName,\n+\t\t int *ret, bool *metadataSupport)\n {\n+\tLOG(IPARPI, Debug) << \"sensor name is \" << sensorName;\n+\n \ttuningFile_ = settings.configurationFile;\n-\treturn 0;\n+\n+\t*metadataSupport = true;\n+\t*ret = 0;\n }\n \n void IPARPi::start(const ipa::RPi::StartControls &data,\ndiff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\nindex db91f1b5..a1c90028 100644\n--- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n+++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n@@ -1194,7 +1194,11 @@ int RPiCameraData::loadIPA()\n \n \tIPASettings settings(ipa_->configurationFile(sensor_->model() + \".json\"));\n \n-\treturn ipa_->init(settings);\n+\tint ret;\n+\tbool metadataSupport;\n+\tipa_->init(settings, \"sensor name\", &ret, &metadataSupport);\n+\tLOG(RPI, Debug) << \"metadata support \" << (metadataSupport ? \"yes\" : \"no\");\n+\treturn ret;\n }\n \n int RPiCameraData::configureIPA(const CameraConfiguration *config)\n","prefixes":["libcamera-devel","v1","2/2"]}