{"id":11479,"url":"https://patchwork.libcamera.org/api/1.1/patches/11479/?format=json","web_url":"https://patchwork.libcamera.org/patch/11479/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210303163715.21730-2-laurent.pinchart@ideasonboard.com>","date":"2021-03-03T16:37:15","name":"[libcamera-devel,2/2] libcamera: v4l2_videodevice: Print fd value in log prefix","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"ea415cf62d61eafc1ec71c99dda00654b2dad040","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/11479/mbox/","series":[{"id":1753,"url":"https://patchwork.libcamera.org/api/1.1/series/1753/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1753","date":"2021-03-03T16:37:14","name":"[libcamera-devel,1/2] libcamera: v4l2_device: Make fd() function const","version":1,"mbox":"https://patchwork.libcamera.org/series/1753/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/11479/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/11479/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 25BC9BD1F1\n\tfor ;\n\tWed, 3 Mar 2021 16:37:50 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E690A68A91;\n\tWed, 3 Mar 2021 17:37:49 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0625868A7E\n\tfor ;\n\tWed, 3 Mar 2021 17:37:48 +0100 (CET)","from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9D4D48CA\n\tfor ;\n\tWed, 3 Mar 2021 17:37:47 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"HXAIZWk0\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1614789467;\n\tbh=aTtXIZ/K/23lEG8EDI0IPPWGNHKBYILwBVB6wSM5kCI=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=HXAIZWk0424Nk/3aOCe+veloMI/JUbhbt8t+omZpobftdHAlrb7r8mBC8iXvunODx\n\t7Qz81QTldoAjDtASEnxcttOF0rVEn8nDKGWbu/AtvDk3uJHXvlpn/E2l6ViANZPnP/\n\tyIfuOrV243V12wSYEIStUxisxLfgPb5BIi1KaSp8=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 3 Mar 2021 18:37:15 +0200","Message-Id":"<20210303163715.21730-2-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.28.0","In-Reply-To":"<20210303163715.21730-1-laurent.pinchart@ideasonboard.com>","References":"<20210303163715.21730-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH 2/2] libcamera: v4l2_videodevice: Print fd\n\tvalue in log prefix","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"When opening a V4L2VideoDevice multiple times, for instance to run\nmultiple jobs on a M2M device, it's useful to attribute log messages to\na particular instance. Include the device fd in the log prefix.\n\nSigned-off-by: Laurent Pinchart \n---\n src/libcamera/v4l2_videodevice.cpp | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp\nindex c77e1aff7978..cb52d4cea3f6 100644\n--- a/src/libcamera/v4l2_videodevice.cpp\n+++ b/src/libcamera/v4l2_videodevice.cpp\n@@ -711,7 +711,8 @@ void V4L2VideoDevice::close()\n \n std::string V4L2VideoDevice::logPrefix() const\n {\n-\treturn deviceNode() + (V4L2_TYPE_IS_OUTPUT(bufferType_) ? \"[out]\" : \"[cap]\");\n+\treturn deviceNode() + \"[\" + std::to_string(fd()) +\n+\t\t(V4L2_TYPE_IS_OUTPUT(bufferType_) ? \":out]\" : \":cap]\");\n }\n \n /**\n","prefixes":["libcamera-devel","2/2"]}