{"id":11460,"url":"https://patchwork.libcamera.org/api/1.1/patches/11460/?format=json","web_url":"https://patchwork.libcamera.org/patch/11460/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210302150501.15191-2-laurent.pinchart@ideasonboard.com>","date":"2021-03-02T15:05:01","name":"[libcamera-devel,2/2] utils: ipc: Support extending IPA init() parameters","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"0cf46bceeb4ee93b6ade335450caa1d20a40f3c9","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/11460/mbox/","series":[{"id":1741,"url":"https://patchwork.libcamera.org/api/1.1/series/1741/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1741","date":"2021-03-02T15:05:00","name":"[libcamera-devel,1/2] utils: ipc: templates: Drop unused variable","version":1,"mbox":"https://patchwork.libcamera.org/series/1741/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/11460/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/11460/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2AE29BD1F1\n\tfor ;\n\tTue, 2 Mar 2021 15:05:37 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2E80D68AA0;\n\tTue, 2 Mar 2021 16:05:36 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D1A2968A7E\n\tfor ;\n\tTue, 2 Mar 2021 16:05:34 +0100 (CET)","from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 54F5E8F3;\n\tTue, 2 Mar 2021 16:05:34 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"oalU2FjU\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1614697534;\n\tbh=ICptAwr6tAOn5Wr0ibFRvE2GUXI0QwhFOf30wY4eyaQ=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=oalU2FjUOp0ZofS9mj6co1xKS5UWcjM85VnNwKxBeYz0xXkqh40rqJ+IvV5sFnpb9\n\ttR1V/SumkQxQ7uqKEfrzODBs9BY7hSiicQOSf6O5h9q6JbqspVegR4wLWRlR6CrQT+\n\t1xu1hEmYLsG9EQZ504xUfg/QvQih0Gtfg6fOB0o0=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 2 Mar 2021 17:05:01 +0200","Message-Id":"<20210302150501.15191-2-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.28.0","In-Reply-To":"<20210302150501.15191-1-laurent.pinchart@ideasonboard.com>","References":"<20210302150501.15191-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH 2/2] utils: ipc: Support extending IPA\n\tinit() parameters","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"It can be useful for pipeline handlers to pass additional parameters to\nthe IPA init() method. Allow doing so.\n\nSigned-off-by: Laurent Pinchart \n---\n .../libcamera_templates/module_ipa_proxy.cpp.tmpl | 2 +-\n .../generators/libcamera_templates/proxy_functions.tmpl | 8 ++++++--\n utils/ipc/generators/mojom_libcamera_generator.py | 3 ---\n 3 files changed, 7 insertions(+), 6 deletions(-)","diff":"diff --git a/utils/ipc/generators/libcamera_templates/module_ipa_proxy.cpp.tmpl b/utils/ipc/generators/libcamera_templates/module_ipa_proxy.cpp.tmpl\nindex d451fab35e83..f2f9128b056c 100644\n--- a/utils/ipc/generators/libcamera_templates/module_ipa_proxy.cpp.tmpl\n+++ b/utils/ipc/generators/libcamera_templates/module_ipa_proxy.cpp.tmpl\n@@ -142,7 +142,7 @@ void {{proxy_name}}::recvMessage(const IPCMessage &data)\n {{proxy_funcs.func_sig(proxy_name, method, \"Thread\")}}\n {\n {%- if method.mojom_name == \"init\" %}\n-\t{{proxy_funcs.init_thread_body()}}\n+\t{{proxy_funcs.init_thread_body(method)}}\n {%- elif method.mojom_name == \"stop\" %}\n \t{{proxy_funcs.stop_thread_body()}}\n {%- elif method.mojom_name == \"start\" %}\ndiff --git a/utils/ipc/generators/libcamera_templates/proxy_functions.tmpl b/utils/ipc/generators/libcamera_templates/proxy_functions.tmpl\nindex 40611feb179b..222a2a63764d 100644\n--- a/utils/ipc/generators/libcamera_templates/proxy_functions.tmpl\n+++ b/utils/ipc/generators/libcamera_templates/proxy_functions.tmpl\n@@ -22,8 +22,12 @@\n {#\n # \\brief Generate function body for IPA init() function for thread\n #}\n-{%- macro init_thread_body() -%}\n-\tint ret = ipa_->init(settings);\n+{%- macro init_thread_body(method) -%}\n+\tint ret = ipa_->init(\n+\t{%- for param in method|method_param_names -%}\n+\t\t{{param}}{{- \", \" if not loop.last}}\n+\t{%- endfor -%}\n+);\n \tif (ret)\n \t\treturn ret;\n \ndiff --git a/utils/ipc/generators/mojom_libcamera_generator.py b/utils/ipc/generators/mojom_libcamera_generator.py\nindex 438e41c649ad..2bfc4af23231 100644\n--- a/utils/ipc/generators/mojom_libcamera_generator.py\n+++ b/utils/ipc/generators/mojom_libcamera_generator.py\n@@ -346,10 +346,7 @@ def ValidateInterfaces(interfaces):\n f_stop = f_stop[0]\n \n # Validate parameters to init()\n- ValidateSingleLength(f_init.parameters, 'input parameter to init()')\n ValidateSingleLength(f_init.response_parameters, 'output parameter from init()')\n- if f_init.parameters[0].kind.mojom_name != 'IPASettings':\n- raise Exception('init() must have single IPASettings input parameter')\n if f_init.response_parameters[0].kind.spec != 'i32':\n raise Exception('init() must have single int32 output parameter')\n \n","prefixes":["libcamera-devel","2/2"]}