{"id":11455,"url":"https://patchwork.libcamera.org/api/1.1/patches/11455/?format=json","web_url":"https://patchwork.libcamera.org/patch/11455/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210302141844.126634-9-jacopo@jmondi.org>","date":"2021-03-02T14:18:41","name":"[libcamera-devel,v4,08/11] android: camera_buffer: Add method to get the JPEG blob size","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"3df0a5a3759111e24e54dab1d3ab40f25e3a195a","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/1.1/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/11455/mbox/","series":[{"id":1740,"url":"https://patchwork.libcamera.org/api/1.1/series/1740/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1740","date":"2021-03-02T14:18:33","name":"android: Supports memory backends","version":4,"mbox":"https://patchwork.libcamera.org/series/1740/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/11455/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/11455/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A6E98BD808\n\tfor ;\n\tTue, 2 Mar 2021 14:18:36 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8420968A9A;\n\tTue, 2 Mar 2021 15:18:36 +0100 (CET)","from relay12.mail.gandi.net (relay12.mail.gandi.net\n\t[217.70.178.232])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E207768A96\n\tfor ;\n\tTue, 2 Mar 2021 15:18:34 +0100 (CET)","from uno.LocalDomain (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay12.mail.gandi.net (Postfix) with ESMTPSA id AF97020000A;\n\tTue, 2 Mar 2021 14:18:33 +0000 (UTC)"],"From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 2 Mar 2021 15:18:41 +0100","Message-Id":"<20210302141844.126634-9-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.30.0","In-Reply-To":"<20210302141844.126634-1-jacopo@jmondi.org>","References":"<20210302141844.126634-1-jacopo@jmondi.org>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v4 08/11] android: camera_buffer: Add\n\tmethod to get the JPEG blob size","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Han-lin Chen ,\n\tDaniel Hung-yu Wu ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"To maintain compatibility with platforms that do not provide a memory\nbackend implementation add a method to be return the size of the buffer\nused for JPEG encoding capped to a maximum size.\n\nPlatforms that implement a memory backend will always calculate the\ncorrect buffer size.\n\nSigned-off-by: Jacopo Mondi \n---\n src/android/camera_buffer.h | 2 ++\n src/android/mm/generic_camera_buffer.cpp | 14 ++++++++++++++\n 2 files changed, 16 insertions(+)","diff":"diff --git a/src/android/camera_buffer.h b/src/android/camera_buffer.h\nindex 2311cdaf96b2..784fbd50e50b 100644\n--- a/src/android/camera_buffer.h\n+++ b/src/android/camera_buffer.h\n@@ -26,6 +26,8 @@ public:\n \n \tlibcamera::Span plane(unsigned int plane) const;\n \tlibcamera::Span plane(unsigned int plane);\n+\n+\tsize_t jpegBufferSize(size_t maxJpegBufferSize) const;\n };\n \n #endif /* __ANDROID_CAMERA_BUFFER_H__ */\ndiff --git a/src/android/mm/generic_camera_buffer.cpp b/src/android/mm/generic_camera_buffer.cpp\nindex 45a83c351266..98e63dfa0577 100644\n--- a/src/android/mm/generic_camera_buffer.cpp\n+++ b/src/android/mm/generic_camera_buffer.cpp\n@@ -27,6 +27,8 @@ public:\n \tunsigned int numPlanes() const;\n \n \tSpan plane(unsigned int plane);\n+\n+\tsize_t jpegBufferSize(size_t maxJpegBufferSize) const;\n };\n \n CameraBuffer::Private::Private(CameraBuffer *cameraBuffer,\n@@ -77,6 +79,12 @@ Span CameraBuffer::Private::plane(unsigned int plane)\n \treturn maps_[plane];\n }\n \n+size_t CameraBuffer::Private::jpegBufferSize(size_t maxJpegBufferSize) const\n+{\n+\treturn std::min(maps_[0].size(),\n+\t\t\t\t maxJpegBufferSize);\n+}\n+\n CameraBuffer::CameraBuffer(buffer_handle_t camera3Buffer, int flags)\n \t: Extensible(new Private(this, camera3Buffer, flags))\n {\n@@ -109,3 +117,9 @@ Span CameraBuffer::plane(unsigned int plane)\n \tPrivate *const d = LIBCAMERA_D_PTR();\n \treturn d->plane(plane);\n }\n+\n+size_t CameraBuffer::jpegBufferSize(size_t maxJpegBufferSize) const\n+{\n+\tconst Private *const d = LIBCAMERA_D_PTR();\n+\treturn d->jpegBufferSize(maxJpegBufferSize);\n+}\n","prefixes":["libcamera-devel","v4","08/11"]}