{"id":1141,"url":"https://patchwork.libcamera.org/api/1.1/patches/1141/?format=json","web_url":"https://patchwork.libcamera.org/patch/1141/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190430183746.28518-2-laurent.pinchart@ideasonboard.com>","date":"2019-04-30T18:37:42","name":"[libcamera-devel,1/5] libcamera: pipeline_handler: Remove duplicated log from uvc and vimc","commit_ref":"baad55d00975f8931d51c333def20472457dc943","pull_url":null,"state":"accepted","archived":false,"hash":"795de87a65f81c09067ab6362ad46bc736d916d4","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/1141/mbox/","series":[{"id":285,"url":"https://patchwork.libcamera.org/api/1.1/series/285/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=285","date":"2019-04-30T18:37:41","name":"Miscellaneous cleanups and refactoring","version":1,"mbox":"https://patchwork.libcamera.org/series/285/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/1141/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/1141/checks/","tags":{},"headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1A65760E5B\n\tfor ;\n\tTue, 30 Apr 2019 20:38:02 +0200 (CEST)","from pendragon.station (net-37-182-44-227.cust.vodafonedsl.it\n\t[37.182.44.227])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A5FD156A\n\tfor ;\n\tTue, 30 Apr 2019 20:38:01 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1556649481;\n\tbh=fcTmE0PaNB5J5AnfzMDxfHTFr3fR7v/xEJZPk82E/mg=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=FXDErKfnInjofbCfESNnyR+MFum90dLtWVbUmR5afVWUOTab7RVzdhnfPF4fbblaQ\n\tujggwvN3Ns0gPbv0FymDSHnS+nbsXTKl+i853E4krAIGiLG3R6KpfhuE5EcBsJIuKH\n\tqxl0Ud5GSSpWty+ceQRzqUH/TvNvKRtDxrU2H+to=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 30 Apr 2019 21:37:42 +0300","Message-Id":"<20190430183746.28518-2-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.21.0","In-Reply-To":"<20190430183746.28518-1-laurent.pinchart@ideasonboard.com>","References":"<20190430183746.28518-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 1/5] libcamera: pipeline_handler: Remove\n\tduplicated log from uvc and vimc","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 30 Apr 2019 18:38:02 -0000"},"content":"The uvcvideo and vimc pipeline handlers print the requested resolution\nin their configureStreams() operation. This duplicates a generic log\nstatement in the Camera::configureStreams() method, remove it.\n\nSigned-off-by: Laurent Pinchart \n---\n src/libcamera/pipeline/uvcvideo.cpp | 3 ---\n src/libcamera/pipeline/vimc.cpp | 3 ---\n 2 files changed, 6 deletions(-)","diff":"diff --git a/src/libcamera/pipeline/uvcvideo.cpp b/src/libcamera/pipeline/uvcvideo.cpp\nindex 2f9b5e0fdc08..fd1d6df177d9 100644\n--- a/src/libcamera/pipeline/uvcvideo.cpp\n+++ b/src/libcamera/pipeline/uvcvideo.cpp\n@@ -109,9 +109,6 @@ int PipelineHandlerUVC::configureStreams(Camera *camera,\n \tconst StreamConfiguration *cfg = &config[&data->stream_];\n \tint ret;\n \n-\tLOG(UVC, Debug) << \"Configure the camera for resolution \"\n-\t\t\t<< cfg->width << \"x\" << cfg->height;\n-\n \tV4L2DeviceFormat format = {};\n \tformat.width = cfg->width;\n \tformat.height = cfg->height;\ndiff --git a/src/libcamera/pipeline/vimc.cpp b/src/libcamera/pipeline/vimc.cpp\nindex f70b4d3c6bab..f95140661b2a 100644\n--- a/src/libcamera/pipeline/vimc.cpp\n+++ b/src/libcamera/pipeline/vimc.cpp\n@@ -109,9 +109,6 @@ int PipelineHandlerVimc::configureStreams(Camera *camera,\n \tconst StreamConfiguration *cfg = &config[&data->stream_];\n \tint ret;\n \n-\tLOG(VIMC, Debug) << \"Configure the camera for resolution \"\n-\t\t\t << cfg->width << \"x\" << cfg->height;\n-\n \tV4L2DeviceFormat format = {};\n \tformat.width = cfg->width;\n \tformat.height = cfg->height;\n","prefixes":["libcamera-devel","1/5"]}