{"id":11367,"url":"https://patchwork.libcamera.org/api/1.1/patches/11367/?format=json","web_url":"https://patchwork.libcamera.org/patch/11367/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210223164041.49932-2-jeanmichel.hautbois@ideasonboard.com>","date":"2021-02-23T16:40:39","name":"[libcamera-devel,RFC,v2,1/3] WIP: ipa: Add a common interface for algorithm objects","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"8a03b094e4ca6d26012a05165cd13df96f7b4085","submitter":{"id":75,"url":"https://patchwork.libcamera.org/api/1.1/people/75/?format=json","name":"Jean-Michel Hautbois","email":"jeanmichel.hautbois@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/11367/mbox/","series":[{"id":1722,"url":"https://patchwork.libcamera.org/api/1.1/series/1722/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1722","date":"2021-02-23T16:40:38","name":"Implement IPA algorithms and demo with IPU3","version":2,"mbox":"https://patchwork.libcamera.org/series/1722/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/11367/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/11367/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E353BBD1F1\n\tfor ;\n\tTue, 23 Feb 2021 16:40:47 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C589D68A3A;\n\tTue, 23 Feb 2021 17:40:46 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C1BC368A2F\n\tfor ;\n\tTue, 23 Feb 2021 17:40:43 +0100 (CET)","from localhost.localdomain (unknown\n\t[IPv6:2a01:e0a:169:7140:d7c9:eb3:c460:c24a])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 63A3E90C;\n\tTue, 23 Feb 2021 17:40:43 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"vJhAKLD9\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1614098443;\n\tbh=jZrk5k22e9JNhGw2NKZ78BZohYFlK5c8a5TKKJMGkpA=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=vJhAKLD9mStQ/OxQiOr/L2MifDpFBhB4baSMULlwSWsk8ZliaFJizEwDHFyIgL63l\n\tTD0c0aFX7zb1Dh1tEJ1b7LsIwRzVRRPimft9xkutCJUYXtM27ZMfIHA2Mu/1OLp7hO\n\tB3XOuDvCIJEMR079yPuRYaFPJIJ5993jcxRwPKB4=","From":"Jean-Michel Hautbois ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 23 Feb 2021 17:40:39 +0100","Message-Id":"<20210223164041.49932-2-jeanmichel.hautbois@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20210223164041.49932-1-jeanmichel.hautbois@ideasonboard.com>","References":"<20210223164041.49932-1-jeanmichel.hautbois@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [RFC PATCH v2 1/3] WIP: ipa: Add a common\n\tinterface for algorithm objects","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"In order to instanciate and use algorithms (AWB, AGC, etc.)\nthere is a need for a common class to define mandatory methods.\n\nInstead of reinventing the wheel, reuse what Raspberry Pi has done and\nadapt to the minimum requirements expected.\n\nSigned-off-by: Jean-Michel Hautbois \n---\n src/ipa/libipa/algorithm.cpp | 25 +++++++++++++++++++++++++\n src/ipa/libipa/algorithm.h | 29 +++++++++++++++++++++++++++++\n src/ipa/libipa/meson.build | 4 +++-\n 3 files changed, 57 insertions(+), 1 deletion(-)\n create mode 100644 src/ipa/libipa/algorithm.cpp\n create mode 100644 src/ipa/libipa/algorithm.h","diff":"diff --git a/src/ipa/libipa/algorithm.cpp b/src/ipa/libipa/algorithm.cpp\nnew file mode 100644\nindex 00000000..24cd0ae2\n--- /dev/null\n+++ b/src/ipa/libipa/algorithm.cpp\n@@ -0,0 +1,25 @@\n+/* SPDX-License-Identifier: BSD-2-Clause */\n+/*\n+ * Copyright (C) 2019, Raspberry Pi (Trading) Limited\n+ *\n+ * algorithm.cpp - ISP control algorithms\n+ */\n+\n+#include \"algorithm.h\"\n+\n+/**\n+ * \\file algorithm.h\n+ * \\brief Algorithm common interface\n+ */\n+\n+namespace libcamera {\n+\n+namespace ipa {\n+\n+void Algorithm::initialise() {}\n+\n+void Algorithm::process() {}\n+\n+} /* namespace ipa */\n+\n+} /* namespace libcamera */\ndiff --git a/src/ipa/libipa/algorithm.h b/src/ipa/libipa/algorithm.h\nnew file mode 100644\nindex 00000000..56cd8172\n--- /dev/null\n+++ b/src/ipa/libipa/algorithm.h\n@@ -0,0 +1,29 @@\n+/* SPDX-License-Identifier: LGPL-2.1-or-later */\n+/*\n+ * Copyright (C) 2019, Raspberry Pi (Trading) Limited\n+ *\n+ * algorithm.h - ISP control algorithm interface\n+ */\n+#ifndef __LIBCAMERA_IPA_LIBIPA_ALGORITHM_H__\n+#define __LIBCAMERA_IPA_LIBIPA_ALGORITHM_H__\n+\n+namespace libcamera {\n+\n+namespace ipa {\n+\n+class Algorithm\n+{\n+public:\n+\tAlgorithm()\n+\t{\n+\t}\n+\tvirtual ~Algorithm() = default;\n+\tvirtual void initialise();\n+\tvirtual void process();\n+};\n+\n+} /* namespace ipa */\n+\n+} /* namespace libcamera */\n+\n+#endif /* __LIBCAMERA_IPA_LIBIPA_ALGORITHM_H__ */\ndiff --git a/src/ipa/libipa/meson.build b/src/ipa/libipa/meson.build\nindex b29ef0f4..585d02a3 100644\n--- a/src/ipa/libipa/meson.build\n+++ b/src/ipa/libipa/meson.build\n@@ -1,13 +1,15 @@\n # SPDX-License-Identifier: CC0-1.0\n \n libipa_headers = files([\n+ 'algorithm.h',\n ])\n \n libipa_sources = files([\n+ 'algorithm.cpp',\n ])\n \n libipa_includes = include_directories('..')\n \n-libipa = static_library('ipa', libipa_sources,\n+libipa = static_library('ipa', [libipa_sources, libipa_headers],\n include_directories : ipa_includes,\n dependencies : libcamera_dep)\n","prefixes":["libcamera-devel","RFC","v2","1/3"]}