{"id":11316,"url":"https://patchwork.libcamera.org/api/1.1/patches/11316/?format=json","web_url":"https://patchwork.libcamera.org/patch/11316/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210217092937.17167-1-paul.elder@ideasonboard.com>","date":"2021-02-17T09:29:36","name":"[libcamera-devel,1/2] utils: ipc: Generate tracepoints for IPA calls","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"2b994f9b80af922a3e70e349f15c47bb5e3810b4","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/1.1/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"delegate":{"id":17,"url":"https://patchwork.libcamera.org/api/1.1/users/17/?format=json","username":"epaul","first_name":"Paul","last_name":"Elder","email":"paul.elder@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/patch/11316/mbox/","series":[{"id":1699,"url":"https://patchwork.libcamera.org/api/1.1/series/1699/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1699","date":"2021-02-17T09:29:36","name":"[libcamera-devel,1/2] utils: ipc: Generate tracepoints for IPA calls","version":1,"mbox":"https://patchwork.libcamera.org/series/1699/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/11316/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/11316/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E42EBBD1F1\n\tfor ;\n\tWed, 17 Feb 2021 09:29:52 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 69CD4637FD;\n\tWed, 17 Feb 2021 10:29:52 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A6966602F9\n\tfor ;\n\tWed, 17 Feb 2021 10:29:51 +0100 (CET)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1D9D48C4;\n\tWed, 17 Feb 2021 10:29:49 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"GfgUs3M0\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1613554191;\n\tbh=EIqhrsi5Z/y8QQh/z2INovpIWM4lGK1q7IF6HUhy5z0=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=GfgUs3M0WVGGMmqpcMEwg78f7SsYjgnvoK7x6jQQaYFeqk5Y7LmaWaH6WkAHhtGHn\n\t+9EWsRoEQ2IeZmAgBiP2nMYzoIGzRm5iIRwz1/ju2jKVAKO5liNzVhvdbPx9BBuZPa\n\tjcy0bEoIRnWgNV4HGFMjYV6ctWQo5kRgAhNvmwI8=","From":"Paul Elder ","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 17 Feb 2021 18:29:36 +0900","Message-Id":"<20210217092937.17167-1-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH 1/2] utils: ipc: Generate tracepoints for\n\tIPA calls","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"To ease benchmarking IPA calls, automatically generate tracepoints for\nIPA calls in the IPAProxy.\n\nSigned-off-by: Paul Elder \n---\n .../generators/libcamera_templates/module_ipa_proxy.cpp.tmpl | 3 +++\n 1 file changed, 3 insertions(+)","diff":"diff --git a/utils/ipc/generators/libcamera_templates/module_ipa_proxy.cpp.tmpl b/utils/ipc/generators/libcamera_templates/module_ipa_proxy.cpp.tmpl\nindex ba34a361..5e0d3976 100644\n--- a/utils/ipc/generators/libcamera_templates/module_ipa_proxy.cpp.tmpl\n+++ b/utils/ipc/generators/libcamera_templates/module_ipa_proxy.cpp.tmpl\n@@ -33,6 +33,7 @@\n #include \"libcamera/internal/log.h\"\n #include \"libcamera/internal/process.h\"\n #include \"libcamera/internal/thread.h\"\n+#include \"libcamera/internal/tracepoints.h\"\n \n namespace libcamera {\n \n@@ -125,6 +126,7 @@ void {{proxy_name}}::recvMessage(const IPCMessage &data)\n {% for method in interface_main.methods %}\n {{proxy_funcs.func_sig(proxy_name, method)}}\n {\n+\tLIBCAMERA_TRACEPOINT_IPA_BEGIN({{module_name}}, {{method.mojom_name}});\n \tif (isolate_)\n \t\t{{\"return \" if method|method_return_value != \"void\"}}{{method.mojom_name}}IPC(\n {%- for param in method|method_param_names -%}\n@@ -137,6 +139,7 @@ void {{proxy_name}}::recvMessage(const IPCMessage &data)\n \t\t{{param}}{{- \", \" if not loop.last}}\n {%- endfor -%}\n );\n+\tLIBCAMERA_TRACEPOINT_IPA_END({{module_name}}, {{method.mojom_name}});\n }\n \n {{proxy_funcs.func_sig(proxy_name, method, \"Thread\")}}\n","prefixes":["libcamera-devel","1/2"]}