{"id":11305,"url":"https://patchwork.libcamera.org/api/1.1/patches/11305/?format=json","web_url":"https://patchwork.libcamera.org/patch/11305/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210216085505.1018624-1-naush@raspberrypi.com>","date":"2021-02-16T08:55:05","name":"[libcamera-devel] ipa: raspberrypi: Fix exposure and gain delays for imx477","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"437efa5f3a8d052498f3778c21cda7267818955d","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/1.1/people/34/?format=json","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/11305/mbox/","series":[{"id":1695,"url":"https://patchwork.libcamera.org/api/1.1/series/1695/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1695","date":"2021-02-16T08:55:05","name":"[libcamera-devel] ipa: raspberrypi: Fix exposure and gain delays for imx477","version":1,"mbox":"https://patchwork.libcamera.org/series/1695/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/11305/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/11305/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 536A0BD1EF\n\tfor ;\n\tTue, 16 Feb 2021 08:55:13 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1EB4B637CC;\n\tTue, 16 Feb 2021 09:55:13 +0100 (CET)","from mail-wr1-x429.google.com (mail-wr1-x429.google.com\n\t[IPv6:2a00:1450:4864:20::429])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DA4D1637CC\n\tfor ;\n\tTue, 16 Feb 2021 09:55:10 +0100 (CET)","by mail-wr1-x429.google.com with SMTP id u14so12021218wri.3\n\tfor ;\n\tTue, 16 Feb 2021 00:55:10 -0800 (PST)","from naush-laptop.patuck.local ([88.97.76.4])\n\tby smtp.gmail.com with ESMTPSA id\n\t17sm3439063wmf.32.2021.02.16.00.55.09\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 16 Feb 2021 00:55:10 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"DTvgBfDL\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=Pt2R33gRvenutUD3S63PltqDlLI4OyrhOOkj/HBAQm8=;\n\tb=DTvgBfDLDVKCmcdMkANPIXSiQL8eF/+0JKPYOupPB4m7I3hmu8nvxLzFyQQe/Xj7Iz\n\tBvorV9CeoN8c4k1Hl1MnA61v38Ilk3oe1LTz6rrPo3ulxeqpbR8xJFo5ZFWbbc6l7TtX\n\t4975M6E9NtoSX5muyggO8jjbPIuF4RMaK917pJnoOaJvJ2VPRteDSsmDP8GCzlNH1epE\n\taoS2iI/LcYx1vN+64lRaqCwXBIt/JPdQhS0LONlFnOUYSFvbdN27b9Socl2qjiYJUk7n\n\tByGI4I9zVpUH+EDIjEcFHd6usUnpMqoYdzE9D09AR8yC9kv+qLBrbiWtpbC6KgVhmrQ0\n\tsjMg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=Pt2R33gRvenutUD3S63PltqDlLI4OyrhOOkj/HBAQm8=;\n\tb=H8ZUwsYv/Jq7Ww63hUWdmJFLEnm+c7FhdcX2Zem46bYqXw8yAC5XQ+xmHyj1CWLAjN\n\tBbr2dQXlvSPRAY7NX61SU8DnO1VZwrzY9kQkedScHGKM+5fKFMMSRiZR0bqyqhre0Aqe\n\t7areeHqcqlbj9p9OCEkWlNMpDTuDu12LDr9lXn3GlyuIjwX7yx091jKoAGFUR20CY15W\n\tnGFD92jRLmP7naEhC7OFQIGl4+EnJOG9qmGvLEaFmqJCk3EzwXphXhcxg4KZWedQHEGb\n\tbsBvEwBG060CjKAUFLE+EFOQxzZGhvIvueqNTe+VgZtkdHkA2bqUHoddCWhjAhPByuC6\n\tYguw==","X-Gm-Message-State":"AOAM532V+l/5O9FV3Os1Zds3t5Rxc2/UoPm3giFfn8msF3d2OBHa6csW\n\tnWlJ9pxSPzFVY/Iz7bHvTMYZkYgda2V/lsSV","X-Google-Smtp-Source":"ABdhPJxhCoxTSmEOSyDb95zo7dVOb97OqeX7N2Qx65kS8VhYTZ6GH5n6qgIghm9In2LS/6k+af+F8g==","X-Received":"by 2002:a5d:6c66:: with SMTP id r6mr22299961wrz.86.1613465710390;\n\tTue, 16 Feb 2021 00:55:10 -0800 (PST)","From":"Naushir Patuck ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 16 Feb 2021 08:55:05 +0000","Message-Id":"<20210216085505.1018624-1-naush@raspberrypi.com>","X-Mailer":"git-send-email 2.25.1","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH] ipa: raspberrypi: Fix exposure and gain\n\tdelays for imx477","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The exposure and gain delays for imx477 are both 2 frames. This error\nwas not noticeable because the controller was using the embedded\nmetadata to get the exposure and gain values for the frame.\n\nSigned-off-by: Naushir Patuck \n---\n src/ipa/raspberrypi/cam_helper_imx477.cpp | 7 +++++++\n 1 file changed, 7 insertions(+)","diff":"diff --git a/src/ipa/raspberrypi/cam_helper_imx477.cpp b/src/ipa/raspberrypi/cam_helper_imx477.cpp\nindex 9a53c5dba9f8..e26c91f7d86d 100644\n--- a/src/ipa/raspberrypi/cam_helper_imx477.cpp\n+++ b/src/ipa/raspberrypi/cam_helper_imx477.cpp\n@@ -37,6 +37,7 @@ public:\n \tCamHelperImx477();\n \tuint32_t GainCode(double gain) const override;\n \tdouble Gain(uint32_t gain_code) const override;\n+\tvoid GetDelays(int &exposure_delay, int &gain_delay) const override;\n \tbool SensorEmbeddedDataPresent() const override;\n \n private:\n@@ -62,6 +63,12 @@ double CamHelperImx477::Gain(uint32_t gain_code) const\n \treturn 1024.0 / (1024 - gain_code);\n }\n \n+void CamHelperImx477::GetDelays(int &exposure_delay, int &gain_delay) const\n+{\n+\texposure_delay = 2;\n+\tgain_delay = 2;\n+}\n+\n bool CamHelperImx477::SensorEmbeddedDataPresent() const\n {\n \treturn true;\n","prefixes":["libcamera-devel"]}