{"id":11263,"url":"https://patchwork.libcamera.org/api/1.1/patches/11263/?format=json","web_url":"https://patchwork.libcamera.org/patch/11263/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210212133056.873230-4-kieran.bingham@ideasonboard.com>","date":"2021-02-12T13:30:52","name":"[libcamera-devel,v3,3/7] libcamera: buffer: Utilise LIBCAMERA_DISABLE_COPY_AND_MOVE","commit_ref":"74f103486c44f548f326c21df745ef2280a9a7fb","pull_url":null,"state":"accepted","archived":false,"hash":"8b71c6f10f35ac43a82d2a584cd5ab18cf285c08","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/1.1/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/11263/mbox/","series":[{"id":1685,"url":"https://patchwork.libcamera.org/api/1.1/series/1685/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1685","date":"2021-02-12T13:30:49","name":"Delete Copy-Move-Assign","version":3,"mbox":"https://patchwork.libcamera.org/series/1685/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/11263/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/11263/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CAEC0BD160\n\tfor ;\n\tFri, 12 Feb 2021 13:31:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0D97A63786;\n\tFri, 12 Feb 2021 14:31:04 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 214B56377B\n\tfor ;\n\tFri, 12 Feb 2021 14:31:01 +0100 (CET)","from Q.local (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net\n\t[86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C0B611508;\n\tFri, 12 Feb 2021 14:31:00 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"XjFa0xk4\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1613136660;\n\tbh=hi76FhRNIqGfKZ1cz9+XkJLUF/rsE6a5k1IinjL/iCA=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=XjFa0xk4xX6vPtTA3loX4bBazlkJauoj77uOtmvI4TiZs1osiD59wDqZuUFIZFsod\n\tuMAPMzzHfH26M9XLNcqQkBOintb4dBYwAPgZBnV7lX9oQxRwaV9RNf55OVLI/ps3N3\n\tl2C86VaHjsxKZYED2YjzR4/QG1/hFBDJGe3KadGo=","From":"Kieran Bingham ","To":"libcamera devel ","Date":"Fri, 12 Feb 2021 13:30:52 +0000","Message-Id":"<20210212133056.873230-4-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20210212133056.873230-1-kieran.bingham@ideasonboard.com>","References":"<20210212133056.873230-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v3 3/7] libcamera: buffer: Utilise\n\tLIBCAMERA_DISABLE_COPY_AND_MOVE","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Convert the existing copy, move and assignment operators to use the new\nmacros.\n\nReviewed-by: Laurent Pinchart \nSigned-off-by: Kieran Bingham \n---\n include/libcamera/buffer.h | 10 ++++------\n 1 file changed, 4 insertions(+), 6 deletions(-)","diff":"diff --git a/include/libcamera/buffer.h b/include/libcamera/buffer.h\nindex a26c8927d37a..302fe3d3e86b 100644\n--- a/include/libcamera/buffer.h\n+++ b/include/libcamera/buffer.h\n@@ -10,6 +10,7 @@\n #include \n #include \n \n+#include \n #include \n \n namespace libcamera {\n@@ -43,12 +44,6 @@ public:\n \n \tFrameBuffer(const std::vector &planes, unsigned int cookie = 0);\n \n-\tFrameBuffer(const FrameBuffer &) = delete;\n-\tFrameBuffer(FrameBuffer &&) = delete;\n-\n-\tFrameBuffer &operator=(const FrameBuffer &) = delete;\n-\tFrameBuffer &operator=(FrameBuffer &&) = delete;\n-\n \tconst std::vector &planes() const { return planes_; }\n \n \tRequest *request() const { return request_; }\n@@ -57,7 +52,10 @@ public:\n \n \tunsigned int cookie() const { return cookie_; }\n \tvoid setCookie(unsigned int cookie) { cookie_ = cookie; }\n+\n private:\n+\tLIBCAMERA_DISABLE_COPY_AND_MOVE(FrameBuffer)\n+\n \tfriend class Request; /* Needed to update request_. */\n \tfriend class V4L2VideoDevice; /* Needed to update metadata_. */\n \n","prefixes":["libcamera-devel","v3","3/7"]}