{"id":11262,"url":"https://patchwork.libcamera.org/api/1.1/patches/11262/?format=json","web_url":"https://patchwork.libcamera.org/patch/11262/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210212133056.873230-3-kieran.bingham@ideasonboard.com>","date":"2021-02-12T13:30:51","name":"[libcamera-devel,v3,2/7] libcamera: class: Provide move and copy disablers","commit_ref":"41b6d83e6a0c39b31464fce67e69f0d4c5c905cc","pull_url":null,"state":"accepted","archived":false,"hash":"64b52b1195ff005682808d206dba01826a4f91ae","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/1.1/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/11262/mbox/","series":[{"id":1685,"url":"https://patchwork.libcamera.org/api/1.1/series/1685/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1685","date":"2021-02-12T13:30:49","name":"Delete Copy-Move-Assign","version":3,"mbox":"https://patchwork.libcamera.org/series/1685/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/11262/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/11262/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 67E9EBD160\n\tfor ;\n\tFri, 12 Feb 2021 13:31:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EC59463792;\n\tFri, 12 Feb 2021 14:31:02 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EB35E63772\n\tfor ;\n\tFri, 12 Feb 2021 14:31:00 +0100 (CET)","from Q.local (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net\n\t[86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 856101253;\n\tFri, 12 Feb 2021 14:31:00 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"OLZL2ECc\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1613136660;\n\tbh=zOj4Fv/7FwvtQV1PpQ4W0SUBsm9q+9nWisXGaTGQCX4=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=OLZL2ECcwdfhdZxIYExWP7+Hhy/6KYaYIkm+UKWq0K3vrlJt2WWp6ELvJ/jZhaC8f\n\tZv+nebJAlovtKLeay8ushoN35CcULhbDQtun3cA6A6iMIl4VU8DFqjenmYN6Qs+T8h\n\tfg41fedjGAKfGtFAX1oxqLYe2vo6YRMKELSECmp8=","From":"Kieran Bingham ","To":"libcamera devel ","Date":"Fri, 12 Feb 2021 13:30:51 +0000","Message-Id":"<20210212133056.873230-3-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20210212133056.873230-1-kieran.bingham@ideasonboard.com>","References":"<20210212133056.873230-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v3 2/7] libcamera: class: Provide move and\n\tcopy disablers","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"It can be difficult to correctly parse the syntax for copy/move and the\nassociated assignment operators.\n\nProvide helpers as syntactic sugar to facilitate disabling either the\ncopy constructor, and copy assignment operator, and the move constructor\nand move assignment operator in a way which is explicit and clear.\n\nSigned-off-by: Kieran Bingham \n---\n include/libcamera/class.h | 18 +++++++++++++\n src/libcamera/class.cpp | 57 +++++++++++++++++++++++++++++++++++++++\n 2 files changed, 75 insertions(+)","diff":"diff --git a/include/libcamera/class.h b/include/libcamera/class.h\nindex cb278e58204a..920624d8e726 100644\n--- a/include/libcamera/class.h\n+++ b/include/libcamera/class.h\n@@ -11,6 +11,24 @@\n \n namespace libcamera {\n \n+#ifndef __DOXYGEN__\n+#define LIBCAMERA_DISABLE_COPY(klass) \\\n+\tklass(const klass &) = delete; \\\n+\tklass &operator=(const klass &) = delete;\n+\n+#define LIBCAMERA_DISABLE_MOVE(klass) \\\n+\tklass(klass &&) = delete; \\\n+\tklass &operator=(klass &&) = delete;\n+\n+#define LIBCAMERA_DISABLE_COPY_AND_MOVE(klass) \\\n+\tLIBCAMERA_DISABLE_COPY(klass) \\\n+\tLIBCAMERA_DISABLE_MOVE(klass)\n+#else\n+#define LIBCAMERA_DISABLE_COPY(klass)\n+#define LIBCAMERA_DISABLE_MOVE(klass)\n+#define LIBCAMERA_DISABLE_COPY_AND_MOVE(klass)\n+#endif\n+\n #ifndef __DOXYGEN__\n #define LIBCAMERA_DECLARE_PRIVATE(klass)\t\t\t\t\\\n public:\t\t\t\t\t\t\t\t\t\\\ndiff --git a/src/libcamera/class.cpp b/src/libcamera/class.cpp\nindex ce230be91e61..c1db14197b4e 100644\n--- a/src/libcamera/class.cpp\n+++ b/src/libcamera/class.cpp\n@@ -17,6 +17,63 @@\n \n namespace libcamera {\n \n+/**\n+ * \\def LIBCAMERA_DISABLE_COPY\n+ * \\brief Disable copy construction and assignment of the \\a klass\n+ * \\param klass The name of the class\n+ *\n+ * Example usage:\n+ * \\code{.cpp}\n+ * class NonCopyable\n+ * {\n+ * public:\n+ * \tNonCopyable();\n+ * \t...\n+ *\n+ * private:\n+ * \tLIBCAMERA_DISABLE_COPY(NonCopyable)\n+ * };\n+ * \\endcode\n+ */\n+\n+/**\n+ * \\def LIBCAMERA_DISABLE_MOVE\n+ * \\brief Disable move construction and assignment of the \\a klass\n+ * \\param klass The name of the class\n+ *\n+ * Example usage:\n+ * \\code{.cpp}\n+ * class NonMoveable\n+ * {\n+ * public:\n+ * \tNonMoveable();\n+ * \t...\n+ *\n+ * private:\n+ * \tLIBCAMERA_DISABLE_MOVE(NonMoveable)\n+ * };\n+ * \\endcode\n+ */\n+\n+/**\n+ * \\def LIBCAMERA_DISABLE_COPY_AND_MOVE\n+ * \\brief Disable copy and move construction and assignment of the \\a klass\n+* \\param klass The name of the class\n+ *\n+ * Example usage:\n+ * \\code{.cpp}\n+ * class NonCopyableNonMoveable\n+ * {\n+ * public:\n+ * \tNonCopyableNonMoveable();\n+ * \t...\n+ *\n+ * private:\n+ * \tLIBCAMERA_DISABLE_COPY_AND_MOVE(NonCopyableNonMoveable)\n+ * };\n+ * \\endcode\n+ */\n+\n /**\n * \\def LIBCAMERA_DECLARE_PRIVATE\n * \\brief Declare private data for a public class\n","prefixes":["libcamera-devel","v3","2/7"]}