{"id":11252,"url":"https://patchwork.libcamera.org/api/1.1/patches/11252/?format=json","web_url":"https://patchwork.libcamera.org/patch/11252/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210212110926.6766-2-laurent.pinchart@ideasonboard.com>","date":"2021-02-12T11:09:26","name":"[libcamera-devel,2/2] utils: checkstyle.py: Handle renamed files in header add checker","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"eb3a8cb4dd23170fb9848fc4a60e869ee86e03c1","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":{"id":16,"url":"https://patchwork.libcamera.org/api/1.1/users/16/?format=json","username":"neg","first_name":"Niklas","last_name":"Söderlund","email":"niklas.soderlund@ragnatech.se"},"mbox":"https://patchwork.libcamera.org/patch/11252/mbox/","series":[{"id":1682,"url":"https://patchwork.libcamera.org/api/1.1/series/1682/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1682","date":"2021-02-12T11:09:25","name":"[libcamera-devel,1/2] utils: checkstyle.py: Restore checks of renamed files","version":1,"mbox":"https://patchwork.libcamera.org/series/1682/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/11252/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/11252/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6D091BD160\n\tfor ;\n\tFri, 12 Feb 2021 11:09:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3AF0763775;\n\tFri, 12 Feb 2021 12:09:59 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E158063772\n\tfor ;\n\tFri, 12 Feb 2021 12:09:56 +0100 (CET)","from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0ACBCA49\n\tfor ;\n\tFri, 12 Feb 2021 12:09:55 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Jw0rt9eM\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1613128196;\n\tbh=s5XVfGqQGKCp2IL4e2w538XCVWDgNZ7DNWxlaIH2XPY=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=Jw0rt9eMxzgK3SsaEqmPCOtgxOK7+1koOQ54DM8C8KWKxWYONUNfoM5K4ufNqzT0U\n\tTfLPUrIQV+WX6WQ/zStPr0jNq8yrnh5JNz2gmq4Eh2u95LDXL/XjmOzWKsyPbTSNiW\n\tX026HyPHuc6IJ41H8LP1ahOH6DuhF8SRQEChatLc=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 12 Feb 2021 13:09:26 +0200","Message-Id":"<20210212110926.6766-2-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.28.0","In-Reply-To":"<20210212110926.6766-1-laurent.pinchart@ideasonboard.com>","References":"<20210212110926.6766-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH 2/2] utils: checkstyle.py: Handle renamed\n\tfiles in header add checker","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The header add checker only handles added header, which makes it miss\nissues when a header is renamed. Fix it.\n\nFixes: 8fffab46b80f (\"utils: checkstyle.py: Add header add checker\")\nSigned-off-by: Laurent Pinchart \n---\n utils/checkstyle.py | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/utils/checkstyle.py b/utils/checkstyle.py\nindex 93a4fc70fafa..ececb46eaacc 100755\n--- a/utils/checkstyle.py\n+++ b/utils/checkstyle.py\n@@ -314,7 +314,7 @@ class HeaderAddChecker(CommitChecker):\n meson_files = [f for f in commit.files('M')\n if os.path.basename(f) == 'meson.build']\n \n- for filename in commit.files('A'):\n+ for filename in commit.files('AR'):\n if not filename.startswith('include/libcamera/') or \\\n not filename.endswith('.h'):\n continue\n","prefixes":["libcamera-devel","2/2"]}