{"id":11249,"url":"https://patchwork.libcamera.org/api/1.1/patches/11249/?format=json","web_url":"https://patchwork.libcamera.org/patch/11249/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210212054816.53561-5-paul.elder@ideasonboard.com>","date":"2021-02-12T05:48:16","name":"[libcamera-devel,v2,4/4] cam: Default camera location to external","commit_ref":null,"pull_url":null,"state":"changes-requested","archived":false,"hash":"d9b3b712bcfb19731d092f7c24121a516a40e0a8","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/1.1/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/11249/mbox/","series":[{"id":1680,"url":"https://patchwork.libcamera.org/api/1.1/series/1680/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1680","date":"2021-02-12T05:48:12","name":"Add Unknown camera location","version":2,"mbox":"https://patchwork.libcamera.org/series/1680/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/11249/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/11249/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E2313BD162\n\tfor ;\n\tFri, 12 Feb 2021 05:48:39 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AF9AB63761;\n\tFri, 12 Feb 2021 06:48:39 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D4B3A6375F\n\tfor ;\n\tFri, 12 Feb 2021 06:48:37 +0100 (CET)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3FDEFA49;\n\tFri, 12 Feb 2021 06:48:35 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"LRulRXhx\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1613108917;\n\tbh=dT+AXZJ+6QWkRueJrtMDP3KF6EPQYDbM1CWeLFAKrc0=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=LRulRXhxybunUAMzZM4iWcRN7a4Jex2+QR+Ha59JI7g9B/3urjlbi0ToU+vxPM6g8\n\tu4GLRi5GJLzhO4Qhd2yY1KBWGp049xZiraXv7Nk9rrVsxP7I1HWkgSnRR3p2XOVJD6\n\tJtz286Y5SYbTzpF1R4/2IBBrbqIBzTdxEUuqSsfs=","From":"Paul Elder ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 12 Feb 2021 14:48:16 +0900","Message-Id":"<20210212054816.53561-5-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20210212054816.53561-1-paul.elder@ideasonboard.com>","References":"<20210212054816.53561-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v2 4/4] cam: Default camera location to\n\texternal","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Now that we default the camera sensor location to Unknown, handle it in\ncam the same way external is handled.\n\nSigned-off-by: Paul Elder \n\n---\nNew in v2\n---\n src/cam/main.cpp | 1 +\n 1 file changed, 1 insertion(+)","diff":"diff --git a/src/cam/main.cpp b/src/cam/main.cpp\nindex e01be63a..261ed0c8 100644\n--- a/src/cam/main.cpp\n+++ b/src/cam/main.cpp\n@@ -387,6 +387,7 @@ std::string const CamApp::cameraName(const Camera *camera)\n \t\tname = \"Internal back camera\";\n \t\tbreak;\n \tcase properties::CameraLocationExternal:\n+\tcase properties::CameraLocationUnknown:\n \t\tname = \"External camera\";\n \t\tif (props.contains(properties::Model))\n \t\t\tname += \" '\" + props.get(properties::Model) + \"'\";\n","prefixes":["libcamera-devel","v2","4/4"]}