{"id":11248,"url":"https://patchwork.libcamera.org/api/1.1/patches/11248/?format=json","web_url":"https://patchwork.libcamera.org/patch/11248/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210212054816.53561-4-paul.elder@ideasonboard.com>","date":"2021-02-12T05:48:15","name":"[libcamera-devel,v2,3/4] android: camera_device: Default the camera location to Front","commit_ref":null,"pull_url":null,"state":"changes-requested","archived":false,"hash":"70cce0a12e892c491ef3a44fd397d85860ab9934","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/1.1/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/11248/mbox/","series":[{"id":1680,"url":"https://patchwork.libcamera.org/api/1.1/series/1680/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1680","date":"2021-02-12T05:48:12","name":"Add Unknown camera location","version":2,"mbox":"https://patchwork.libcamera.org/series/1680/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/11248/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/11248/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8448EBD162\n\tfor ;\n\tFri, 12 Feb 2021 05:48:37 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 524B063761;\n\tFri, 12 Feb 2021 06:48:37 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DA68463758\n\tfor ;\n\tFri, 12 Feb 2021 06:48:35 +0100 (CET)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C46C41508;\n\tFri, 12 Feb 2021 06:48:33 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"BXqRa318\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1613108915;\n\tbh=57jraHUXuHh17UJzhZUFRqdIz+RlVmGqTx53YPBTeXw=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=BXqRa318RWCJKPwocCUFpXx1vWlYWCGFAdmdWgOvf8rYuuEFhZwVyTVYOMd8iURXn\n\tdg7ukG1aL/DBdXD7Ww/EG4c74hR+j89WlTdffR9Syk9t2MSUl/bf98rKZsopYGa3MH\n\ttoVJ83Y+r25GsNvFOEeUCkrXxfTa8pohorLypqDE=","From":"Paul Elder ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 12 Feb 2021 14:48:15 +0900","Message-Id":"<20210212054816.53561-4-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20210212054816.53561-1-paul.elder@ideasonboard.com>","References":"<20210212054816.53561-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v2 3/4] android: camera_device: Default\n\tthe camera location to Front","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Since the libcamera camera now has an Unknown location, we can know if\nthe camera's location is actually unknown. In this case, set the android\ncamera location to front, as some systems may not support external\ncameras.\n\nThis allows the following CTS test to pass:\n- android.hardware.camera2.cts.CameraManagerTest#testCameraManagerGetDeviceIdList\n\nSigned-off-by: Paul Elder \nReviewed-by: Kieran Bingham \nReviewed-by: Laurent Pinchart \n\n---\nNo change in v2\n---\n src/android/camera_device.cpp | 3 +++\n 1 file changed, 3 insertions(+)","diff":"diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex 1e2a5b5f..3d815d21 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -407,6 +407,9 @@ int CameraDevice::initialize()\n \t\tcase properties::CameraLocationExternal:\n \t\t\tfacing_ = CAMERA_FACING_EXTERNAL;\n \t\t\tbreak;\n+\t\tcase properties::CameraLocationUnknown:\n+\t\t\tfacing_ = CAMERA_FACING_FRONT;\n+\t\t\tbreak;\n \t\t}\n \t}\n \n","prefixes":["libcamera-devel","v2","3/4"]}