{"id":11246,"url":"https://patchwork.libcamera.org/api/1.1/patches/11246/?format=json","web_url":"https://patchwork.libcamera.org/patch/11246/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210212054816.53561-2-paul.elder@ideasonboard.com>","date":"2021-02-12T05:48:13","name":"[libcamera-devel,v2,1/4] libcamera: properties: Add Unknown value to camera Location","commit_ref":null,"pull_url":null,"state":"changes-requested","archived":false,"hash":"7818fe3aa93854b43bc279735cc2b5474761e185","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/1.1/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/11246/mbox/","series":[{"id":1680,"url":"https://patchwork.libcamera.org/api/1.1/series/1680/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1680","date":"2021-02-12T05:48:12","name":"Add Unknown camera location","version":2,"mbox":"https://patchwork.libcamera.org/series/1680/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/11246/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/11246/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CE8E3BD162\n\tfor ;\n\tFri, 12 Feb 2021 05:48:31 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 993D163762;\n\tFri, 12 Feb 2021 06:48:31 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1520C63758\n\tfor ;\n\tFri, 12 Feb 2021 06:48:30 +0100 (CET)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D33398B5;\n\tFri, 12 Feb 2021 06:48:27 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"OhvjLQwU\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1613108909;\n\tbh=u9dAiqak9SfYSufq5X3NMWL7le+Xult7koj8lDjhtV4=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=OhvjLQwUe8sKkK0IjYBJDTEOI1taN5hcqqpR76LuAzB+gJ6Zb1LZorDZtQO9w/jhj\n\tJQec/3AipFt4eC4q0tqADk4ahYeQg7pxBNXp+uIB/C//son4LI4gGqg9XXNqT4PVtS\n\tzlKfTfcq5gcOgCubPtedvZwFiK7Ht217kOK25bwo=","From":"Paul Elder ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 12 Feb 2021 14:48:13 +0900","Message-Id":"<20210212054816.53561-2-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20210212054816.53561-1-paul.elder@ideasonboard.com>","References":"<20210212054816.53561-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v2 1/4] libcamera: properties: Add Unknown\n\tvalue to camera Location","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"If a camera's location is unknown, it should be set so, and not\ndefaulted to another location. Add such a value to the Location property\nenum.\n\nSigned-off-by: Paul Elder \nReviewed-by: Kieran Bingham \nReviewed-by: Laurent Pinchart \n\n---\nChanges in v2:\n- Unknown is now 0, the rest are incremented by 1\n---\n src/libcamera/property_ids.yaml | 10 +++++++---\n 1 file changed, 7 insertions(+), 3 deletions(-)","diff":"diff --git a/src/libcamera/property_ids.yaml b/src/libcamera/property_ids.yaml\nindex 104e9aaf..fd17bf0c 100644\n--- a/src/libcamera/property_ids.yaml\n+++ b/src/libcamera/property_ids.yaml\n@@ -10,18 +10,22 @@ controls:\n description: |\n Camera mounting location\n enum:\n- - name: CameraLocationFront\n+ - name: CameraLocationUnknown\n value: 0\n+ description: |\n+ The camera location is unknown\n+ - name: CameraLocationFront\n+ value: 1\n description: |\n The camera is mounted on the front side of the device, facing the\n user\n - name: CameraLocationBack\n- value: 1\n+ value: 2\n description: |\n The camera is mounted on the back side of the device, facing away\n from the user\n - name: CameraLocationExternal\n- value: 2\n+ value: 3\n description: |\n The camera is attached to the device in a way that allows it to\n be moved freely\n","prefixes":["libcamera-devel","v2","1/4"]}