{"id":11220,"url":"https://patchwork.libcamera.org/api/1.1/patches/11220/?format=json","web_url":"https://patchwork.libcamera.org/patch/11220/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210211071805.34963-10-paul.elder@ideasonboard.com>","date":"2021-02-11T07:18:04","name":"[libcamera-devel,v7,09/10] libcamera: IPCPipeUnixSocket: Check that insertion succeeds","commit_ref":null,"pull_url":null,"state":"changes-requested","archived":false,"hash":"253e3975509b0d48c54cbeb92f1123de745b1348","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/1.1/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/11220/mbox/","series":[{"id":1675,"url":"https://patchwork.libcamera.org/api/1.1/series/1675/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1675","date":"2021-02-11T07:17:55","name":"IPA isolation: Part 1: Core components","version":7,"mbox":"https://patchwork.libcamera.org/series/1675/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/11220/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/11220/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EEF0ABD162\n\tfor ;\n\tThu, 11 Feb 2021 07:18:40 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BD5C961664;\n\tThu, 11 Feb 2021 08:18:40 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 505DD61660\n\tfor ;\n\tThu, 11 Feb 2021 08:18:39 +0100 (CET)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7FE2B99D;\n\tThu, 11 Feb 2021 08:18:37 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"LIs+2Qfj\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1613027919;\n\tbh=f9v5E2vNg5DTDL3s4Wf3MBesuAnoDGfL+A2d68zErEQ=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=LIs+2QfjpTFdqAnlMaiUVv1wcta+HEa/D11rGNKKWbm51X8vuC0t6GwJlz4CVmgSQ\n\tNO3xMknY+Y9Tt1DUoOL32hwL5O3cdmaKO4Din3n+irNuJ77fhDNllLOgpyy0YAhrpw\n\txgPn+4tEi3ygoh7zkp3H3YQcoMcm3+hQwkavhrZU=","From":"Paul Elder ","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 11 Feb 2021 16:18:04 +0900","Message-Id":"<20210211071805.34963-10-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20210211071805.34963-1-paul.elder@ideasonboard.com>","References":"<20210211071805.34963-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v7 09/10] libcamera: IPCPipeUnixSocket:\n\tCheck that insertion succeeds","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"From: Niklas Söderlund \n\nMake sure the insertion succeeds. This was found by compile tests\nwith gcc7 which points out 'success' is not used.\n\n ../../src/libcamera/ipc_pipe_unixsocket.cpp:119:27: error: unused variable ‘success’ [-Werror=unused-variable]\n const auto [iter, success] = callData_.insert({ cookie, { response, false } });\n\nSigned-off-by: Niklas Söderlund \nReviewed-by: Paul Elder \n---\n src/libcamera/ipc_pipe_unixsocket.cpp | 5 +++++\n 1 file changed, 5 insertions(+)","diff":"diff --git a/src/libcamera/ipc_pipe_unixsocket.cpp b/src/libcamera/ipc_pipe_unixsocket.cpp\nindex 2bdce29e..cdb7eae0 100644\n--- a/src/libcamera/ipc_pipe_unixsocket.cpp\n+++ b/src/libcamera/ipc_pipe_unixsocket.cpp\n@@ -118,6 +118,11 @@ int IPCPipeUnixSocket::call(const IPCUnixSocket::Payload &message,\n \n \tconst auto [iter, success] = callData_.insert({ cookie, { response, false } });\n \n+\tif (!success) {\n+\t\tLOG(IPCPipe, Error) << \"Failed to insert call data\";\n+\t\treturn -EINVAL;\n+\t}\n+\n \tret = socket_->send(message);\n \tif (ret) {\n \t\tcallData_.erase(iter);\n","prefixes":["libcamera-devel","v7","09/10"]}