{"id":11209,"url":"https://patchwork.libcamera.org/api/1.1/patches/11209/?format=json","web_url":"https://patchwork.libcamera.org/patch/11209/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210210175830.32038-2-david.plowman@raspberrypi.com>","date":"2021-02-10T17:58:29","name":"[libcamera-devel,v2,1/2] ipa: raspberrypi: AWB: Remove unnecessary frame count variable","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"aebe79bcbc3b6726bb2e33f6ae876a6bddb2ffbf","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/1.1/people/42/?format=json","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/11209/mbox/","series":[{"id":1674,"url":"https://patchwork.libcamera.org/api/1.1/series/1674/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1674","date":"2021-02-10T17:58:28","name":"Raspberry Pi AWB race condition and maintenance","version":2,"mbox":"https://patchwork.libcamera.org/series/1674/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/11209/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/11209/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 23CF9BD160\n\tfor ;\n\tWed, 10 Feb 2021 17:58:39 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E4B6D61646;\n\tWed, 10 Feb 2021 18:58:38 +0100 (CET)","from mail-ej1-x636.google.com (mail-ej1-x636.google.com\n\t[IPv6:2a00:1450:4864:20::636])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 08A1C6162E\n\tfor ;\n\tWed, 10 Feb 2021 18:58:36 +0100 (CET)","by mail-ej1-x636.google.com with SMTP id w1so5706301ejf.11\n\tfor ;\n\tWed, 10 Feb 2021 09:58:36 -0800 (PST)","from pi4-davidp.lan (plowpeople3.plus.com. [80.229.223.72])\n\tby smtp.gmail.com with ESMTPSA id\n\thc13sm1660483ejc.5.2021.02.10.09.58.34\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 10 Feb 2021 09:58:34 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"h8nxRuoh\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=W6MmJZJLGnwy72pggNNug9dowL58ofDKZhSOvEPLblo=;\n\tb=h8nxRuoh1SARBZMvIbkIUJtjZ3mv+G93EB0YtsDMHD2TmfL3K/BaE9FCr2XwsCalZ2\n\t/MVSZ6IWqJAp/VmCP1R3JZDPs27t9JxADDZoI+KQci92ANsvx9GeunnCnhPe/C2NSI5I\n\tlfjG/19LxdiBRSkR5Cx/WBLMTI3re9ZzdhUxDw4Jeuxv5nDBJZGZFuonfXKECCZ0/U8V\n\tuMZRaUiCmGxhrwrAHSuyC0gvgJSfoU2ZG8X6wb0sL2AoAvde6wq6qbssfyMB7wjOU3GT\n\tednNPUm8DCuAPMuvDbtw09Pu3+HaRysAZcnG9dOvpGJ2DnS/Yz6slDaxujr8Z7BpQilJ\n\t/CCA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=W6MmJZJLGnwy72pggNNug9dowL58ofDKZhSOvEPLblo=;\n\tb=DvDdm2fGczXUzZM5aWubnkn5tCVQ4+4MG3OovfYGucW0MR3Z8UPkUWGhLBs226Ka75\n\tTAAyDS6VgnAshCxGnrXOl0YDyFc33qWbhUNoY2ztSl0wsLAI8cPCaGCf5ws7LmkqKRq7\n\tWvjtjbm6nqk3cG4ER6/dmSNVANUtDcP6GhUyFdSHoZsQ16jeeHYK2KcgeTTDXC6xhPbQ\n\t1MP0hVEsZtq1XlQbFSrtX7nYIkX8+E7xwTyvN7l79wiBz1qiWnBgOozqXgCae2h1WOrY\n\tGy/SvowX+Gqvfnop3xJTPgjdHnWWk5EpGsGF/Z/69NnTN4vkIhw4EQPRfmeI3FlMfUca\n\tMfdg==","X-Gm-Message-State":"AOAM531zYOzBTKfxbSL5TcIK+L+Z3aWC3vJ6t2WHcTrS8P/SFjJr7QiT\n\tnDQWHr2dxpzKRS+bAeXfyQUMNYhddW/JfVTd","X-Google-Smtp-Source":"ABdhPJyT8/ys/+BEdL3pXcuAb+cMB+4xo49RL9kSr2oFw4yXT+DYVxprW4PrTQcOgnPHt3I20WybFg==","X-Received":"by 2002:a17:906:d19b:: with SMTP id\n\tc27mr4159864ejz.234.1612979915186; \n\tWed, 10 Feb 2021 09:58:35 -0800 (PST)","From":"David Plowman ","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 10 Feb 2021 17:58:29 +0000","Message-Id":"<20210210175830.32038-2-david.plowman@raspberrypi.com>","X-Mailer":"git-send-email 2.20.1","In-Reply-To":"<20210210175830.32038-1-david.plowman@raspberrypi.com>","References":"<20210210175830.32038-1-david.plowman@raspberrypi.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v2 1/2] ipa: raspberrypi: AWB: Remove\n\tunnecessary frame count variable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The variable frame_count2_ is not needed as Prepare() and Process()\nalways run in lock step one after the other.\n\nSigned-off-by: David Plowman \nReviewed-by: Laurent Pinchart \nReviewed-by: Naushir Patuck \n---\n src/ipa/raspberrypi/controller/rpi/awb.cpp | 6 ++----\n src/ipa/raspberrypi/controller/rpi/awb.hpp | 1 -\n 2 files changed, 2 insertions(+), 5 deletions(-)","diff":"diff --git a/src/ipa/raspberrypi/controller/rpi/awb.cpp b/src/ipa/raspberrypi/controller/rpi/awb.cpp\nindex 791b5108..1c65eda8 100644\n--- a/src/ipa/raspberrypi/controller/rpi/awb.cpp\n+++ b/src/ipa/raspberrypi/controller/rpi/awb.cpp\n@@ -153,7 +153,7 @@ void Awb::Read(boost::property_tree::ptree const ¶ms)\n \n void Awb::Initialise()\n {\n-\tframe_count2_ = frame_count_ = frame_phase_ = 0;\n+\tframe_count_ = frame_phase_ = 0;\n \t// Put something sane into the status that we are filtering towards,\n \t// just in case the first few frames don't have anything meaningful in\n \t// them.\n@@ -288,11 +288,9 @@ void Awb::Process(StatisticsPtr &stats, Metadata *image_metadata)\n \t// Count frames since we last poked the async thread.\n \tif (frame_phase_ < (int)config_.frame_period)\n \t\tframe_phase_++;\n-\tif (frame_count2_ < (int)config_.startup_frames)\n-\t\tframe_count2_++;\n \tLOG(RPiAwb, Debug) << \"frame_phase \" << frame_phase_;\n \tif (frame_phase_ >= (int)config_.frame_period ||\n-\t frame_count2_ < (int)config_.startup_frames) {\n+\t frame_count_ < (int)config_.startup_frames) {\n \t\t// Update any settings and any image metadata that we need.\n \t\tstruct LuxStatus lux_status = {};\n \t\tlux_status.lux = 400; // in case no metadata\ndiff --git a/src/ipa/raspberrypi/controller/rpi/awb.hpp b/src/ipa/raspberrypi/controller/rpi/awb.hpp\nindex 1b39ab4b..f113c642 100644\n--- a/src/ipa/raspberrypi/controller/rpi/awb.hpp\n+++ b/src/ipa/raspberrypi/controller/rpi/awb.hpp\n@@ -130,7 +130,6 @@ private:\n \t// counts up to frame_period before restarting the async thread\n \tint frame_phase_;\n \tint frame_count_; // counts up to startup_frames\n-\tint frame_count2_; // counts up to startup_frames for Process method\n \tAwbStatus sync_results_;\n \tAwbStatus prev_sync_results_;\n \tstd::string mode_name_;\n","prefixes":["libcamera-devel","v2","1/2"]}