{"id":11202,"url":"https://patchwork.libcamera.org/api/1.1/patches/11202/?format=json","web_url":"https://patchwork.libcamera.org/patch/11202/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210208234733.2637061-3-niklas.soderlund@ragnatech.se>","date":"2021-02-08T23:47:33","name":"[libcamera-devel,RFC,2/2] ipu3: Translate IPA protocol to new mojo interface","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"b03b9a8aed4fb707ad35b84a14e221a93117933b","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/1.1/people/5/?format=json","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"delegate":{"id":17,"url":"https://patchwork.libcamera.org/api/1.1/users/17/?format=json","username":"epaul","first_name":"Paul","last_name":"Elder","email":"paul.elder@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/patch/11202/mbox/","series":[{"id":1670,"url":"https://patchwork.libcamera.org/api/1.1/series/1670/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1670","date":"2021-02-08T23:47:31","name":"ipu3: Translate IPA protocol to new mojo interface","version":1,"mbox":"https://patchwork.libcamera.org/series/1670/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/11202/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/11202/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 53A71BD162\n\tfor ;\n\tMon, 8 Feb 2021 23:47:58 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2FD126161D;\n\tTue, 9 Feb 2021 00:47:58 +0100 (CET)","from vsp-unauthed02.binero.net (vsp-unauthed02.binero.net\n\t[195.74.38.227])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 90DD2615F7\n\tfor ;\n\tTue, 9 Feb 2021 00:47:55 +0100 (CET)","from bismarck.berto.se (p4fca2458.dip0.t-ipconnect.de\n\t[79.202.36.88])\n\tby bin-vsp-out-02.atm.binero.net (Halon) with ESMTPA\n\tid 0fbc3f05-6a68-11eb-a076-005056917f90;\n\tTue, 09 Feb 2021 00:47:54 +0100 (CET)"],"X-Halon-ID":"0fbc3f05-6a68-11eb-a076-005056917f90","Authorized-sender":"niklas.soderlund@fsdn.se","From":"=?utf-8?q?Niklas_S=C3=B6derlund?= ","To":"Paul Elder ","Date":"Tue, 9 Feb 2021 00:47:33 +0100","Message-Id":"<20210208234733.2637061-3-niklas.soderlund@ragnatech.se>","X-Mailer":"git-send-email 2.30.0","In-Reply-To":"<20210208234733.2637061-1-niklas.soderlund@ragnatech.se>","References":"<20210208234733.2637061-1-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Subject":"[libcamera-devel] [RFC 2/2] ipu3: Translate IPA protocol to new\n\tmojo interface","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Translate the IPA interface to the out-of-tree protocol based on mojo.\nPlease borrow, modify and squash anything in this patch to expedite the\nintegration of the new and _much_ nicer IPA IPC interface!\n\nSigned-off-by: Niklas Söderlund \n---\n include/libcamera/ipa/ipu3.h | 23 -------\n include/libcamera/ipa/ipu3.mojom | 43 +++++++++++++\n include/libcamera/ipa/meson.build | 1 +\n src/ipa/ipu3/ipu3.cpp | 74 ++++++++-------------\n src/ipa/ipu3/meson.build | 6 +-\n src/libcamera/pipeline/ipu3/ipu3.cpp | 96 +++++++++++-----------------\n 6 files changed, 113 insertions(+), 130 deletions(-)\n delete mode 100644 include/libcamera/ipa/ipu3.h\n create mode 100644 include/libcamera/ipa/ipu3.mojom","diff":"diff --git a/include/libcamera/ipa/ipu3.h b/include/libcamera/ipa/ipu3.h\ndeleted file mode 100644\nindex cbaaef04417b701b..0000000000000000\n--- a/include/libcamera/ipa/ipu3.h\n+++ /dev/null\n@@ -1,23 +0,0 @@\n-/* SPDX-License-Identifier: LGPL-2.1-or-later */\n-/*\n- * Copyright (C) 2020, Google Inc.\n- *\n- * ipu3.h - Image Processing Algorithm interface for IPU3\n- */\n-#ifndef __LIBCAMERA_IPA_INTERFACE_IPU3_H__\n-#define __LIBCAMERA_IPA_INTERFACE_IPU3_H__\n-\n-#ifndef __DOXYGEN__\n-\n-enum IPU3Operations {\n-\tIPU3_IPA_ACTION_SET_SENSOR_CONTROLS = 1,\n-\tIPU3_IPA_ACTION_PARAM_FILLED = 2,\n-\tIPU3_IPA_ACTION_METADATA_READY = 3,\n-\tIPU3_IPA_EVENT_PROCESS_CONTROLS = 4,\n-\tIPU3_IPA_EVENT_STAT_READY = 5,\n-\tIPU3_IPA_EVENT_FILL_PARAMS = 6,\n-};\n-\n-#endif /* __DOXYGEN__ */\n-\n-#endif /* __LIBCAMERA_IPA_INTERFACE_IPU3_H__ */\ndiff --git a/include/libcamera/ipa/ipu3.mojom b/include/libcamera/ipa/ipu3.mojom\nnew file mode 100644\nindex 0000000000000000..6ee1133392d0787c\n--- /dev/null\n+++ b/include/libcamera/ipa/ipu3.mojom\n@@ -0,0 +1,43 @@\n+/* SPDX-License-Identifier: LGPL-2.1-or-later */\n+\n+module ipa.ipu3;\n+\n+import \"include/libcamera/ipa/core.mojom\";\n+\n+enum IPU3Operations {\n+\tActionSetSensorControls = 1,\n+\tActionParamFilled = 2,\n+\tActionMetadataReady = 3,\n+\tEventProcessControls = 4,\n+\tEventStatReady = 5,\n+\tEventFillParams = 6,\n+};\n+\n+struct IPU3Event {\n+\tIPU3Operations op;\n+\tuint32 frame;\n+\tuint32 bufferId;\n+\tControlList controls;\n+};\n+\n+struct IPU3Action {\n+\tIPU3Operations op;\n+\tControlList controls;\n+};\n+\n+interface IPAIPU3Interface {\n+\tinit(IPASettings settings) => (int32 ret);\n+\tstart() => (int32 ret);\n+\tstop();\n+\n+\tconfigure(map entityControls) => ();\n+\n+\tmapBuffers(array buffers);\n+\tunmapBuffers(array ids);\n+\n+\t[async] processEvent(IPU3Event ev);\n+};\n+\n+interface IPAIPU3EventInterface {\n+\tqueueFrameAction(uint32 frame, IPU3Action action);\n+};\ndiff --git a/include/libcamera/ipa/meson.build b/include/libcamera/ipa/meson.build\nindex d701bccc7d7c3065..fe8aa65b7d0bfd6d 100644\n--- a/include/libcamera/ipa/meson.build\n+++ b/include/libcamera/ipa/meson.build\n@@ -55,6 +55,7 @@ libcamera_generated_ipa_headers += custom_target('core_ipa_serializer_h',\n ])\n \n ipa_mojom_files = [\n+ 'ipu3.mojom',\n 'raspberrypi.mojom',\n 'rkisp1.mojom',\n 'vimc.mojom',\ndiff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\nindex b11b03efa6ceb666..fcd8889cbd24fc8c 100644\n--- a/src/ipa/ipu3/ipu3.cpp\n+++ b/src/ipa/ipu3/ipu3.cpp\n@@ -5,8 +5,6 @@\n * ipu3.cpp - IPU3 Image Processing Algorithms\n */\n \n-#include \n-\n #include \n #include \n \n@@ -17,10 +15,9 @@\n #include \n #include \n #include \n+#include \n #include \n \n-#include \n-\n #include \"libcamera/internal/buffer.h\"\n #include \"libcamera/internal/log.h\"\n \n@@ -28,25 +25,21 @@ namespace libcamera {\n \n LOG_DEFINE_CATEGORY(IPAIPU3)\n \n-class IPAIPU3 : public IPAInterface\n+class IPAIPU3 : public ipa::ipu3::IPAIPU3Interface\n {\n public:\n \tint init([[maybe_unused]] const IPASettings &settings) override\n \t{\n \t\treturn 0;\n \t}\n-\tint start([[maybe_unused]] const IPAOperationData &data,\n-\t\t [[maybe_unused]] IPAOperationData *result) override { return 0; }\n+\tint start() override { return 0; }\n \tvoid stop() override {}\n \n-\tvoid configure(const CameraSensorInfo &info,\n-\t\t const std::map &streamConfig,\n-\t\t const std::map &entityControls,\n-\t\t const IPAOperationData &ipaConfig,\n-\t\t IPAOperationData *response) override;\n+\tvoid configure(const std::map &entityControls) override;\n+\n \tvoid mapBuffers(const std::vector &buffers) override;\n \tvoid unmapBuffers(const std::vector &ids) override;\n-\tvoid processEvent(const IPAOperationData &event) override;\n+\tvoid processEvent(const ipa::ipu3::IPU3Event &event) override;\n \n private:\n \tvoid processControls(unsigned int frame, const ControlList &controls);\n@@ -69,11 +62,7 @@ private:\n \tuint32_t maxGain_;\n };\n \n-void IPAIPU3::configure([[maybe_unused]] const CameraSensorInfo &info,\n-\t\t\t[[maybe_unused]] const std::map &streamConfig,\n-\t\t\tconst std::map &entityControls,\n-\t\t\t[[maybe_unused]] const IPAOperationData &ipaConfig,\n-\t\t\t[[maybe_unused]] IPAOperationData *result)\n+void IPAIPU3::configure(const std::map &entityControls)\n {\n \tif (entityControls.empty())\n \t\treturn;\n@@ -123,19 +112,15 @@ void IPAIPU3::unmapBuffers(const std::vector &ids)\n \t}\n }\n \n-void IPAIPU3::processEvent(const IPAOperationData &event)\n+void IPAIPU3::processEvent(const ipa::ipu3::IPU3Event &event)\n {\n-\tswitch (event.operation) {\n-\tcase IPU3_IPA_EVENT_PROCESS_CONTROLS: {\n-\t\tunsigned int frame = event.data[0];\n-\t\tprocessControls(frame, event.controls[0]);\n+\tswitch (event.op) {\n+\tcase ipa::ipu3::EventProcessControls: {\n+\t\tprocessControls(event.frame, event.controls);\n \t\tbreak;\n \t}\n-\tcase IPU3_IPA_EVENT_STAT_READY: {\n-\t\tunsigned int frame = event.data[0];\n-\t\tunsigned int bufferId = event.data[1];\n-\n-\t\tauto it = buffers_.find(bufferId);\n+\tcase ipa::ipu3::EventStatReady: {\n+\t\tauto it = buffers_.find(event.bufferId);\n \t\tif (it == buffers_.end()) {\n \t\t\tLOG(IPAIPU3, Error) << \"Could not find stats buffer!\";\n \t\t\treturn;\n@@ -145,14 +130,11 @@ void IPAIPU3::processEvent(const IPAOperationData &event)\n \t\tconst ipu3_uapi_stats_3a *stats =\n \t\t\treinterpret_cast(mem.data());\n \n-\t\tparseStatistics(frame, stats);\n+\t\tparseStatistics(event.frame, stats);\n \t\tbreak;\n \t}\n-\tcase IPU3_IPA_EVENT_FILL_PARAMS: {\n-\t\tunsigned int frame = event.data[0];\n-\t\tunsigned int bufferId = event.data[1];\n-\n-\t\tauto it = buffers_.find(bufferId);\n+\tcase ipa::ipu3::EventFillParams: {\n+\t\tauto it = buffers_.find(event.bufferId);\n \t\tif (it == buffers_.end()) {\n \t\t\tLOG(IPAIPU3, Error) << \"Could not find param buffer!\";\n \t\t\treturn;\n@@ -162,11 +144,11 @@ void IPAIPU3::processEvent(const IPAOperationData &event)\n \t\tipu3_uapi_params *params =\n \t\t\treinterpret_cast(mem.data());\n \n-\t\tfillParams(frame, params);\n+\t\tfillParams(event.frame, params);\n \t\tbreak;\n \t}\n \tdefault:\n-\t\tLOG(IPAIPU3, Error) << \"Unknown event \" << event.operation;\n+\t\tLOG(IPAIPU3, Error) << \"Unknown event \" << event.op;\n \t\tbreak;\n \t}\n }\n@@ -184,8 +166,8 @@ void IPAIPU3::fillParams(unsigned int frame, ipu3_uapi_params *params)\n \n \t/* \\todo Fill in parameters buffer. */\n \n-\tIPAOperationData op;\n-\top.operation = IPU3_IPA_ACTION_PARAM_FILLED;\n+\tipa::ipu3::IPU3Action op;\n+\top.op = ipa::ipu3::ActionParamFilled;\n \n \tqueueFrameAction.emit(frame, op);\n \n@@ -201,22 +183,22 @@ void IPAIPU3::parseStatistics(unsigned int frame,\n \t/* \\todo React to statistics and update internal state machine. */\n \t/* \\todo Add meta-data information to ctrls. */\n \n-\tIPAOperationData op;\n-\top.operation = IPU3_IPA_ACTION_METADATA_READY;\n-\top.controls.push_back(ctrls);\n+\tipa::ipu3::IPU3Action op;\n+\top.op = ipa::ipu3::ActionMetadataReady;\n+\top.controls = ctrls;\n \n \tqueueFrameAction.emit(frame, op);\n }\n \n void IPAIPU3::setControls(unsigned int frame)\n {\n-\tIPAOperationData op;\n-\top.operation = IPU3_IPA_ACTION_SET_SENSOR_CONTROLS;\n+\tipa::ipu3::IPU3Action op;\n+\top.op = ipa::ipu3::ActionSetSensorControls;\n \n \tControlList ctrls(ctrls_);\n \tctrls.set(V4L2_CID_EXPOSURE, static_cast(exposure_));\n \tctrls.set(V4L2_CID_ANALOGUE_GAIN, static_cast(gain_));\n-\top.controls.push_back(ctrls);\n+\top.controls = ctrls;\n \n \tqueueFrameAction.emit(frame, op);\n }\n@@ -233,9 +215,9 @@ const struct IPAModuleInfo ipaModuleInfo = {\n \t\"ipu3\",\n };\n \n-struct ipa_context *ipaCreate()\n+IPAInterface *ipaCreate()\n {\n-\treturn new IPAInterfaceWrapper(std::make_unique());\n+\treturn new IPAIPU3();\n }\n }\n \ndiff --git a/src/ipa/ipu3/meson.build b/src/ipa/ipu3/meson.build\nindex 444c82453eac42ff..1ced00ae2ce4bf92 100644\n--- a/src/ipa/ipu3/meson.build\n+++ b/src/ipa/ipu3/meson.build\n@@ -3,10 +3,10 @@\n ipa_name = 'ipa_ipu3'\n \n mod = shared_module(ipa_name,\n- 'ipu3.cpp',\n+ ['ipu3.cpp', libcamera_generated_ipa_headers],\n name_prefix : '',\n- include_directories : [ ipa_includes, libipa_includes ],\n- dependencies : [ libatomic, libcamera_dep ],\n+ include_directories : [ipa_includes, libipa_includes],\n+ dependencies : libcamera_dep,\n link_with : libipa,\n install : true,\n install_dir : ipa_install_dir)\ndiff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\nindex 61f7bf43ea08699a..c21bfa46be1ba85a 100644\n--- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n@@ -14,7 +14,9 @@\n #include \n #include \n #include \n-#include \n+#include \n+#include \n+#include \n #include \n #include \n \n@@ -77,8 +79,11 @@ public:\n \tstd::unique_ptr delayedCtrls_;\n \tIPU3Frames frameInfos_;\n \n+\tstd::unique_ptr ipa_;\n+\n private:\n-\tvoid queueFrameAction(unsigned int id, const IPAOperationData &op);\n+\tvoid queueFrameAction(unsigned int id,\n+\t\t\t const ipa::ipu3::IPU3Action &action);\n };\n \n class IPU3CameraConfiguration : public CameraConfiguration\n@@ -609,18 +614,14 @@ int PipelineHandlerIPU3::allocateBuffers(Camera *camera)\n \n \tfor (const std::unique_ptr &buffer : imgu->paramBuffers_) {\n \t\tbuffer->setCookie(ipaBufferId++);\n-\t\tipaBuffers_.push_back({\n-\t\t\t.id = buffer->cookie(),\n-\t\t\t.planes = buffer->planes()\n-\t\t});\n+\t\tipaBuffers_.push_back(IPABuffer(buffer->cookie(),\n+\t\t\t\t\t\tbuffer->planes()));\n \t}\n \n \tfor (const std::unique_ptr &buffer : imgu->statBuffers_) {\n \t\tbuffer->setCookie(ipaBufferId++);\n-\t\tipaBuffers_.push_back({\n-\t\t\t.id = buffer->cookie(),\n-\t\t\t.planes = buffer->planes()\n-\t\t});\n+\t\tipaBuffers_.push_back(IPABuffer(buffer->cookie(),\n+\t\t\t\t\t\tbuffer->planes()));\n \t}\n \n \tdata->ipa_->mapBuffers(ipaBuffers_);\n@@ -650,16 +651,10 @@ int PipelineHandlerIPU3::freeBuffers(Camera *camera)\n \n int PipelineHandlerIPU3::start(Camera *camera, [[maybe_unused]] ControlList *controls)\n {\n+\tstd::map entityControls;\n \tIPU3CameraData *data = cameraData(camera);\n \tCIO2Device *cio2 = &data->cio2_;\n \tImgUDevice *imgu = data->imgu_;\n-\n-\tCameraSensorInfo sensorInfo = {};\n-\tstd::map streamConfig;\n-\tstd::map entityControls;\n-\tIPAOperationData ipaConfig;\n-\tIPAOperationData result = {};\n-\n \tint ret;\n \n \t/* Allocate buffers for internal pipeline usage. */\n@@ -667,8 +662,7 @@ int PipelineHandlerIPU3::start(Camera *camera, [[maybe_unused]] ControlList *con\n \tif (ret)\n \t\treturn ret;\n \n-\tIPAOperationData ipaData = {};\n-\tret = data->ipa_->start(ipaData, nullptr);\n+\tret = data->ipa_->start();\n \tif (ret)\n \t\tgoto error;\n \n@@ -684,24 +678,8 @@ int PipelineHandlerIPU3::start(Camera *camera, [[maybe_unused]] ControlList *con\n \tif (ret)\n \t\tgoto error;\n \n-\t/* Inform IPA of stream configuration and sensor controls. */\n-\tret = data->cio2_.sensor()->sensorInfo(&sensorInfo);\n-\tif (ret)\n-\t\tgoto error;\n-\n-\tstreamConfig[0] = {\n-\t\t.pixelFormat = data->outStream_.configuration().pixelFormat,\n-\t\t.size = data->outStream_.configuration().size,\n-\t};\n-\tstreamConfig[1] = {\n-\t\t.pixelFormat = data->vfStream_.configuration().pixelFormat,\n-\t\t.size = data->vfStream_.configuration().size,\n-\t};\n-\n \tentityControls.emplace(0, data->cio2_.sensor()->controls());\n-\n-\tdata->ipa_->configure(sensorInfo, streamConfig, entityControls,\n-\t\t\t ipaConfig, &result);\n+\tdata->ipa_->configure(entityControls);\n \n \treturn 0;\n \n@@ -751,11 +729,11 @@ int PipelineHandlerIPU3::queueRequestDevice(Camera *camera, Request *request)\n \n \tinfo->rawBuffer = rawBuffer;\n \n-\tIPAOperationData op;\n-\top.operation = IPU3_IPA_EVENT_PROCESS_CONTROLS;\n-\top.data = { info->id };\n-\top.controls = { request->controls() };\n-\tdata->ipa_->processEvent(op);\n+\tipa::ipu3::IPU3Event ev;\n+\tev.op = ipa::ipu3::EventProcessControls;\n+\tev.frame = info->id;\n+\tev.controls = request->controls();\n+\tdata->ipa_->processEvent(ev);\n \n \treturn 0;\n }\n@@ -1048,7 +1026,7 @@ int PipelineHandlerIPU3::registerCameras()\n \n int IPU3CameraData::loadIPA()\n {\n-\tipa_ = IPAManager::createIPA(pipe_, 1, 1);\n+\tipa_ = IPAManager::createIPA(pipe_, 1, 1);\n \tif (!ipa_)\n \t\treturn -ENOENT;\n \n@@ -1060,15 +1038,15 @@ int IPU3CameraData::loadIPA()\n }\n \n void IPU3CameraData::queueFrameAction(unsigned int id,\n-\t\t\t\t const IPAOperationData &action)\n+\t\t\t\t const ipa::ipu3::IPU3Action &action)\n {\n-\tswitch (action.operation) {\n-\tcase IPU3_IPA_ACTION_SET_SENSOR_CONTROLS: {\n-\t\tconst ControlList &controls = action.controls[0];\n+\tswitch (action.op) {\n+\tcase ipa::ipu3::ActionSetSensorControls: {\n+\t\tconst ControlList &controls = action.controls;\n \t\tdelayedCtrls_->push(controls);\n \t\tbreak;\n \t}\n-\tcase IPU3_IPA_ACTION_PARAM_FILLED: {\n+\tcase ipa::ipu3::ActionParamFilled: {\n \t\tIPU3Frames::Info *info = frameInfos_.find(id);\n \t\tif (!info)\n \t\t\tbreak;\n@@ -1090,13 +1068,13 @@ void IPU3CameraData::queueFrameAction(unsigned int id,\n \n \t\tbreak;\n \t}\n-\tcase IPU3_IPA_ACTION_METADATA_READY: {\n+\tcase ipa::ipu3::ActionMetadataReady: {\n \t\tIPU3Frames::Info *info = frameInfos_.find(id);\n \t\tif (!info)\n \t\t\tbreak;\n \n \t\tRequest *request = info->request;\n-\t\trequest->metadata() = action.controls[0];\n+\t\trequest->metadata() = action.controls;\n \t\tinfo->metadataProcessed = true;\n \t\tif (frameInfos_.tryComplete(info))\n \t\t\tpipe_->completeRequest(request);\n@@ -1104,7 +1082,7 @@ void IPU3CameraData::queueFrameAction(unsigned int id,\n \t\tbreak;\n \t}\n \tdefault:\n-\t\tLOG(IPU3, Error) << \"Unknown action \" << action.operation;\n+\t\tLOG(IPU3, Error) << \"Unknown action \" << action.op;\n \t\tbreak;\n \t}\n }\n@@ -1172,10 +1150,11 @@ void IPU3CameraData::cio2BufferReady(FrameBuffer *buffer)\n \tif (request->findBuffer(&rawStream_))\n \t\tpipe_->completeBuffer(request, buffer);\n \n-\tIPAOperationData op;\n-\top.operation = IPU3_IPA_EVENT_FILL_PARAMS;\n-\top.data = { info->id, info->paramBuffer->cookie() };\n-\tipa_->processEvent(op);\n+\tipa::ipu3::IPU3Event ev;\n+\tev.op = ipa::ipu3::EventFillParams;\n+\tev.frame = info->id;\n+\tev.bufferId = info->paramBuffer->cookie();\n+\tipa_->processEvent(ev);\n }\n \n void IPU3CameraData::paramBufferReady(FrameBuffer *buffer)\n@@ -1202,10 +1181,11 @@ void IPU3CameraData::statBufferReady(FrameBuffer *buffer)\n \t\treturn;\n \t}\n \n-\tIPAOperationData op;\n-\top.operation = IPU3_IPA_EVENT_STAT_READY;\n-\top.data = { info->id, info->statBuffer->cookie() };\n-\tipa_->processEvent(op);\n+\tipa::ipu3::IPU3Event ev;\n+\tev.op = ipa::ipu3::EventStatReady;\n+\tev.frame = info->id;\n+\tev.bufferId = info->statBuffer->cookie();\n+\tipa_->processEvent(ev);\n }\n \n REGISTER_PIPELINE_HANDLER(PipelineHandlerIPU3)\n","prefixes":["libcamera-devel","RFC","2/2"]}