{"id":11191,"url":"https://patchwork.libcamera.org/api/1.1/patches/11191/?format=json","web_url":"https://patchwork.libcamera.org/patch/11191/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210208150738.2293520-4-naush@raspberrypi.com>","date":"2021-02-08T15:07:35","name":"[libcamera-devel,v6,3/6] uapi: raspberrypi: Update the bcm2835-isp header definition","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"b4ce3c3aa49bfa21660f80552fef0643510192b9","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/1.1/people/34/?format=json","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/11191/mbox/","series":[{"id":1666,"url":"https://patchwork.libcamera.org/api/1.1/series/1666/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1666","date":"2021-02-08T15:07:32","name":"Raspberry Pi: Colour denoise","version":6,"mbox":"https://patchwork.libcamera.org/series/1666/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/11191/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/11191/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A1136BD160\n\tfor ;\n\tMon, 8 Feb 2021 15:07:57 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3DC6760D2B;\n\tMon, 8 Feb 2021 16:07:57 +0100 (CET)","from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com\n\t[IPv6:2a00:1450:4864:20::42d])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3B05E60D20\n\tfor ;\n\tMon, 8 Feb 2021 16:07:56 +0100 (CET)","by mail-wr1-x42d.google.com with SMTP id b3so17526386wrj.5\n\tfor ;\n\tMon, 08 Feb 2021 07:07:56 -0800 (PST)","from naush-laptop.pitowers.org (cust51-dsl50.idnet.net.\n\t[212.69.50.51]) by smtp.gmail.com with ESMTPSA id\n\ta17sm31261389wrx.63.2021.02.08.07.07.54\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 08 Feb 2021 07:07:54 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"WX5HpsC4\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=3HH8/GUJORTvoTeFuBrsV0XIkD1kOM1ZRQFK0DdpmdE=;\n\tb=WX5HpsC4/GZSwASifETmCXTctAMT4OE/VBHxloymOfHhBzcot1fD1LypIGIpHS78cR\n\tvz8fZFTtsxszsIBIB+mdZAy7I2CstzEYvYoqM3W7OPCw7+elm7BeMdXh18jEwAhi43IV\n\tDNKvyereKQml9URcJ7+tltrSr2NZAE5YMi33BSKm71E5zrGhN1TvahUGugtYp4Wtx96V\n\tSNILbvAPgcgQTRVID94OcK51hvshTLqTKd35dix3SzYZ4As/LlNMW0mxMZP9iZPaOTSk\n\tCYTWu48ERe29I/V5OMs3IiogHvCms8hlrlI4kZPAN61OIZwkIIA1zLf6KQP4D+NYFemA\n\tPn8A==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=3HH8/GUJORTvoTeFuBrsV0XIkD1kOM1ZRQFK0DdpmdE=;\n\tb=lbFj3UzXJJFsfIOMJ9FfbYhHb1WmhxdntalQrwsNSwVg313xjt419snTwZxybxJ5LH\n\tcSeAeUFBYuW/SxEn3U6y8NpjRwLlILnokWFLcBlrkqd9+x+7mbUB6M3v3MEUnDjqnrjQ\n\tpFfJyGgSfDHahz4hSlICuAndV3bIQ4LeCCt82qsy+aNlCeKB6L+r0f9xwpK6YwdLIKTM\n\tpCsBIWlQ5imxTkBioVBEOuFPhM81iYTP3c5kJTmPF+UdnHnaRhTiCoSIuvZrrpTrNQoN\n\tEhot2jC4BZ/sb3T+Ym+2UJtDGnEQ0mYYRTfaf8qRvO0P9IEH+xkiMdwnRr6oEonPNGsB\n\tNMoQ==","X-Gm-Message-State":"AOAM530G7qQQ9F8ZJK6dbdNtwiyYIyz4mZeCqcpKxkuHK4Y20KAwcwWM\n\tAiBUKWiUbm2S4fQ6D8qk9LTuclTM90q3eqKY","X-Google-Smtp-Source":"ABdhPJyMLgoiiB/1KZKLvjR2R5xZlstWDx1IzHoj4tzmvqARWYoF6IE+gd91jsqwc6YGPCavRt5W6A==","X-Received":"by 2002:a5d:5049:: with SMTP id\n\th9mr20942064wrt.404.1612796875466; \n\tMon, 08 Feb 2021 07:07:55 -0800 (PST)","From":"Naushir Patuck ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 8 Feb 2021 15:07:35 +0000","Message-Id":"<20210208150738.2293520-4-naush@raspberrypi.com>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20210208150738.2293520-1-naush@raspberrypi.com>","References":"<20210208150738.2293520-1-naush@raspberrypi.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v6 3/6] uapi: raspberrypi: Update the\n\tbcm2835-isp header definition","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Update the bcm2835-isp.h file with the latest version available in the\ndownstream Raspberry Pi linux repo at commit:\n68878170d8a98afd6d519a3a2c909080c19de4ce\n\nThis change adds support for colour denoise processing, and the\nfollowing downstream kernel changes must be available:\nhttps://github.com/raspberrypi/linux/pull/4069\nhttps://github.com/raspberrypi/linux/pull/4083\n\nThe Raspberry Pi image must also be running the latest firmware,\nobtained by running rpi-update.\n\nSigned-off-by: Naushir Patuck \nReviewed-by: David Plowman \nAcked-by: Kieran Bingham \nReviewed-by: Laurent Pinchart \n---\n include/linux/bcm2835-isp.h | 32 +++++++++++++++++++++++++++++---\n 1 file changed, 29 insertions(+), 3 deletions(-)","diff":"diff --git a/include/linux/bcm2835-isp.h b/include/linux/bcm2835-isp.h\nindex 45abb681517e..94c3af947883 100644\n--- a/include/linux/bcm2835-isp.h\n+++ b/include/linux/bcm2835-isp.h\n@@ -31,7 +31,8 @@\n \t\t\t\t(V4L2_CID_USER_BCM2835_ISP_BASE + 0x0007)\n #define V4L2_CID_USER_BCM2835_ISP_DPC\t\t\\\n \t\t\t\t(V4L2_CID_USER_BCM2835_ISP_BASE + 0x0008)\n-\n+#define V4L2_CID_USER_BCM2835_ISP_CDN \\\n+\t\t\t\t(V4L2_CID_USER_BCM2835_ISP_BASE + 0x0009)\n /*\n * All structs below are directly mapped onto the equivalent structs in\n * drivers/staging/vc04_services/vchiq-mmal/mmal-parameters.h\n@@ -46,7 +47,7 @@\n */\n struct bcm2835_isp_rational {\n \t__s32 num;\n-\t__s32 den;\n+\t__u32 den;\n };\n \n /**\n@@ -140,7 +141,7 @@ struct bcm2835_isp_black_level {\n \t__u16 black_level_r;\n \t__u16 black_level_g;\n \t__u16 black_level_b;\n-\t__u8 pad_[2]; /* Unused */\n+\t__u8 padding[2]; /* Unused */\n };\n \n /**\n@@ -175,6 +176,31 @@ struct bcm2835_isp_gamma {\n \t__u16 y[BCM2835_NUM_GAMMA_PTS];\n };\n \n+/**\n+ * enum bcm2835_isp_cdn_mode - Mode of operation for colour denoise.\n+ *\n+ * @CDN_MODE_FAST:\t\tFast (but lower quality) colour denoise\n+ *\t\t\t\talgorithm, typically used for video recording.\n+ * @CDN_HIGH_QUALITY:\t\tHigh quality (but slower) colour denoise\n+ *\t\t\t\talgorithm, typically used for stills capture.\n+ */\n+enum bcm2835_isp_cdn_mode {\n+\tCDN_MODE_FAST = 0,\n+\tCDN_MODE_HIGH_QUALITY = 1,\n+};\n+\n+/**\n+ * struct bcm2835_isp_cdn - Colour denoise parameters set with the\n+ *\t\t\t V4L2_CID_USER_BCM2835_ISP_CDN ctrl.\n+ *\n+ * @enabled:\tEnable colour denoise.\n+ * @cdn_mode:\tColour denoise operating mode (see enum &bcm2835_isp_cdn_mode)\n+ */\n+struct bcm2835_isp_cdn {\n+\t__u32 enabled;\n+\t__u32 mode;\n+};\n+\n /**\n * struct bcm2835_isp_denoise - Denoise parameters set with the\n *\t\t\t\tV4L2_CID_USER_BCM2835_ISP_DENOISE ctrl.\n","prefixes":["libcamera-devel","v6","3/6"]}