{"id":1118,"url":"https://patchwork.libcamera.org/api/1.1/patches/1118/?format=json","web_url":"https://patchwork.libcamera.org/patch/1118/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190427012509.32153-1-kieran.bingham@ideasonboard.com>","date":"2019-04-27T01:25:09","name":"[libcamera-devel] libcamera: v4l2_device: Prefix V4L2 direction in log messages","commit_ref":"c34e09d33a6d81e1bbe818a8e652e0c60de50982","pull_url":null,"state":"accepted","archived":false,"hash":"a0797dce329496ebdae16b243a4d86d6acd3a9d3","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/1.1/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/1118/mbox/","series":[{"id":275,"url":"https://patchwork.libcamera.org/api/1.1/series/275/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=275","date":"2019-04-27T01:25:09","name":"[libcamera-devel] libcamera: v4l2_device: Prefix V4L2 direction in log messages","version":1,"mbox":"https://patchwork.libcamera.org/series/275/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/1118/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/1118/checks/","tags":{},"headers":{"Return-Path":"<kieran.bingham@ideasonboard.com>","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4116360B1B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 27 Apr 2019 03:25:19 +0200 (CEST)","from Q.station (net-37-182-44-227.cust.vodafonedsl.it\n\t[37.182.44.227])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A1C4F5F;\n\tSat, 27 Apr 2019 03:25:18 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1556328318;\n\tbh=aUphwSAa90BQ/rYeEW8ww8DV52rlxiDqt6xritr5/aw=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=vG8x5kexqWzGzR5nGzclmhozIpi6WhRFfT4qHywAppmCK5k3jilnOnDmPyN0c2Kr3\n\tsEbT4PnVUEJv7DwKQvdx+Va/m9fqQ0r4xX6OB0VBfdU72/LV0ETvnbc72UvO5+W6Cu\n\tg1PHw01Sef5s87V2gpu/MdRHKJQ+u6SzXoiRFnGo=","From":"Kieran Bingham <kieran.bingham@ideasonboard.com>","To":"LibCamera Devel <libcamera-devel@lists.libcamera.org>","Date":"Sat, 27 Apr 2019 03:25:09 +0200","Message-Id":"<20190427012509.32153-1-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.19.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH] libcamera: v4l2_device: Prefix V4L2\n\tdirection in log messages","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Sat, 27 Apr 2019 01:25:19 -0000"},"content":"The V4L2Device will use the same deviceNode for two directions in the\ncase of an M2M device.\n\nAdd the direction to identify the queue direction on each instance.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/libcamera/v4l2_device.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/v4l2_device.cpp b/src/libcamera/v4l2_device.cpp\nindex a6e9ca247828..a21944160253 100644\n--- a/src/libcamera/v4l2_device.cpp\n+++ b/src/libcamera/v4l2_device.cpp\n@@ -415,7 +415,7 @@ void V4L2Device::close()\n \n std::string V4L2Device::logPrefix() const\n {\n-\treturn deviceNode_;\n+\treturn deviceNode_ + (V4L2_TYPE_IS_OUTPUT(bufferType_) ? \"[out]\" : \"[cap]\");\n }\n \n /**\n","prefixes":["libcamera-devel"]}