{"id":11178,"url":"https://patchwork.libcamera.org/api/1.1/patches/11178/?format=json","web_url":"https://patchwork.libcamera.org/patch/11178/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210205170317.267605-1-kieran.bingham@ideasonboard.com>","date":"2021-02-05T17:03:17","name":"[libcamera-devel,RFC] libcamera: camera_sensor: Report mandatory control names","commit_ref":null,"pull_url":null,"state":"rejected","archived":false,"hash":"fe25031ca9cd6eb90d5395ffb65144f0b2a3c533","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/1.1/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":{"id":11,"url":"https://patchwork.libcamera.org/api/1.1/users/11/?format=json","username":"kbingham","first_name":"Kieran","last_name":"Bingham","email":"kieran.bingham@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/patch/11178/mbox/","series":[{"id":1658,"url":"https://patchwork.libcamera.org/api/1.1/series/1658/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1658","date":"2021-02-05T17:03:17","name":"[libcamera-devel,RFC] libcamera: camera_sensor: Report mandatory control names","version":1,"mbox":"https://patchwork.libcamera.org/series/1658/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/11178/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/11178/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AC3C7BD160\n\tfor ;\n\tFri, 5 Feb 2021 17:03:22 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2D3BB614BB;\n\tFri, 5 Feb 2021 18:03:22 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9FF9C614B0\n\tfor ;\n\tFri, 5 Feb 2021 18:03:21 +0100 (CET)","from Q.local (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net\n\t[86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 28815316;\n\tFri, 5 Feb 2021 18:03:21 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"pCEE4vMx\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1612544601;\n\tbh=R6eDQmXWtc8B6DBF260QXZe6QpoGn6XwP7AELGBERo4=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=pCEE4vMxYHmIHubt33lYSF1fQpPToljUFR/vhNwQdthBpbvVEgbs2FuRQyzwEyV2A\n\tEIFiIXZ/85Zh8lUzV6mOjbqqlMub5QgzGEvFH5BiB16GFncQfgdjPzOPkA3+WeERlj\n\tA6YTVNJ+SQOkCMj1SQKYLC9ip5mX4mmiQPsbHn88=","From":"Kieran Bingham ","To":"libcamera devel ","Date":"Fri, 5 Feb 2021 17:03:17 +0000","Message-Id":"<20210205170317.267605-1-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.25.1","MIME-Version":"1.0","Subject":"[libcamera-devel] [RFC PATCH] libcamera: camera_sensor: Report\n\tmandatory control names","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"We can not obtain the control names directly from V4L2 so create\na map of the control name, when declaring the list of mandatory\ncontrols to enable a human readable print of any missing requirements.\n\nSigned-off-by: Kieran Bingham \n---\n src/libcamera/camera_sensor.cpp | 21 +++++++++++++--------\n 1 file changed, 13 insertions(+), 8 deletions(-)","diff":"diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp\nindex c9e8d49b7935..9a510108f171 100644\n--- a/src/libcamera/camera_sensor.cpp\n+++ b/src/libcamera/camera_sensor.cpp\n@@ -346,18 +346,23 @@ int CameraSensor::validateSensorDriver()\n \t * For raw sensors, make sure the sensor driver supports the controls\n \t * required by the CameraSensor class.\n \t */\n-\tstatic constexpr uint32_t mandatoryControls[] = {\n-\t\tV4L2_CID_EXPOSURE,\n-\t\tV4L2_CID_HBLANK,\n-\t\tV4L2_CID_PIXEL_RATE,\n-\t\tV4L2_CID_VBLANK,\n+\tstatic struct {\n+\t\tuint32_t ctrl;\n+\t\tstd::string name;\n+\t} mandatoryControls[] = {\n+#define MANDATORY_CONTROL(__ctrl) { __ctrl, #__ctrl }\n+\t\tMANDATORY_CONTROL(V4L2_CID_EXPOSURE),\n+\t\tMANDATORY_CONTROL(V4L2_CID_HBLANK),\n+\t\tMANDATORY_CONTROL(V4L2_CID_PIXEL_RATE),\n+\t\tMANDATORY_CONTROL(V4L2_CID_VBLANK),\n+#undef MANDATORY_CONTROL\n \t};\n \n \terr = 0;\n-\tfor (uint32_t ctrl : mandatoryControls) {\n-\t\tif (!controls.count(ctrl)) {\n+\tfor (auto &c : mandatoryControls) {\n+\t\tif (!controls.count(c.ctrl)) {\n \t\t\tLOG(CameraSensor, Error)\n-\t\t\t\t<< \"Mandatory V4L2 control \" << utils::hex(ctrl)\n+\t\t\t\t<< \"Mandatory V4L2 control \" << c.name\n \t\t\t\t<< \" not available\";\n \t\t\terr = -EINVAL;\n \t\t}\n","prefixes":["libcamera-devel","RFC"]}