{"id":1114,"url":"https://patchwork.libcamera.org/api/1.1/patches/1114/?format=json","web_url":"https://patchwork.libcamera.org/patch/1114/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190426150155.18652-9-laurent.pinchart@ideasonboard.com>","date":"2019-04-26T15:01:55","name":"[libcamera-devel,8/8] cam: options: Fix string concatenation","commit_ref":"4c8989cdf7b7fcf1c6e84c2688584c2a7394ea18","pull_url":null,"state":"accepted","archived":false,"hash":"1833ef526906c308a7ae108d442add86918a8a2d","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/1114/mbox/","series":[{"id":271,"url":"https://patchwork.libcamera.org/api/1.1/series/271/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=271","date":"2019-04-26T15:01:47","name":"Fix clang compilation warnings and errors","version":1,"mbox":"https://patchwork.libcamera.org/series/271/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/1114/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/1114/checks/","tags":{},"headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EA38960EAB\n\tfor ;\n\tFri, 26 Apr 2019 17:02:11 +0200 (CEST)","from pendragon.station (net-37-182-44-227.cust.vodafonedsl.it\n\t[37.182.44.227])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 89B25337\n\tfor ;\n\tFri, 26 Apr 2019 17:02:11 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1556290931;\n\tbh=tG8x2XpZGO+G4aG01WPWdtBoFK80P1WKQj4cDpkWTh0=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=pPqDZALveX8SzyklIWAJcLhKIdYhqcGA+Yieeyu0vghPRVYvvWoRm7sbgWA0P8a9+\n\t5VjbWzwHHKPaEX2nM16GTf+6qVNPTuw6dkWWDhnUlzFy+FIN+p1UDmbVcYDplDhxgJ\n\tWHNoIckp5y+6aYbfbMOxpCJssc+E5Rpm/vbLFJww=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 26 Apr 2019 18:01:55 +0300","Message-Id":"<20190426150155.18652-9-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.21.0","In-Reply-To":"<20190426150155.18652-1-laurent.pinchart@ideasonboard.com>","References":"<20190426150155.18652-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 8/8] cam: options: Fix string concatenation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 26 Apr 2019 15:02:13 -0000"},"content":"Adding an integer value to a char pointer doesn't concatenate strings,\nit indexes in the pointed string. Fix it.\n\nSigned-off-by: Laurent Pinchart \n---\n src/cam/options.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/cam/options.cpp b/src/cam/options.cpp\nindex b80d361eaaf4..bea4a600d1d5 100644\n--- a/src/cam/options.cpp\n+++ b/src/cam/options.cpp\n@@ -530,7 +530,7 @@ void OptionsParser::parseValueError(const Option &option)\n \tif (option.name)\n \t\toptionName = \"--\" + std::string(option.name);\n \telse\n-\t\toptionName = \"-\" + static_cast(option.opt);\n+\t\toptionName = \"-\" + std::string(1, option.opt);\n \n \tstd::cerr << \"Can't parse \" << option.typeName()\n \t\t << \" argument for option \" << optionName << std::endl;\n","prefixes":["libcamera-devel","8/8"]}